Changeset 142290 in webkit

Timestamp:

Feb 8, 2013 9:12:32 AM (11 years ago)

Author:

tkent@chromium.org

Message:

[Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
​https://bugs.webkit.org/show_bug.cgi?id=109272

Reviewed by Kentaro Hara.

Source/WebKit/chromium:

We enabled this flag for desktop Chromium, but disabled the feature by a
runtime flag. We disables the compile flag too because we have no plan
to ship it in near future.

• features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.

LayoutTests:

• platform/chromium/TestExpectations:

Skip fast/forms/datetime and datetime-multiple-fields

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/chromium/TestExpectations (modified) (1 diff)
• Source/WebCore/html/InputType.h (modified) (1 diff)
• Source/WebKit/chromium/ChangeLog (modified) (1 diff)
• Source/WebKit/chromium/features.gypi (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-08  Kent Tamura  <tkent@chromium.org>
+
+        [Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
+        https://bugs.webkit.org/show_bug.cgi?id=109272
+
+        Reviewed by Kentaro Hara.
+
+        * platform/chromium/TestExpectations:
+        Skip fast/forms/datetime and datetime-multiple-fields
+
 2013-02-08  Stephen Chenney  <schenney@chromium.org>
 

trunk/LayoutTests/platform/chromium/TestExpectations

@@ -938 +938 @@
 # Chromium disabled web intents
 crbug.com/173194 webintents [ Skip ]
+
+# We disabled INPUT_TYPE_DATETIME.
+webkit.org/b/109272 fast/forms/datetime [ Skip ]
+webkit.org/b/109272 fast/forms/datetime-multiple-fields [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-step-attribute.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-reset-value-after-reload.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-key-operations.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-min-max-attribute.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime-with-step.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/calendar-picker/calendar-picker-datetime.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance.html [ Skip ]
+webkit.org/b/109272 platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-mouse-operations.html [ Skip ]
 
 # Skipping rules for ANDROID are in platform/chromium-android/TestExpectations.

trunk/Source/WebCore/html/InputType.h

@@ -327 +327 @@
 
 } // namespace WebCore
-
-#endif
+#endif

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2013-02-08  Kent Tamura  <tkent@chromium.org>
+
+        [Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
+        https://bugs.webkit.org/show_bug.cgi?id=109272
+
+        Reviewed by Kentaro Hara.
+
+        We enabled this flag for desktop Chromium, but disabled the feature by a
+        runtime flag. We disables the compile flag too because we have no plan
+        to ship it in near future.
+
+        * features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.
+
 2013-02-08  Stephen Chenney  <schenney@chromium.org>
 

trunk/Source/WebKit/chromium/features.gypi

@@ -169 +169 @@
           'ENABLE_INPUT_SPEECH=0',
           'ENABLE_INPUT_TYPE_COLOR=0',
-          'ENABLE_INPUT_TYPE_DATETIME=0',
           'ENABLE_INPUT_TYPE_WEEK=0',
           'ENABLE_LEGACY_NOTIFICATIONS=0',
@@ -191 +190 @@
           'ENABLE_INPUT_SPEECH=1',
           'ENABLE_INPUT_TYPE_COLOR=1',
-          'ENABLE_INPUT_TYPE_DATETIME=1',
           'ENABLE_INPUT_TYPE_WEEK=1',
           'ENABLE_INPUT_MULTIPLE_FIELDS_UI=1',