Changeset 142350 in webkit

Timestamp:

Feb 8, 2013 10:13:40 PM (11 years ago)

Author:

weinig@apple.com

Message:

Fix ASSERT when the Web Content Process crashes
​https://bugs.webkit.org/show_bug.cgi?id=109346

Reviewed by Simon Fraser.

• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processDidCrash):
We need to remove ourselves as a message receiver before calling out to the client, as
the client might want to re-add us (as Safari does).

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-02-08  Sam Weinig  <sam@webkit.org>
+
+        Fix ASSERT when the Web Content Process crashes
+        https://bugs.webkit.org/show_bug.cgi?id=109346
+
+        Reviewed by Simon Fraser.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::WebPageProxy::processDidCrash):
+        We need to remove ourselves as a message receiver before calling out to the client, as
+        the client might want to re-add us (as Safari does).
+
 2013-02-08  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp

@@ -3564 +3564 @@
     ASSERT(m_pageClient);
 
+    m_process->removeMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_pageID);
+
     m_isValid = false;
     m_isPageSuspended = false;
@@ -3679 +3681 @@
     m_pageClient->dismissDictionaryLookupPanel();
 #endif
-
-    m_process->removeMessageReceiver(Messages::WebPageProxy::messageReceiverName(), m_pageID);
 }