Changeset 142423 in webkit

Timestamp:

Feb 10, 2013 6:54:14 PM (11 years ago)

Author:

aelias@chromium.org

Message:

[chromium] Fix Android scrollbar size
​https://bugs.webkit.org/show_bug.cgi?id=109374

Reviewed by James Robinson.

This shrinks scrollbars to 3 device-independent pixels (usually 6
physical pixels) and deletes the edge fade. Although the Android
system theme does have an edge fade, it's a much sharper cliff
than we had (against black, the colors go 64 -> 64 -> 52 -> 21 -> 0)
and I can't perceive any difference compared with no fade at all.

No new tests (due for rewrite in a week anyway).

• platform/chromium/ScrollbarThemeChromiumAndroid.cpp:

(WebCore):
(WebCore::ScrollbarThemeChromiumAndroid::paintThumb):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/chromium/ScrollbarThemeChromiumAndroid.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-10  Alexandre Elias  <aelias@chromium.org>
+
+        [chromium] Fix Android scrollbar size
+        https://bugs.webkit.org/show_bug.cgi?id=109374
+
+        Reviewed by James Robinson.
+
+        This shrinks scrollbars to 3 device-independent pixels (usually 6
+        physical pixels) and deletes the edge fade. Although the Android
+        system theme does have an edge fade, it's a much sharper cliff
+        than we had (against black, the colors go 64 -> 64 -> 52 -> 21 -> 0)
+        and I can't perceive any difference compared with no fade at all.
+
+        No new tests (due for rewrite in a week anyway).
+
+        * platform/chromium/ScrollbarThemeChromiumAndroid.cpp:
+        (WebCore):
+        (WebCore::ScrollbarThemeChromiumAndroid::paintThumb):
+
 2013-02-04  Kentaro Hara  <haraken@chromium.org>
 

trunk/Source/WebCore/platform/chromium/ScrollbarThemeChromiumAndroid.cpp

@@ -38 +38 @@
 namespace WebCore {
 
-static const int scrollbarWidth = 8;
-static const int scrollbarMargin = 5;
+static const int scrollbarWidth = 3;
+static const int scrollbarMargin = 4;
 
 ScrollbarTheme* ScrollbarTheme::nativeTheme()
@@ -105 +105 @@
 }
 
-static void fillSmoothEdgedRect(GraphicsContext* context, const IntRect& rect, const Color& color)
-{
-    Color halfColor(color.red(), color.green(), color.blue(), color.alpha() / 2);
-
-    IntRect topRect = rect;
-    topRect.inflateX(-1);
-    topRect.setHeight(1);
-    context->fillRect(topRect, halfColor, ColorSpaceDeviceRGB);
-
-    IntRect leftRect = rect;
-    leftRect.inflateY(-1);
-    leftRect.setWidth(1);
-    context->fillRect(leftRect, halfColor, ColorSpaceDeviceRGB);
-
-    IntRect centerRect = rect;
-    centerRect.inflate(-1);
-    context->fillRect(centerRect, color, ColorSpaceDeviceRGB);
-
-    IntRect rightRect = rect;
-    rightRect.inflateY(-1);
-    rightRect.setX(centerRect.maxX());
-    rightRect.setWidth(1);
-    context->fillRect(rightRect, halfColor, ColorSpaceDeviceRGB);
-
-    IntRect bottomRect = rect;
-    bottomRect.inflateX(-1);
-    bottomRect.setY(centerRect.maxY());
-    bottomRect.setHeight(1);
-    context->fillRect(bottomRect, halfColor, ColorSpaceDeviceRGB);
-}
-
 void ScrollbarThemeChromiumAndroid::paintThumb(GraphicsContext* context, ScrollbarThemeClient* scrollbar, const IntRect& rect)
 {
@@ -143 +112 @@
     else
         thumbRect.setWidth(thumbRect.width() - scrollbarMargin);
-    fillSmoothEdgedRect(context, thumbRect, Color(128, 128, 128, 128));
+    context->fillRect(thumbRect, Color(128, 128, 128, 128), ColorSpaceDeviceRGB);
 }