Changeset 142450 in webkit

Timestamp:

Feb 11, 2013 3:49:43 AM (11 years ago)

Author:

pfeldman@chromium.org

Message:

Web Inspector: highlight DOM nodes on hover while debugging
​https://bugs.webkit.org/show_bug.cgi?id=109355

Reviewed by Vsevolod Vlasov.

Along with showing the popover, highlight the remote object as node.

• inspector/front-end/ObjectPopoverHelper.js:

(WebInspector.ObjectPopoverHelper.prototype.):
(WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
(WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/ObjectPopoverHelper.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-11  Pavel Feldman  <pfeldman@chromium.org>
+
+        Web Inspector: highlight DOM nodes on hover while debugging
+        https://bugs.webkit.org/show_bug.cgi?id=109355
+
+        Reviewed by Vsevolod Vlasov.
+
+        Along with showing the popover, highlight the remote object as node.
+
+        * inspector/front-end/ObjectPopoverHelper.js:
+        (WebInspector.ObjectPopoverHelper.prototype.):
+        (WebInspector.ObjectPopoverHelper.prototype._showObjectPopover):
+        (WebInspector.ObjectPopoverHelper.prototype._onHideObjectPopover):
+
 2013-02-11  Andrey Lushnikov  <lushnikov@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/ObjectPopoverHelper.js

@@ -107 +107 @@
                 popover.show(popoverContentElement, anchorElement);
             } else {
+                if (result.subtype === "node")
+                    result.highlightAsDOMNode();
                 popoverContentElement = document.createElement("div");
-
                 this._titleElement = document.createElement("div");
                 this._titleElement.className = "source-frame-popover-title monospace";
@@ -135 +136 @@
     _onHideObjectPopover: function()
     {
+        WebInspector.domAgent.hideDOMNodeHighlight();
         if (this._linkifier) {
             this._linkifier.reset();