Changeset 142463 in webkit

Timestamp:

Feb 11, 2013 6:43:33 AM (11 years ago)

Author:

zandobersek@gmail.com

Message:

[GTK][Clang] Build errors in LocalizedStringsGtk.cpp
​https://bugs.webkit.org/show_bug.cgi?id=109418

Reviewed by Philippe Normand.

Use the C++ isfinite(float) and abs(float) (instead of fabsf(float))
methods by including the WTF MathExtras.h header. Use a static cast to
an integer type on the float return value of the abs(float) method call
instead of the C-style cast.

No new tests - no new functiolnality.

• platform/gtk/LocalizedStringsGtk.cpp:

(WebCore::localizedMediaTimeDescription):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/gtk/LocalizedStringsGtk.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-11  Zan Dobersek  <zdobersek@igalia.com>
+
+        [GTK][Clang] Build errors in LocalizedStringsGtk.cpp
+        https://bugs.webkit.org/show_bug.cgi?id=109418
+
+        Reviewed by Philippe Normand.
+
+        Use the C++ isfinite(float) and abs(float) (instead of fabsf(float))
+        methods by including the WTF MathExtras.h header. Use a static cast to
+        an integer type on the float return value of the abs(float) method call
+        instead of the C-style cast.
+
+        No new tests - no new functiolnality.
+
+        * platform/gtk/LocalizedStringsGtk.cpp:
+        (WebCore::localizedMediaTimeDescription):
+
 2013-02-11  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp

@@ -35 +35 @@
 #include "IntSize.h"
 #include "NotImplemented.h"
+#include <wtf/MathExtras.h>
 #include <wtf/text/CString.h>
 #include <wtf/text/WTFString.h>
@@ -40 +41 @@
 #include <glib/gi18n-lib.h>
 #include <gtk/gtk.h>
-#include <math.h>
 
 namespace WebCore {
@@ -627 +627 @@
         return String::fromUTF8(_("indefinite time"));
 
-    int seconds = (int)fabsf(time);
+    int seconds = static_cast<int>(abs(time));
     int days = seconds / (60 * 60 * 24);
     int hours = seconds / (60 * 60);