Changeset 142496 in webkit

Timestamp:

Feb 11, 2013 12:37:51 PM (11 years ago)

Author:

fmalita@chromium.org

Message:

[Chromium] FilterTypeSaturatingBrightness enum
​https://bugs.webkit.org/show_bug.cgi?id=109380

Introduce a new WebFilterOperation::FilterType enum (FilterTypeSaturatingBrightness)
to support existing interntal clients which rely on the current saturating brightness
behavior (in preparation of switching to the new brightness implementation).

Reviewed by James Robinson.

• chromium/public/WebFilterOperation.h:

(WebKit::WebFilterOperation::amount):
(WebKit::WebFilterOperation::createSaturatingBrightnessFilter):
(WebKit::WebFilterOperation::setAmount):

Location:

trunk/Source/Platform

Files:

• ChangeLog (modified) (1 diff)
• chromium/public/WebFilterOperation.h (modified) (4 diffs)

trunk/Source/Platform/ChangeLog

@@ +1 @@
+2013-02-10  Florin Malita  <fmalita@chromium.org>
+
+        [Chromium] FilterTypeSaturatingBrightness enum
+        https://bugs.webkit.org/show_bug.cgi?id=109380
+
+        Introduce a new WebFilterOperation::FilterType enum (FilterTypeSaturatingBrightness)
+        to support existing interntal clients which rely on the current saturating brightness
+        behavior (in preparation of switching to the new brightness implementation).
+
+        Reviewed by James Robinson.
+
+        * chromium/public/WebFilterOperation.h:
+        (WebKit::WebFilterOperation::amount):
+        (WebKit::WebFilterOperation::createSaturatingBrightnessFilter):
+        (WebKit::WebFilterOperation::setAmount):
+
 2013-02-09  James Robinson  <jamesr@chromium.org>
 

trunk/Source/Platform/chromium/public/WebFilterOperation.h

@@ -50 +50 @@
         FilterTypeColorMatrix,
         FilterTypeZoom,
+        FilterTypeSaturatingBrightness, // Not used in CSS/SVG.
     };
 
@@ -66 +67 @@
                    || m_type == FilterTypeBlur
                    || m_type == FilterTypeDropShadow
-                   || m_type == FilterTypeZoom);
+                   || m_type == FilterTypeZoom
+                   || m_type == FilterTypeSaturatingBrightness);
         return m_amount;
     }
@@ -103 +105 @@
     static WebFilterOperation createColorMatrixFilter(SkScalar matrix[20]) { return WebFilterOperation(FilterTypeColorMatrix, matrix); }
     static WebFilterOperation createZoomFilter(WebRect rect, int inset) { return WebFilterOperation(FilterTypeZoom, rect, inset); }
+    static WebFilterOperation createSaturatingBrightnessFilter(float amount) { return WebFilterOperation(FilterTypeSaturatingBrightness, amount); }
 
     bool equals(const WebFilterOperation& other) const;
@@ -121 +124 @@
                    || m_type == FilterTypeBlur
                    || m_type == FilterTypeDropShadow
-                   || m_type == FilterTypeZoom);
+                   || m_type == FilterTypeZoom
+                   || m_type == FilterTypeSaturatingBrightness);
         m_amount = amount;
     }