Changeset 142502 in webkit

Timestamp:

Feb 11, 2013 1:26:00 PM (11 years ago)

Author:

andersca@apple.com

Message:

The plug-in process connection manager doesn't need to be heap allocated
​https://bugs.webkit.org/show_bug.cgi?id=109479

Reviewed by Andreas Kling.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::pluginProcessConnectionManager):
(WebKit::WebProcess::pluginProcessCrashed):

• WebProcess/WebProcess.h:

(WebKit):
(WebProcess):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebProcess.cpp (modified) (3 diffs)
• WebProcess/WebProcess.h (modified) (3 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2013-02-11  Anders Carlsson  <andersca@apple.com>
+
+        The plug-in process connection manager doesn't need to be heap allocated
+        https://bugs.webkit.org/show_bug.cgi?id=109479
+
+        Reviewed by Andreas Kling.
+
+        * WebProcess/WebProcess.cpp:
+        (WebKit::WebProcess::WebProcess):
+        (WebKit::WebProcess::pluginProcessConnectionManager):
+        (WebKit::WebProcess::pluginProcessCrashed):
+        * WebProcess/WebProcess.h:
+        (WebKit):
+        (WebProcess):
+
 2013-02-11  Tony Chang  <tony@chromium.org>
 

trunk/Source/WebKit2/WebProcess/WebProcess.cpp

@@ -163 +163 @@
     , m_webResourceLoadScheduler(new WebResourceLoadScheduler)
 #endif
-#if ENABLE(PLUGIN_PROCESS)
-    , m_pluginProcessConnectionManager(new PluginProcessConnectionManager)
-#endif
 #if USE(SOUP)
     , m_soupRequestManager(this)
@@ -446 +443 @@
 PluginProcessConnectionManager& WebProcess::pluginProcessConnectionManager()
 {
-    return *m_pluginProcessConnectionManager;
+    return m_pluginProcessConnectionManager;
 }
 #endif
@@ -985 +982 @@
 void WebProcess::pluginProcessCrashed(CoreIPC::Connection*, const String& pluginPath, uint32_t processType)
 {
-    m_pluginProcessConnectionManager->pluginProcessCrashed(pluginPath, static_cast<PluginProcess::Type>(processType));
+    m_pluginProcessConnectionManager.pluginProcessCrashed(pluginPath, static_cast<PluginProcess::Type>(processType));
 }
 #endif

trunk/Source/WebKit2/WebProcess/WebProcess.h

@@ -31 +31 @@
 #include "DownloadManager.h"
 #include "EventDispatcher.h"
+#include "PluginProcessConnectionManager.h"
 #include "ResourceCachesToClear.h"
 #include "SandboxExtension.h"
@@ -91 +92 @@
 #if ENABLE(NETWORK_PROCESS)
 class WebResourceLoadScheduler;
-#endif
-
-#if ENABLE(PLUGIN_PROCESS)
-class PluginProcessConnectionManager;
 #endif
 
@@ -337 +334 @@
 
 #if ENABLE(PLUGIN_PROCESS)
-    PluginProcessConnectionManager* m_pluginProcessConnectionManager;
+    PluginProcessConnectionManager m_pluginProcessConnectionManager;
 #endif