Changeset 142538 in webkit

Timestamp:

Feb 11, 2013 4:01:36 PM (11 years ago)

Author:

yoli@rim.com

Message:

XMLHttpRequestProgressEventThrottle::resume() always schedules timer even when unnecessary
​https://bugs.webkit.org/show_bug.cgi?id=105348

Reviewed by Alexey Proskuryakov.

Let resume() clear the defer flag and return if there is deferred events to dispatch.

No new tests as this should not affect existing cross-platform behavior. It should be
OK as long as it doesn't break anything.

• xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::resume):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• xml/XMLHttpRequestProgressEventThrottle.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-11  Yong Li  <yoli@rim.com>
+
+        XMLHttpRequestProgressEventThrottle::resume() always schedules timer even when unnecessary
+        https://bugs.webkit.org/show_bug.cgi?id=105348
+
+        Reviewed by Alexey Proskuryakov.
+
+        Let resume() clear the defer flag and return if there is deferred events to dispatch.
+
+        No new tests as this should not affect existing cross-platform behavior. It should be
+        OK as long as it doesn't break anything.
+
+        * xml/XMLHttpRequestProgressEventThrottle.cpp:
+        (WebCore::XMLHttpRequestProgressEventThrottle::resume):
+
 2013-02-11  Eric Seidel  <eric@webkit.org>
 

trunk/Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.cpp

@@ -199 +199 @@
     ASSERT(!m_total);
 
+    if (m_deferredEvents.isEmpty() && !m_deferredProgressEvent) {
+        m_deferEvents = false;
+        return;
+    }
+
     // Do not dispatch events inline here, since ScriptExecutionContext is iterating over
     // the list of active DOM objects to resume them, and any activated JS event-handler