Changeset 142568 in webkit

Timestamp:

Feb 11, 2013 6:50:58 PM (11 years ago)

Author:

jamesr@google.com

Message:

[chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
​https://bugs.webkit.org/show_bug.cgi?id=109403

Reviewed by Adam Barth.

Source/Platform:

webkit_unit_tests that need compositing support need only a simple WebLayerTreeView implementation, not the full
thing.

• chromium/public/WebCompositorSupport.h:

(WebCompositorSupport):
(WebKit::WebCompositorSupport::createLayerTreeView):

• chromium/public/WebUnitTestSupport.h:

(WebKit):
(WebUnitTestSupport):
(WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):

Source/WebKit/chromium:

• tests/GraphicsLayerChromiumTest.cpp:

(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):

• tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::FakeWebViewClient::initializeLayerTreeView):

Location:

trunk/Source

Files:

• Platform/ChangeLog (modified) (1 diff)
• Platform/chromium/public/WebCompositorSupport.h (modified) (2 diffs)
• Platform/chromium/public/WebUnitTestSupport.h (modified) (2 diffs)
• WebKit/chromium/ChangeLog (modified) (1 diff)
• WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp (modified) (2 diffs)
• WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp (modified) (1 diff)

trunk/Source/Platform/ChangeLog

@@ +1 @@
+2013-02-11  James Robinson  <jamesr@chromium.org>
+
+        [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
+        https://bugs.webkit.org/show_bug.cgi?id=109403
+
+        Reviewed by Adam Barth.
+
+        webkit_unit_tests that need compositing support need only a simple WebLayerTreeView implementation, not the full
+        thing.
+
+        * chromium/public/WebCompositorSupport.h:
+        (WebCompositorSupport):
+        (WebKit::WebCompositorSupport::createLayerTreeView):
+        * chromium/public/WebUnitTestSupport.h:
+        (WebKit):
+        (WebUnitTestSupport):
+        (WebKit::WebUnitTestSupport::createLayerTreeViewForTesting):
+
 2013-02-10  Florin Malita  <fmalita@chromium.org>
 

trunk/Source/Platform/chromium/public/WebCompositorSupport.h

@@ -70 +70 @@
     virtual void shutdown() { }
 
-    // May return 0 if initialization fails.
-    virtual WebLayerTreeView* createLayerTreeView(WebLayerTreeViewClient*, const WebLayer& root, const WebLayerTreeView::Settings&) { return 0; }
-
     // Creates an output surface for the compositor backed by a 3d context.
     virtual WebCompositorOutputSurface* createOutputSurfaceFor3D(WebKit::WebGraphicsContext3D*) { return 0; }
@@ -108 +105 @@
     virtual WebTransformOperations* createTransformOperations() { return 0; }
 
+
+    // Testing ------------------------------------------------------
+
+    // DEPRECATED
+    // May return 0 if initialization fails.
+    virtual WebLayerTreeView* createLayerTreeView(WebLayerTreeViewClient*, const WebLayer& root, const WebLayerTreeView::Settings&) { return 0; }
+
 protected:
     virtual ~WebCompositorSupport() { }

trunk/Source/Platform/chromium/public/WebUnitTestSupport.h

@@ -32 +32 @@
 namespace WebKit {
 
+class WebLayerTreeView;
 class WebURL;
 class WebURLResponse;
@@ -53 +54 @@
     // Returns the root directory of the WebKit code.
     virtual WebString webKitRootDir() { return WebString(); }
+
+    // Constructs a WebLayerTreeView set up with reasonable defaults for
+    // testing. A LayerTreeTypeUnitTest view can initialize and perform most
+    // operations, but is not capable of rendering pixels. A
+    // LayerTreeTypeLayoutTest view can render.
+
+#define HAVE_CREATELAYERTREEVIEWFORTESTING 1
+    enum TestViewType {
+        TestViewTypeUnitTest,
+        TestViewTypeLayoutTest
+    };
+    virtual WebLayerTreeView* createLayerTreeViewForTesting(TestViewType type) { return 0; }
 };
 

trunk/Source/WebKit/chromium/ChangeLog

@@ +1 @@
+2013-02-11  James Robinson  <jamesr@chromium.org>
+
+        [chromium] Add WebUnitTestSupport::createLayerTreeViewForTesting for webkit_unit_tests
+        https://bugs.webkit.org/show_bug.cgi?id=109403
+
+        Reviewed by Adam Barth.
+
+        * tests/GraphicsLayerChromiumTest.cpp:
+        (WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
+        * tests/ScrollingCoordinatorChromiumTest.cpp:
+        (WebKit::FakeWebViewClient::initializeLayerTreeView):
+
 2013-02-11  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebKit/chromium/tests/GraphicsLayerChromiumTest.cpp

@@ -36 +36 @@
 #include <gtest/gtest.h>
 #include <public/Platform.h>
-#include <public/WebCompositorSupport.h>
 #include <public/WebFloatAnimationCurve.h>
 #include <public/WebGraphicsContext3D.h>
 #include <public/WebLayerTreeView.h>
 #include <public/WebTransformationMatrix.h>
+#include <public/WebUnitTestSupport.h>
 #include <wtf/PassOwnPtr.h>
 
@@ -63 +63 @@
         m_graphicsLayer = adoptPtr(new GraphicsLayerChromium(&m_client));
         m_platformLayer = m_graphicsLayer->platformLayer();
-        m_layerTreeView = adoptPtr(Platform::current()->compositorSupport()->createLayerTreeView(&m_layerTreeViewClient, *m_platformLayer, WebLayerTreeView::Settings()));
+        m_layerTreeView = adoptPtr(Platform::current()->unitTestSupport()->createLayerTreeViewForTesting(WebUnitTestSupport::TestViewTypeUnitTest));
+        ASSERT_TRUE(m_layerTreeView);
+        m_layerTreeView->setRootLayer(*m_platformLayer);
         m_layerTreeView->setViewportSize(WebSize(1, 1), WebSize(1, 1));
     }

trunk/Source/WebKit/chromium/tests/ScrollingCoordinatorChromiumTest.cpp

@@ -60 +60 @@
     virtual void initializeLayerTreeView(WebLayerTreeViewClient* client, const WebLayer& rootLayer, const WebLayerTreeView::Settings& settings)
     {
-        m_layerTreeView = adoptPtr(Platform::current()->compositorSupport()->createLayerTreeView(client, rootLayer, settings));
+        m_layerTreeView = adoptPtr(Platform::current()->unitTestSupport()->createLayerTreeViewForTesting(WebUnitTestSupport::TestViewTypeUnitTest));
         ASSERT(m_layerTreeView);
+        m_layerTreeView->setRootLayer(rootLayer);
     }