Changeset 142572 in webkit
- Timestamp:
- Feb 11, 2013 8:24:54 PM (11 years ago)
- Location:
- trunk
- Files:
-
- 3 added
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r142559 r142572 1 2013-02-11 Keishi Hattori <keishi@webkit.org> 2 3 REGRESSION (r140778):Calendar Picker buttons are wrong when rtl 4 https://bugs.webkit.org/show_bug.cgi?id=109158 5 6 Reviewed by Kent Tamura. 7 8 * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.png: Added. 9 * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar-expected.png: 10 * platform/chromium/TestExpectations: 11 * platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar-expected.txt: Added. 12 * platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html: Added. 13 1 14 2013-02-11 Ryosuke Niwa <rniwa@webkit.org> 2 15 -
trunk/LayoutTests/platform/chromium/TestExpectations
r142510 r142572 4243 4243 webkit.org/b/109136 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required.html [ ImageOnlyFailure Pass Missing ] 4244 4244 webkit.org/b/109136 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html [ ImageOnlyFailure Pass Missing ] 4245 webkit.org/b/109158 platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html [ ImageOnlyFailure Pass Missing ] 4245 4246 4246 4247 # Rebaseline after currentPath -
trunk/Source/WebCore/ChangeLog
r142570 r142572 1 2013-02-11 Keishi Hattori <keishi@webkit.org> 2 3 REGRESSION (r140778):Calendar Picker buttons are wrong when rtl 4 https://bugs.webkit.org/show_bug.cgi?id=109158 5 6 Reviewed by Kent Tamura. 7 8 The calendar picker button's icon and position where wrong when rtl. 9 10 11 Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ar.html 12 13 * Resources/pagepopups/calendarPicker.css: 14 (.year-month-button-left .year-month-button): Use -webkit-margin-end so the margin is applide to the right side. 15 (.year-month-button-right .year-month-button): Use -webkit-margin-start so the margin is applide to the right side. 16 (.today-clear-area .today-button): Use -webkit-margin-end so the margin is applide to the right side. 17 * Resources/pagepopups/calendarPicker.js: 18 (YearMonthController.prototype._attachLeftButtonsTo): Flip icon image when rtl. 19 (YearMonthController.prototype._attachRightButtonsTo): Ditto. 20 1 21 2013-02-11 KwangYong Choi <ky0.choi@samsung.com> 2 22 -
trunk/Source/WebCore/Resources/pagepopups/calendarPicker.css
r142198 r142572 142 142 143 143 .year-month-button-left .year-month-button { 144 margin-right: 4px;144 -webkit-margin-end: 4px; 145 145 } 146 146 … … 150 150 151 151 .year-month-button-right .year-month-button { 152 margin-left: 4px;152 -webkit-margin-start: 4px; 153 153 } 154 154 … … 273 273 274 274 .today-clear-area .today-button { 275 margin-right: 8px;275 -webkit-margin-end: 8px; 276 276 } 277 277 -
trunk/Source/WebCore/Resources/pagepopups/calendarPicker.js
r142198 r142572 863 863 } 864 864 865 YearMonthController.LeftPointingTriangle = "<svg width='4' height='7'><polygon points='0,3.5 4,7 4,0' style='fill:#6e6e6e;' /></svg>"; 866 YearMonthController.LeftPointingDoubleTriangle = "<svg width='9' height='7'><polygon points='0,3.5 4,7 4,0' style='fill:#6e6e6e;' /><polygon points='5,3.5 9,7 9,0' style='fill:#6e6e6e;' /></svg>"; 867 YearMonthController.RightPointingTriangle = "<svg width='4' height='7'><polygon points='0,7 0,0, 4,3.5' style='fill:#6e6e6e;' /></svg>"; 868 YearMonthController.RightPointingDoubleTriangle = "<svg width='9' height='7'><polygon points='4,3.5 0,7 0,0' style='fill:#6e6e6e;' /><polygon points='9,3.5 5,7 5,0' style='fill:#6e6e6e;' /></svg>"; 869 865 870 /** 866 871 * @param {!Element} element … … 937 942 938 943 this._left2 = createElement("button", ClassNames.YearMonthButton); 939 this._left2.innerHTML = "<svg width='9' height='7'><polygon points='0,3.5 4,7 4,0' style='fill:#6e6e6e;' /><polygon points='5,3.5 9,7 9,0' style='fill:#6e6e6e;' /></svg>";944 this._left2.innerHTML = global.params.isLocaleRTL ? YearMonthController.RightPointingDoubleTriangle : YearMonthController.LeftPointingDoubleTriangle; 940 945 this._left2.addEventListener("click", this._handleButtonClick.bind(this), false); 941 946 container.appendChild(this._left2); 942 947 943 948 this._left1 = createElement("button", ClassNames.YearMonthButton); 944 this._left1.innerHTML = "<svg width='4' height='7'><polygon points='0,3.5 4,7 4,0' style='fill:#6e6e6e;' /></svg>";949 this._left1.innerHTML = global.params.isLocaleRTL ? YearMonthController.RightPointingTriangle : YearMonthController.LeftPointingTriangle; 945 950 this._left1.addEventListener("click", this._handleButtonClick.bind(this), false); 946 951 container.appendChild(this._left1); … … 954 959 parent.appendChild(container); 955 960 this._right1 = createElement("button", ClassNames.YearMonthButton); 956 this._right1.innerHTML = "<svg width='4' height='7'><polygon points='0,7 0,0, 4,3.5' style='fill:#6e6e6e;' /></svg>";961 this._right1.innerHTML = global.params.isLocaleRTL ? YearMonthController.LeftPointingTriangle : YearMonthController.RightPointingTriangle; 957 962 this._right1.addEventListener("click", this._handleButtonClick.bind(this), false); 958 963 container.appendChild(this._right1); 959 964 960 965 this._right2 = createElement("button", ClassNames.YearMonthButton); 961 this._right2.innerHTML = "<svg width='9' height='7'><polygon points='4,3.5 0,7 0,0' style='fill:#6e6e6e;' /><polygon points='9,3.5 5,7 5,0' style='fill:#6e6e6e;' /></svg>";966 this._right2.innerHTML = global.params.isLocaleRTL ? YearMonthController.LeftPointingDoubleTriangle : YearMonthController.RightPointingDoubleTriangle; 962 967 this._right2.addEventListener("click", this._handleButtonClick.bind(this), false); 963 968 container.appendChild(this._right2);
Note: See TracChangeset
for help on using the changeset viewer.