Changeset 142606 in webkit


Ignore:
Timestamp:
Feb 12, 2013 5:25:55 AM (11 years ago)
Author:
zandobersek@gmail.com
Message:

[GTK] Enable CSS image-set support in development builds
​https://bugs.webkit.org/show_bug.cgi?id=109475

Reviewed by Martin Robinson.

Source/WebCore:

No new tests - majority of the related tests now passes.

  • GNUmakefile.features.am.in: Add the feature define for the CSS image-set feature

with the define value defaulting to 0. The value gets overridden with 1 in development
builds, meaning the feature is enabled under that configuration.

Tools:

  • Scripts/webkitperl/FeatureList.pm: Add the configuration option for the feature.

Note that the Mac port also enables the feature but does so in Platform.h as the feature
is also enabled for the iOS port which can't at the moment be detected via webkitperl.

LayoutTests:

  • platform/gtk/TestExpectations: Reclassify two failures that now fail due to

cursor images not loading while the other expectations are removed as the tests
now pass.

  • platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt: Removed. The generic

expectation now matches the test output.

Location:
trunk
Files:
1 deleted
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r142605 r142606  
     12013-02-12  Zan Dobersek  <zdobersek@igalia.com>
     2
     3        [GTK] Enable CSS image-set support in development builds
     4        https://bugs.webkit.org/show_bug.cgi?id=109475
     5
     6        Reviewed by Martin Robinson.
     7
     8        * platform/gtk/TestExpectations: Reclassify two failures that now fail due to
     9        cursor images not loading while the other expectations are removed as the tests
     10        now pass.
     11        * platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt: Removed. The generic
     12        expectation now matches the test output.
     13
    1142013-02-12  Zan Dobersek  <zdobersek@igalia.com>
    215

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r142605 r142606  
    311311# CSS Filters is disabled
    312312webkit.org/b/99026 css3/filters [ Skip ]
    313 
    314 # CSS image-set support not yet enabled (needs ENABLE_CSS_IMAGE_SET).
    315 webkit.org/b/99027 fast/css/image-set-parsing.html [ Failure ]
    316 webkit.org/b/99027 fast/css/image-set-parsing-invalid.html [ Pass ]
    317 webkit.org/b/99027 fast/css/image-set-setting.html [ Failure ]
    318 webkit.org/b/99027 fast/css/cursor-parsing-image-set.html [ Failure ]
    319 webkit.org/b/99027 fast/events/mouse-cursor-image-set.html [ Timeout ]
    320 webkit.org/b/99027 cssom/cssvalue-comparison.html [ Failure ]
    321313
    322314# For now, Web Audio API is disabled
    … …  
    14711463webkit.org/b/109353 fast/flexbox/line-clamp-link-after-ellipsis.html [ Failure ]
    14721464
     1465webkit.org/b/109469 fast/css/cursor-parsing-image-set.html [ Failure ]
     1466webkit.org/b/109469 fast/events/mouse-cursor-image-set.html [ Timeout ]
     1467
    14731468#////////////////////////////////////////////////////////////////////////////////////////
    14741469# End of Tests failing

  • trunk/Source/WebCore/ChangeLog

    r142605 r142606  
     12013-02-12  Zan Dobersek  <zdobersek@igalia.com>
     2
     3        [GTK] Enable CSS image-set support in development builds
     4        https://bugs.webkit.org/show_bug.cgi?id=109475
     5
     6        Reviewed by Martin Robinson.
     7
     8        No new tests - majority of the related tests now passes.
     9
     10        * GNUmakefile.features.am.in: Add the feature define for the CSS image-set feature
     11        with the define value defaulting to 0. The value gets overridden with 1 in development
     12        builds, meaning the feature is enabled under that configuration.
     13
    1142013-02-12  Zan Dobersek  <zdobersek@igalia.com>
    215

  • trunk/Source/WebCore/GNUmakefile.features.am.in

    r142605 r142606  
    1616        ENABLE_CSS_IMAGE_ORIENTATION=0 \
    1717        ENABLE_CSS_IMAGE_RESOLUTION=0 \
     18        ENABLE_CSS_IMAGE_SET=0 \
    1819        ENABLE_CSS_REGIONS=0 \
    1920        ENABLE_CSS_SHADERS=0 \

  • trunk/Tools/ChangeLog

    r142605 r142606  
     12013-02-12  Zan Dobersek  <zdobersek@igalia.com>
     2
     3        [GTK] Enable CSS image-set support in development builds
     4        https://bugs.webkit.org/show_bug.cgi?id=109475
     5
     6        Reviewed by Martin Robinson.
     7
     8        * Scripts/webkitperl/FeatureList.pm: Add the configuration option for the feature.
     9        Note that the Mac port also enables the feature but does so in Platform.h as the feature
     10        is also enabled for the iOS port which can't at the moment be detected via webkitperl.
     11
    1122013-02-12  Zan Dobersek  <zdobersek@igalia.com>
    213

  • trunk/Tools/Scripts/webkitperl/FeatureList.pm

    r142605 r142606  
    5959    $cssImageOrientationSupport,
    6060    $cssImageResolutionSupport,
     61    $cssImageSetSupport,
    6162    $cssRegionsSupport,
    6263    $cssShadersSupport,
    … …  
    200201      define => "ENABLE_CSS_IMAGE_RESOLUTION", default => (isBlackBerry() || isGtk()), value => \$cssImageResolutionSupport },
    201202
     203    { option => "css-image-set", desc => "Toggle CSS image-set support",
     204      define => "ENABLE_CSS_IMAGE_SET", default => isGtk(), value => \$cssImageSetSupport },
     205
    202206    { option => "css-regions", desc => "Toggle CSS Regions support",
    203207      define => "ENABLE_CSS_REGIONS", default => 1, value => \$cssRegionsSupport },
Note: See TracChangeset for help on using the changeset viewer.