Changeset 142611 in webkit

Timestamp:

Feb 12, 2013 6:15:45 AM (11 years ago)

Author:

apavlov@chromium.org

Message:

Web Inspector: [SuggestBox] SuggestBox not hidden when prefix is empty and there is preceding input
​https://bugs.webkit.org/show_bug.cgi?id=109568

Reviewed by Vsevolod Vlasov.

The suggestbox would get hidden in the case of empty input, yet it should get hidden
in the case of empty user-entered prefix (which is a wider notion.)

• inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/TextPrompt.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-12  Alexander Pavlov  <apavlov@chromium.org>
+
+        Web Inspector: [SuggestBox] SuggestBox not hidden when prefix is empty and there is preceding input
+        https://bugs.webkit.org/show_bug.cgi?id=109568
+
+        Reviewed by Vsevolod Vlasov.
+
+        The suggestbox would get hidden in the case of empty input, yet it should get hidden
+        in the case of empty user-entered prefix (which is a wider notion.)
+
+        * inspector/front-end/TextPrompt.js:
+        (WebInspector.TextPrompt.prototype.complete):
+
 2013-02-12  Andrey Lushnikov  <lushnikov@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/TextPrompt.js

@@ -372 +372 @@
 
         var selectionRange = selection.getRangeAt(0);
-        var isEmptyInput = selectionRange.commonAncestorContainer === this._element; // this._element has no child Text nodes.
+        var wordPrefixRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset, this._completionStopCharacters, this._element, "backward");
+        var isEmptyInput = wordPrefixRange.collapsed;
 
         var shouldExit;
@@ -396 +397 @@
         }
 
-        var wordPrefixRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset, this._completionStopCharacters, this._element, "backward");
         this._waitingForCompletions = true;
         this._loadCompletions(this.proxyElement, wordPrefixRange, force, this._completionsReady.bind(this, selection, auto, wordPrefixRange, !!reverse));