Changeset 142629 in webkit

Timestamp:

Feb 12, 2013 8:45:26 AM (11 years ago)

Author:

ddkilzer@apple.com

Message:

BUILD FIX (r142576): WK1 build fails when ENABLE(DELETION_UI) is off
<​https://bugs.webkit.org/show_bug.cgi?id=109534>

Fixes the following build failure:

WebEditorClient.mm:243:23: error: out-of-line definition of 'shouldShowDeleteInterface' does not match any declaration in 'WebEditorClient'
bool WebEditorClient::shouldShowDeleteInterface(HTMLElement* element)

• WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::shouldShowDeleteInterface): Protect with
ENABLE(DELETION_UI) macro.

Location:

trunk/Source/WebKit/mac

Files:

• ChangeLog (modified) (1 diff)
• WebCoreSupport/WebEditorClient.mm (modified) (2 diffs)

trunk/Source/WebKit/mac/ChangeLog

@@ +1 @@
+2013-02-12  David Kilzer  <ddkilzer@apple.com>
+
+        BUILD FIX (r142576): WK1 build fails when ENABLE(DELETION_UI) is off
+        <https://bugs.webkit.org/show_bug.cgi?id=109534>
+
+        Fixes the following build failure:
+
+            WebEditorClient.mm:243:23: error: out-of-line definition of 'shouldShowDeleteInterface' does not match any declaration in 'WebEditorClient'
+            bool WebEditorClient::shouldShowDeleteInterface(HTMLElement* element)
+                                  ^~~~~~~~~~~~~~~~~~~~~~~~~
+
+        * WebCoreSupport/WebEditorClient.mm:
+        (WebEditorClient::shouldShowDeleteInterface): Protect with
+        ENABLE(DELETION_UI) macro.
+
 2013-02-11  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm

@@ -223 +223 @@
 }
 
+#if ENABLE(DELETION_UI)
 bool WebEditorClient::shouldShowDeleteInterface(HTMLElement* element)
 {
@@ -228 +229 @@
         shouldShowDeleteInterfaceForElement:kit(element)];
 }
+#endif
 
 bool WebEditorClient::smartInsertDeleteEnabled()