Changeset 142634 in webkit

Timestamp:

Feb 12, 2013 9:04:08 AM (11 years ago)

Author:

Martin Robinson

Message:

[GTK] Remove the enable-debug-feature configuration option
​https://bugs.webkit.org/show_bug.cgi?id=109539

Reviewed by Philippe Normand.

Remove the --enable-debug-feature option from configuration. It doesn't
do anything that --enable-debug doesn't.

• Source/autotools/PrintBuildConfiguration.m4: Remove references to --enable-debug-features.
• Source/autotools/ReadCommandLineArguments.m4: Ditto.
• Source/autotools/SetupAutoconfHeader.m4: Ditto.
• Source/autotools/SetupAutomake.m4: Ditto.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/autotools/PrintBuildConfiguration.m4 (modified) (1 diff)
• Source/autotools/ReadCommandLineArguments.m4 (modified) (1 diff)
• Source/autotools/SetupAutoconfHeader.m4 (modified) (3 diffs)
• Source/autotools/SetupAutomake.m4 (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2013-02-12  Martin Robinson  <mrobinson@igalia.com>
+
+        [GTK] Remove the enable-debug-feature configuration option
+        https://bugs.webkit.org/show_bug.cgi?id=109539
+
+        Reviewed by Philippe Normand.
+
+        Remove the --enable-debug-feature option from configuration. It doesn't
+        do anything that --enable-debug doesn't.
+
+        * Source/autotools/PrintBuildConfiguration.m4: Remove references to --enable-debug-features.
+        * Source/autotools/ReadCommandLineArguments.m4: Ditto.
+        * Source/autotools/SetupAutoconfHeader.m4: Ditto.
+        * Source/autotools/SetupAutomake.m4: Ditto.
+
 2013-02-12  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/autotools/PrintBuildConfiguration.m4

@@ -7 +7 @@
  Enable debugging (slow)                                  : $enable_debug
  Compile with debug symbols (slow)                        : $enable_debug_symbols
- Enable debug features (slow)                             : $enable_debug_features
  Enable GCC build optimization                            : $enable_optimizations
  Code coverage support                                    : $enable_coverage

trunk/Source/autotools/ReadCommandLineArguments.m4

@@ -215 +215 @@
 AC_MSG_RESULT([$enable_accelerated_compositing])
 
-AC_MSG_CHECKING([whether to enable debug features])
-AC_ARG_ENABLE(debug_features,
-    AC_HELP_STRING([--enable-debug-features], [enable debug features default=no, default=yes for debug builds]),
-    [],
-    [
-        if test "$enable_debug" = "yes"; then
-            enable_debug_features="yes";
-        else
-             enable_debug_features="no";
-         fi
-    ])
-AC_MSG_RESULT([$enable_debug_features])
-
 AC_MSG_CHECKING([whether to enable JIT compilation])
 AC_ARG_ENABLE(jit, AS_HELP_STRING([--enable-jit], [Enable JIT compilation (default: autodetect)]))

trunk/Source/autotools/SetupAutoconfHeader.m4

@@ -7 +7 @@
 AC_DEFINE_UNQUOTED(GETTEXT_PACKAGE,"$GETTEXT_PACKAGE", [The gettext catalog name])
 
-if test "$enable_debug_features" = "yes"; then
+if test "$enable_debug" = "yes"; then
     AC_DEFINE([GDK_PIXBUF_DISABLE_DEPRECATED], [1], [ ])
     AC_DEFINE([GDK_DISABLE_DEPRECATED], [1], [ ])
@@ -13 +13 @@
     AC_DEFINE([PANGO_DISABLE_DEPRECATED], [1], [ ])
 else
-    AC_DEFINE([NDEBUG], [1], [Define to disable debugging features])
+    AC_DEFINE([NDEBUG], [1], [Define to disable debugging])
 fi
 
@@ -69 +69 @@
 if test "$have_gstreamer" = "yes"; then
     AC_DEFINE([WTF_USE_GSTREAMER], [1], [ ])
-    if test "$enable_debug_features" = "yes"; then
+    if test "$enable_debug" = "yes"; then
         AC_DEFINE([GST_DISABLE_DEPRECATED], [1], [ ])
     fi

trunk/Source/autotools/SetupAutomake.m4

@@ -54 +54 @@
 
 # WebKit feature conditionals.
-AM_CONDITIONAL([ENABLE_DEBUG],[test "$enable_debug_features" = "yes"])
+AM_CONDITIONAL([ENABLE_DEBUG],[test "$enable_debug" = "yes"])
 AM_CONDITIONAL([ENABLE_WEBGL],[test "$enable_webgl" = "yes"])
 AM_CONDITIONAL([ENABLE_GAMEPAD],[test "$enable_gamepad" = "yes"])