Changeset 142645 in webkit

Timestamp:

Feb 12, 2013 11:13:56 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Background size width specified in viewport percentage units not working
​https://bugs.webkit.org/show_bug.cgi?id=109536

Patch by Uday Kiran <​udaykiran@motorola.com> on 2013-02-12
Reviewed by Antti Koivisto.

Source/WebCore:

Corrected the check for viewport percentage unit while calculating
background image width.

Test: fast/backgrounds/size/backgroundSize-viewportPercentage-width.html

• rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):

LayoutTests:

Added a test for background image width specified in viewport percentage unit.

• fast/backgrounds/size/backgroundSize-viewportPercentage-width-expected.html: Added.
• fast/backgrounds/size/backgroundSize-viewportPercentage-width.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/backgrounds/size/backgroundSize-viewportPercentage-width-expected.html (added)
• LayoutTests/fast/backgrounds/size/backgroundSize-viewportPercentage-width.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBoxModelObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-12  Uday Kiran  <udaykiran@motorola.com>
+
+        Background size width specified in viewport percentage units not working
+        https://bugs.webkit.org/show_bug.cgi?id=109536
+
+        Reviewed by Antti Koivisto.
+
+        Added a test for background image width specified in viewport percentage unit.
+
+        * fast/backgrounds/size/backgroundSize-viewportPercentage-width-expected.html: Added.
+        * fast/backgrounds/size/backgroundSize-viewportPercentage-width.html: Added.
+
 2013-02-12  Pablo Flouret  <pablof@motorola.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-12  Uday Kiran  <udaykiran@motorola.com>
+
+        Background size width specified in viewport percentage units not working
+        https://bugs.webkit.org/show_bug.cgi?id=109536
+
+        Reviewed by Antti Koivisto.
+
+        Corrected the check for viewport percentage unit while calculating
+        background image width.
+
+        Test: fast/backgrounds/size/backgroundSize-viewportPercentage-width.html
+
+        * rendering/RenderBoxModelObject.cpp:
+        (WebCore::RenderBoxModelObject::calculateFillTileSize):
+
 2013-02-12  Abhishek Arya  <inferno@chromium.org>
 

trunk/Source/WebCore/rendering/RenderBoxModelObject.cpp

@@ -1023 +1023 @@
             if (layerWidth.isFixed())
                 tileSize.setWidth(layerWidth.value());
-            else if (layerWidth.isPercent() || layerHeight.isViewportPercentage())
+            else if (layerWidth.isPercent() || layerWidth.isViewportPercentage())
                 tileSize.setWidth(valueForLength(layerWidth, positioningAreaSize.width(), renderView));