Changeset 142705 in webkit

Timestamp:

Feb 12, 2013 6:39:22 PM (11 years ago)

Author:

rniwa@webkit.org

Message:

Turn avoidIntersectionWithNode into Editor member functions to encapsulate delete button controller
​https://bugs.webkit.org/show_bug.cgi?id=109549

Reviewed by Tony Chang.

Renamed avoidIntersectionWithNode to Editor::avoidIntersectionWithDeleteButtonController and added trivial
implementations when delete button controllers are disabled (ENABLE_DELETION_UI is 0).

• editing/DeleteButtonController.cpp:
• editing/EditCommand.cpp:

(WebCore::EditCommand::EditCommand):

• editing/Editor.cpp:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController): Moved from htmlediting.cpp and renamed.
The version that takes VisibleSelection has been updated to use updatePositionForNodeRemoval to share
mode code with that function.
(WebCore::Editor::rangeForPoint):

• editing/Editor.h:

(WebCore::Editor::avoidIntersectionWithDeleteButtonController): Added; trivial implementations.

• editing/htmlediting.cpp:
• editing/htmlediting.h:
• editing/markup.cpp:

(WebCore::createMarkupInternal): Extracted from createMarkup.
(WebCore::createMarkup):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/EditCommand.cpp (modified) (2 diffs)
• editing/Editor.cpp (modified) (2 diffs)
• editing/Editor.h (modified) (1 diff)
• editing/htmlediting.cpp (modified) (1 diff)
• editing/htmlediting.h (modified) (2 diffs)
• editing/markup.cpp (modified) (4 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-12  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Turn avoidIntersectionWithNode into Editor member functions to encapsulate delete button controller
+        https://bugs.webkit.org/show_bug.cgi?id=109549
+
+        Reviewed by Tony Chang.
+
+        Renamed avoidIntersectionWithNode to Editor::avoidIntersectionWithDeleteButtonController and added trivial
+        implementations when delete button controllers are disabled (ENABLE_DELETION_UI is 0).
+
+        * editing/DeleteButtonController.cpp:
+        * editing/EditCommand.cpp:
+        (WebCore::EditCommand::EditCommand):
+        * editing/Editor.cpp:
+        (WebCore::Editor::avoidIntersectionWithDeleteButtonController): Moved from htmlediting.cpp and renamed.
+        The version that takes VisibleSelection has been updated to use updatePositionForNodeRemoval to share
+        mode code with that function.
+        (WebCore::Editor::rangeForPoint):
+        * editing/Editor.h:
+        (WebCore::Editor::avoidIntersectionWithDeleteButtonController): Added; trivial implementations.
+        * editing/htmlediting.cpp:
+        * editing/htmlediting.h:
+        * editing/markup.cpp:
+        (WebCore::createMarkupInternal): Extracted from createMarkup.
+        (WebCore::createMarkup):
+
 2013-02-12  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebCore/editing/EditCommand.cpp

@@ -28 +28 @@
 
 #include "CompositeEditCommand.h"
-#if ENABLE(DELETION_UI)
-#include "DeleteButtonController.h"
-#endif
 #include "Document.h"
 #include "Editor.h"
@@ -49 +46 @@
     ASSERT(m_document);
     ASSERT(m_document->frame());
-#if ENABLE(DELETION_UI)
-    setStartingSelection(avoidIntersectionWithNode(m_document->frame()->selection()->selection(), m_document->frame()->editor()->deleteButtonController()->containerElement()));
-#else
-    setStartingSelection(m_document->frame()->selection()->selection());
-#endif
+    setStartingSelection(m_document->frame()->editor()->avoidIntersectionWithDeleteButtonController(m_document->frame()->selection()->selection()));
     setEndingSelection(m_startingSelection);
 }

trunk/Source/WebCore/editing/Editor.cpp

@@ -105 +105 @@
 using namespace Unicode;
 
+#if ENABLE(DELETION_UI)
+PassRefPtr<Range> Editor::avoidIntersectionWithDeleteButtonController(const Range* range) const
+{
+    DeleteButtonController* controller = deleteButtonController();
+    if (!range || !controller)
+        return 0;
+
+    Document* document = range->ownerDocument();
+
+    Node* startContainer = range->startContainer();
+    int startOffset = range->startOffset();
+    Node* endContainer = range->endContainer();
+    int endOffset = range->endOffset();
+
+    if (!startContainer)
+        return 0;
+
+    ASSERT(endContainer);
+
+    Element* element = controller->containerElement();
+    if (startContainer == element || startContainer->isDescendantOf(element)) {
+        ASSERT(element->parentNode());
+        startContainer = element->parentNode();
+        startOffset = element->nodeIndex();
+    }
+    if (endContainer == element || endContainer->isDescendantOf(element)) {
+        ASSERT(element->parentNode());
+        endContainer = element->parentNode();
+        endOffset = element->nodeIndex();
+    }
+
+    return Range::create(document, startContainer, startOffset, endContainer, endOffset);
+}
+
+VisibleSelection Editor::avoidIntersectionWithDeleteButtonController(const VisibleSelection& selection) const
+{
+    DeleteButtonController* controller = deleteButtonController();
+    if (selection.isNone() || !controller)
+        return selection;
+
+    Element* element = controller->containerElement();
+    if (!element)
+        return selection;
+    VisibleSelection updatedSelection = selection;
+
+    Position updatedBase = selection.base();
+    updatePositionForNodeRemoval(updatedBase, element);
+    if (updatedBase != selection.base())
+        updatedSelection.setBase(updatedBase);
+
+    Position updatedExtent = selection.base();
+    updatePositionForNodeRemoval(updatedExtent, element);
+    if (updatedExtent != selection.extent())
+        updatedSelection.setExtent(updatedExtent);
+
+    return updatedSelection;
+}
+#endif
+
 // When an event handler has moved the selection outside of a text control
 // we should use the target control's selection for this editing operation.
@@ -2388 +2447 @@
     IntPoint framePoint = frameView->windowToContents(windowPoint);
     VisibleSelection selection(frame->visiblePositionForPoint(framePoint));
-#if ENABLE(DELETION_UI)
-    return avoidIntersectionWithNode(selection.toNormalizedRange().get(), m_deleteButtonController->containerElement());
-#else
-    return selection.toNormalizedRange();
-#endif
+
+    return avoidIntersectionWithDeleteButtonController(selection.toNormalizedRange().get());
 }
 

trunk/Source/WebCore/editing/Editor.h

@@ -97 +97 @@
 
     Frame* frame() const { return m_frame; }
+
 #if ENABLE(DELETION_UI)
     DeleteButtonController* deleteButtonController() const { return m_deleteButtonController.get(); }
-#endif
+    PassRefPtr<Range> avoidIntersectionWithDeleteButtonController(const Range*) const;
+    VisibleSelection avoidIntersectionWithDeleteButtonController(const VisibleSelection&) const;
+#else
+    VisibleSelection avoidIntersectionWithDeleteButtonController(const VisibleSelection& selection) const { return selection; }
+#endif
+
     CompositeEditCommand* lastEditCommand() { return m_lastEditCommand.get(); }
 

trunk/Source/WebCore/editing/htmlediting.cpp

@@ -1183 +1183 @@
         || node->hasTagName(h5Tag);
 }
-
-#if ENABLE(DELETION_UI)
-PassRefPtr<Range> avoidIntersectionWithNode(const Range* range, Node* node)
-{
-    if (!range)
-        return 0;
-
-    Document* document = range->ownerDocument();
-
-    Node* startContainer = range->startContainer();
-    int startOffset = range->startOffset();
-    Node* endContainer = range->endContainer();
-    int endOffset = range->endOffset();
-
-    if (!startContainer)
-        return 0;
-
-    ASSERT(endContainer);
-
-    if (startContainer == node || startContainer->isDescendantOf(node)) {
-        ASSERT(node->parentNode());
-        startContainer = node->parentNode();
-        startOffset = node->nodeIndex();
-    }
-    if (endContainer == node || endContainer->isDescendantOf(node)) {
-        ASSERT(node->parentNode());
-        endContainer = node->parentNode();
-        endOffset = node->nodeIndex();
-    }
-
-    return Range::create(document, startContainer, startOffset, endContainer, endOffset);
-}
-
-VisibleSelection avoidIntersectionWithNode(const VisibleSelection& selection, Node* node)
-{
-    if (selection.isNone())
-        return VisibleSelection(selection);
-
-    VisibleSelection updatedSelection(selection);
-    Node* base = selection.base().deprecatedNode();
-    Node* extent = selection.extent().deprecatedNode();
-    ASSERT(base);
-    ASSERT(extent);
-
-    if (base == node || base->isDescendantOf(node)) {
-        ASSERT(node->parentNode());
-        updatedSelection.setBase(positionInParentBeforeNode(node));
-    }
-
-    if (extent == node || extent->isDescendantOf(node)) {
-        ASSERT(node->parentNode());
-        updatedSelection.setExtent(positionInParentBeforeNode(node));
-    }
-
-    return updatedSelection;
-}
-#endif
     
 Position adjustedSelectionStartForStyleComputation(const VisibleSelection& selection)

trunk/Source/WebCore/editing/htmlediting.h

@@ -193 +193 @@
 PassRefPtr<Range> createRange(PassRefPtr<Document>, const VisiblePosition& start, const VisiblePosition& end, ExceptionCode&);
 PassRefPtr<Range> extendRangeToWrappingNodes(PassRefPtr<Range> rangeToExtend, const Range* maximumRange, const Node* rootNode);
-#if ENABLE(DELETION_UI)
-PassRefPtr<Range> avoidIntersectionWithNode(const Range*, Node*);
-#endif
 
 // -------------------------------------------------------------------------
@@ -238 +235 @@
 
 // Functions returning VisibleSelection
-#if ENABLE(DELETION_UI)
-VisibleSelection avoidIntersectionWithNode(const VisibleSelection&, Node*);
-#endif
 VisibleSelection selectionForParagraphIteration(const VisibleSelection&);
 

trunk/Source/WebCore/editing/markup.cpp

@@ -545 +545 @@
 // FIXME: Shouldn't we omit style info when annotate == DoNotAnnotateForInterchange? 
 // FIXME: At least, annotation and style info should probably not be included in range.markupString()
-String createMarkup(const Range* range, Vector<Node*>* nodes, EAnnotateForInterchange shouldAnnotate, bool convertBlocksToInlines, EAbsoluteURLs shouldResolveURLs)
-{
+static String createMarkupInternal(Document* document, const Range* range, const Range* updatedRange, Vector<Node*>* nodes,
+    EAnnotateForInterchange shouldAnnotate, bool convertBlocksToInlines, EAbsoluteURLs shouldResolveURLs)
+{
+    ASSERT(document);
+    ASSERT(range);
+    ASSERT(updatedRange);
     DEFINE_STATIC_LOCAL(const String, interchangeNewlineString, (ASCIILiteral("<br class=\"" AppleInterchangeNewline "\">")));
-
-    if (!range)
-        return "";
-
-    Document* document = range->ownerDocument();
-    if (!document)
-        return "";
-
-    // Disable the delete button so it's elements are not serialized into the markup,
-    // but make sure neither endpoint is inside the delete user interface.
-    RefPtr<Range> updatedRange;
-#if ENABLE(DELETION_UI)
-    Frame* frame = document->frame();
-    DeleteButtonController* deleteButton = frame ? frame->editor()->deleteButtonController() : 0;
-    updatedRange = avoidIntersectionWithNode(range, deleteButton ? deleteButton->containerElement() : 0);
-    if (!updatedRange)
-        return "";
-    if (deleteButton)
-        deleteButton->disable();
-#else
-    updatedRange = Range::create(range->ownerDocument(), range->startContainer(), range->startOffset(), range->endContainer(), range->endOffset());
-#endif
 
     bool collapsed = updatedRange->collapsed(ASSERT_NO_EXCEPTION);
     if (collapsed)
-        return "";
+        return emptyString();
     Node* commonAncestor = updatedRange->commonAncestorContainer(ASSERT_NO_EXCEPTION);
     if (!commonAncestor)
-        return "";
+        return emptyString();
 
     document->updateLayoutIgnorePendingStylesheets();
@@ -585 +567 @@
     if (body && areRangesEqual(VisibleSelection::selectionFromContentsOfNode(body).toNormalizedRange().get(), range))
         fullySelectedRoot = body;
-    Node* specialCommonAncestor = highestAncestorToWrapMarkup(updatedRange.get(), shouldAnnotate);
-    StyledMarkupAccumulator accumulator(nodes, shouldResolveURLs, shouldAnnotate, updatedRange.get(), specialCommonAncestor);
+    Node* specialCommonAncestor = highestAncestorToWrapMarkup(updatedRange, shouldAnnotate);
+    StyledMarkupAccumulator accumulator(nodes, shouldResolveURLs, shouldAnnotate, updatedRange, specialCommonAncestor);
     Node* pastEnd = updatedRange->pastLastNode();
 
@@ -593 +575 @@
     VisiblePosition visibleEnd(updatedRange->endPosition(), VP_DEFAULT_AFFINITY);
     if (shouldAnnotate == AnnotateForInterchange && needInterchangeNewlineAfter(visibleStart)) {
-        if (visibleStart == visibleEnd.previous()) {
-#if ENABLE(DELETION_UI)
-            if (deleteButton)
-                deleteButton->enable();
-#endif
+        if (visibleStart == visibleEnd.previous())
             return interchangeNewlineString;
-        }
 
         accumulator.appendString(interchangeNewlineString);
         startNode = visibleStart.next().deepEquivalent().deprecatedNode();
 
-        if (pastEnd && Range::compareBoundaryPoints(startNode, 0, pastEnd, 0, ASSERT_NO_EXCEPTION) >= 0) {
-#if ENABLE(DELETION_UI)
-            if (deleteButton)
-                deleteButton->enable();
-#endif
+        if (pastEnd && Range::compareBoundaryPoints(startNode, 0, pastEnd, 0, ASSERT_NO_EXCEPTION) >= 0)
             return interchangeNewlineString;
-        }
     }
 
@@ -656 +628 @@
         accumulator.appendString(interchangeNewlineString);
 
+    return accumulator.takeResults();
+}
+
+String createMarkup(const Range* range, Vector<Node*>* nodes, EAnnotateForInterchange shouldAnnotate, bool convertBlocksToInlines, EAbsoluteURLs shouldResolveURLs)
+{
+    if (!range)
+        return emptyString();
+
+    Document* document = range->ownerDocument();
+    if (!document)
+        return emptyString();
+
+    // Disable the delete button so it's elements are not serialized into the markup,
+    // but make sure neither endpoint is inside the delete user interface.
 #if ENABLE(DELETION_UI)
-    if (deleteButton)
+    Frame* frame = document->frame();
+    if (DeleteButtonController* deleteButton = frame ? frame->editor()->deleteButtonController() : 0) {
+        RefPtr<Range> updatedRange = frame->editor()->avoidIntersectionWithDeleteButtonController(range);
+        if (!updatedRange)
+            return emptyString();
+
+        deleteButton->disable();
+
+        String result = createMarkupInternal(document, range, updatedRange.get(), nodes, shouldAnnotate, convertBlocksToInlines, shouldResolveURLs);
+
         deleteButton->enable();
+
+        return result;
+    }
 #endif
-    return accumulator.takeResults();
+    return createMarkupInternal(document, range, range, nodes, shouldAnnotate, convertBlocksToInlines, shouldResolveURLs);
 }