Changeset 142727 in webkit

Timestamp:

Feb 13, 2013 12:10:02 AM (11 years ago)

Author:

haraken@chromium.org

Message:

[V8] There is no XXXConstructor that requires a custom getter
​https://bugs.webkit.org/show_bug.cgi?id=109667

Reviewed by Adam Barth.

Currently '[Custom] attribute XXXConstructor xxx' generates
XXXAttrGetter(). However, there is no XXXConstructor with [Custom].
In addition, it does make no sense to generate XXXAttrGetter() for such cases.
We can remove the logic from CodeGeneratorV8.pm.

• bindings/scripts/CodeGeneratorV8.pm:

(GenerateSingleBatchedAttribute):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/scripts/CodeGeneratorV8.pm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-13  Kentaro Hara  <haraken@chromium.org>
+
+        [V8] There is no XXXConstructor that requires a custom getter
+        https://bugs.webkit.org/show_bug.cgi?id=109667
+
+        Reviewed by Adam Barth.
+
+        Currently '[Custom] attribute XXXConstructor xxx' generates
+        XXXAttrGetter(). However, there is no XXXConstructor with [Custom].
+        In addition, it does make no sense to generate XXXAttrGetter() for such cases.
+        We can remove the logic from CodeGeneratorV8.pm.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (GenerateSingleBatchedAttribute):
+
 2013-02-12  Hajime Morrita  <morrita@google.com>
 

trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

@@ -2297 +2297 @@
             AddToImplIncludes("V8${constructorType}.h", $attribute->signature->extendedAttributes->{"Conditional"});
         }
-        if ($customAccessor) {
-            $getter = "V8${customAccessor}AccessorGetter";
-        } else {
-            $data = "&V8${constructorType}::info";
-            $getter = "${interfaceName}V8Internal::${interfaceName}ConstructorGetter";
-        }
+        $data = "&V8${constructorType}::info";
+        $getter = "${interfaceName}V8Internal::${interfaceName}ConstructorGetter";
         $setter = "${interfaceName}V8Internal::${interfaceName}ReplaceableAttrSetter";
     } else {