Changeset 142728 in webkit


Ignore:
Timestamp:
Feb 13, 2013 12:24:56 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r142611.
http://trac.webkit.org/changeset/142611
https://bugs.webkit.org/show_bug.cgi?id=109668

Suggest box is not shown anymore when user types "window." in
inspector console. (Requested by vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-13

  • inspector/front-end/TextPrompt.js:

(WebInspector.TextPrompt.prototype.complete):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r142727 r142728  
     12013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r142611.
     4        http://trac.webkit.org/changeset/142611
     5        https://bugs.webkit.org/show_bug.cgi?id=109668
     6
     7        Suggest box is not shown anymore when user types "window." in
     8        inspector console. (Requested by vsevik on #webkit).
     9
     10        * inspector/front-end/TextPrompt.js:
     11        (WebInspector.TextPrompt.prototype.complete):
     12
    1132013-02-13  Kentaro Hara  <haraken@chromium.org>
    214
  • trunk/Source/WebCore/inspector/front-end/TextPrompt.js

    r142611 r142728  
    372372
    373373        var selectionRange = selection.getRangeAt(0);
    374         var wordPrefixRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset, this._completionStopCharacters, this._element, "backward");
    375         var isEmptyInput = wordPrefixRange.collapsed;
     374        var isEmptyInput = selectionRange.commonAncestorContainer === this._element; // this._element has no child Text nodes.
    376375
    377376        var shouldExit;
     
    397396        }
    398397
     398        var wordPrefixRange = selectionRange.startContainer.rangeOfWord(selectionRange.startOffset, this._completionStopCharacters, this._element, "backward");
    399399        this._waitingForCompletions = true;
    400400        this._loadCompletions(this.proxyElement, wordPrefixRange, force, this._completionsReady.bind(this, selection, auto, wordPrefixRange, !!reverse));
Note: See TracChangeset for help on using the changeset viewer.