Changeset 142782 in webkit


Ignore:
Timestamp:
Feb 13, 2013 1:22:55 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

chromium: remove CompositorHUDFontAtlas
​https://bugs.webkit.org/show_bug.cgi?id=109328

Patch by Eberhard Graether <​egraether@google.com> on 2013-02-13
Reviewed by James Robinson.

After switching the HudLayer to use skia's font rendering the
CompositorHUDFontAtlas has become obsolete. This change removes
this class and the related WebLayerTreeView API.

Source/Platform:

  • chromium/public/WebLayerTreeViewClient.h:

(WebLayerTreeViewClient):

Source/WebCore:

No new tests.

  • WebCore.gypi:
  • platform/graphics/chromium/CompositorHUDFontAtlas.cpp: Removed.
  • platform/graphics/chromium/CompositorHUDFontAtlas.h: Removed.

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:
  • src/WebViewImpl.h:
Location:
trunk/Source
Files:
2 deleted
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/Platform/ChangeLog

    r142773 r142782  
     12013-02-13  Eberhard Graether  <egraether@google.com>
     2
     3        chromium: remove CompositorHUDFontAtlas
     4        https://bugs.webkit.org/show_bug.cgi?id=109328
     5
     6        Reviewed by James Robinson.
     7
     8        After switching the HudLayer to use skia's font rendering the
     9        CompositorHUDFontAtlas has become obsolete. This change removes
     10        this class and the related WebLayerTreeView API.
     11
     12        * chromium/public/WebLayerTreeViewClient.h:
     13        (WebLayerTreeViewClient):
     14
    1152013-02-13  Tommy Widenflycht  <tommyw@google.com>
    216

  • trunk/Source/Platform/chromium/public/WebLayerTreeViewClient.h

    r135929 r142782  
    9494    virtual void scheduleComposite() = 0;
    9595
    96     // Creates a font atlas to use for debug visualizations. The atlas is a bitmap
    97     // containing glyph data, a table of ASCII character values to a subrectangle
    98     // of the atlas representing the corresponding glyph, and the glyph height.
    99     virtual void createFontAtlas(SkBitmap&, WebRect asciiToRectTable[128], int& fontHeight) { }
    100 
    10196protected:
    10297    virtual ~WebLayerTreeViewClient() { }

  • trunk/Source/WebCore/ChangeLog

    r142775 r142782  
     12013-02-13  Eberhard Graether  <egraether@google.com>
     2
     3        chromium: remove CompositorHUDFontAtlas
     4        https://bugs.webkit.org/show_bug.cgi?id=109328
     5
     6        Reviewed by James Robinson.
     7
     8        After switching the HudLayer to use skia's font rendering the
     9        CompositorHUDFontAtlas has become obsolete. This change removes
     10        this class and the related WebLayerTreeView API.
     11
     12        No new tests.
     13
     14        * WebCore.gypi:
     15        * platform/graphics/chromium/CompositorHUDFontAtlas.cpp: Removed.
     16        * platform/graphics/chromium/CompositorHUDFontAtlas.h: Removed.
     17
    1182013-02-13  Dean Jackson  <dino@apple.com>
    219

  • trunk/Source/WebCore/WebCore.gypi

    r142765 r142782  
    38833883            'platform/graphics/chromium/Canvas2DLayerManager.cpp',
    38843884            'platform/graphics/chromium/Canvas2DLayerManager.h',
    3885             'platform/graphics/chromium/CompositorHUDFontAtlas.cpp',
    3886             'platform/graphics/chromium/CompositorHUDFontAtlas.h',
    38873885            'platform/graphics/chromium/CrossProcessFontLoading.h',
    38883886            'platform/graphics/chromium/CrossProcessFontLoading.mm',

  • trunk/Source/WebKit/chromium/ChangeLog

    r142767 r142782  
     12013-02-13  Eberhard Graether  <egraether@google.com>
     2
     3        chromium: remove CompositorHUDFontAtlas
     4        https://bugs.webkit.org/show_bug.cgi?id=109328
     5
     6        Reviewed by James Robinson.
     7
     8        After switching the HudLayer to use skia's font rendering the
     9        CompositorHUDFontAtlas has become obsolete. This change removes
     10        this class and the related WebLayerTreeView API.
     11
     12        * src/WebViewImpl.cpp:
     13        * src/WebViewImpl.h:
     14
    1152013-02-13  Sheriff Bot  <webkit.review.bot@gmail.com>
    216

  • trunk/Source/WebKit/chromium/src/WebViewImpl.cpp

    r142571 r142782  
    4242#include "ColorSpace.h"
    4343#include "CompositionUnderlineVectorBuilder.h"
    44 #include "CompositorHUDFontAtlas.h"
    4544#include "ContextFeaturesClientImpl.h"
    4645#include "ContextMenu.h"
    … …  
    42604259}
    42614260
    4262 void WebViewImpl::createFontAtlas(SkBitmap& bitmap, WebRect asciiToRectTable[128], int& fontHeight)
    4263 {
    4264     TRACE_EVENT0("webkit", "WebViewImpl::loadFontAtlas");
    4265     bitmap = WebCore::CompositorHUDFontAtlas::generateFontAtlas(asciiToRectTable, fontHeight);
    4266 }
    4267 
    42684261void WebViewImpl::updateLayerTreeViewport()
    42694262{

  • trunk/Source/WebKit/chromium/src/WebViewImpl.h

    r142144 r142782  
    329329    virtual void didCompleteSwapBuffers();
    330330    virtual void scheduleComposite();
    331     virtual void createFontAtlas(SkBitmap&, WebRect[128], int&);
    332331
    333332    // WebViewImpl
Note: See TracChangeset for help on using the changeset viewer.