Changeset 142793 in webkit
- Timestamp:
- Feb 13, 2013 1:55:24 PM (11 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r142788 r142793 1 2013-02-13 Levi Weintraub <leviw@chromium.org> 2 3 Bidi-Isolated inlines can cause subsequent content to not be rendered 4 https://bugs.webkit.org/show_bug.cgi?id=108137 5 6 Reviewed by Eric Seidel. 7 8 * fast/text/content-following-inline-isolate-with-collapsed-whitespace.html: Added. 9 * fast/text/content-following-inline-isolate-with-collapsed-whitespace-expected.txt: Added. 10 1 11 2013-02-13 Christian Biesinger <cbiesinger@chromium.org> 2 12 -
trunk/Source/WebCore/ChangeLog
r142791 r142793 1 2013-02-13 Levi Weintraub <leviw@chromium.org> 2 3 Bidi-Isolated inlines can cause subsequent content to not be rendered 4 https://bugs.webkit.org/show_bug.cgi?id=108137 5 6 Reviewed by Eric Seidel. 7 8 First step in fixing how inline isolates behave with collapsed spaces. 9 webkit.org/b/109624 tracks the overarching issue. 10 11 Test: fast/text/content-following-inline-isolate-with-collapsed-whitespace.html 12 13 * rendering/InlineIterator.h: 14 (WebCore::IsolateTracker::addFakeRunIfNecessary): If we enter an isolate while 15 ignoring spaces, ensure we leave it considering them again. This can result in 16 including spaces that should be ignored following the isolate on the line, but 17 failing to do so results in those contents not being rendered at all. 18 1 19 2013-02-13 Andreas Kling <akling@apple.com> 2 20 -
trunk/Source/WebCore/rendering/InlineIterator.h
r142152 r142793 490 490 // isolate, when we call createBidiRunsForLine it will stop at whichever comes first. 491 491 addPlaceholderRunForIsolatedInline(resolver, obj, pos); 492 // FIXME: Inline isolates don't work properly with collapsing whitespace, see webkit.org/b/109624 493 // For now, if we enter an isolate between midpoints, we increment our current midpoint or else 494 // we'll leave the isolate and ignore the content that follows. 495 MidpointState<InlineIterator>& midpointState = resolver.midpointState(); 496 if (midpointState.betweenMidpoints && midpointState.midpoints[midpointState.currentMidpoint].object() == obj) { 497 midpointState.betweenMidpoints = false; 498 ++midpointState.currentMidpoint; 499 } 492 500 } 493 501
Note: See TracChangeset
for help on using the changeset viewer.