Changeset 142994 in webkit


Ignore:
Timestamp:
Feb 15, 2013 6:55:52 AM (11 years ago)
Author:
vsevik@chromium.org
Message:

Web Inspector: Redo in text editor should always collapse selection to end.
​https://bugs.webkit.org/show_bug.cgi?id=109907

Reviewed by Pavel Feldman.

Source/WebCore:

  • inspector/front-end/TextEditorModel.js:

(WebInspector.TextEditorModel.endsWithBracketRegex.):

LayoutTests:

  • inspector/editor/text-editor-undo-redo-expected.txt:
Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r142993 r142994  
     12013-02-15  Vsevolod Vlasov  <vsevik@chromium.org>
     2
     3        Web Inspector: Redo in text editor should always collapse selection to end.
     4        https://bugs.webkit.org/show_bug.cgi?id=109907
     5
     6        Reviewed by Pavel Feldman.
     7
     8        * inspector/editor/text-editor-undo-redo-expected.txt:
     9
    1102013-02-15  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
    211

  • trunk/LayoutTests/inspector/editor/text-editor-undo-redo-expected.txt

    r142965 r142994  
    2020Text after redo:
    21211
    22 >       <2
     22        |2
    23233
    2424
    … …  
    6161function foo()
    6262{
    63     bar()>;<
     63    bar();|
    6464}
    6565
    … …  
    6868{
    6969    bar();
    70     baz()>;<
     70    baz();|
    7171}
    7272
    … …  
    7676    bar();
    7777    baz();
    78     foo()>;<
     78    foo();|
    7979}
    8080
    … …  
    123123    bar();
    124124    baz();
    125     foo()>;<
     125    foo();|
    126126}
    127127
    … …  
    130130{
    131131    bar();
    132 >    baz();
    133 <    foo();
     132    baz();
     133|    foo();
    134134}
    135135

  • trunk/Source/WebCore/ChangeLog

    r142989 r142994  
     12013-02-15  Vsevolod Vlasov  <vsevik@chromium.org>
     2
     3        Web Inspector: Redo in text editor should always collapse selection to end.
     4        https://bugs.webkit.org/show_bug.cgi?id=109907
     5
     6        Reviewed by Pavel Feldman.
     7
     8        * inspector/front-end/TextEditorModel.js:
     9        (WebInspector.TextEditorModel.endsWithBracketRegex.):
     10
    1112013-02-15  Dan Carney  <dcarney@google.com>
    212

  • trunk/Source/WebCore/inspector/front-end/TextEditorModel.js

    r142965 r142994  
    505505        delete this._inRedo;
    506506
    507         return range;
     507        return range ? range.collapseToEnd() : null;
    508508    },
    509509
Note: See TracChangeset for help on using the changeset viewer.