Changeset 143027 in webkit

Timestamp:

Feb 15, 2013 11:54:09 AM (11 years ago)

Author:

ggaren@apple.com

Message:

Merged the global function cache into the source code cache
​https://bugs.webkit.org/show_bug.cgi?id=108660

Reviewed by Sam Weinig.

Responding to review comments by Darin Adler.

../JavaScriptCore:

• runtime/CodeCache.h:

(JSC::SourceCodeKey::SourceCodeKey): Don't initialize m_name and m_flags
in the hash table deleted value because they're meaningless.

../WTF:

• wtf/HashTraits.h: Added a using directive to simplify client code.

Location:

trunk/Source

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/runtime/CodeCache.h (modified) (2 diffs)
• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/HashTraits.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-02-15  Geoffrey Garen  <ggaren@apple.com>
+
+        Merged the global function cache into the source code cache
+        https://bugs.webkit.org/show_bug.cgi?id=108660
+
+        Reviewed by Sam Weinig.
+
+        Responding to review comments by Darin Adler.
+
+        * runtime/CodeCache.h:
+        (JSC::SourceCodeKey::SourceCodeKey): Don't initialize m_name and m_flags
+        in the hash table deleted value because they're meaningless.
+
 2013-02-14  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/runtime/CodeCache.h

@@ -100 +100 @@
     SourceCodeKey(WTF::HashTableDeletedValueType)
         : m_sourceString(WTF::HashTableDeletedValue)
-        , m_name(WTF::HashTableDeletedValue)
-        , m_flags(0)
     {
     }
@@ -130 +128 @@
 };
 
-struct SourceCodeKeyHashTraits : WTF::SimpleClassHashTraits<SourceCodeKey> {
+struct SourceCodeKeyHashTraits : SimpleClassHashTraits<SourceCodeKey> {
     static const bool hasIsEmptyValueFunction = true;
     static bool isEmptyValue(const SourceCodeKey& sourceCodeKey) { return sourceCodeKey.isNull(); }

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2013-02-15  Geoffrey Garen  <ggaren@apple.com>
+
+        Merged the global function cache into the source code cache
+        https://bugs.webkit.org/show_bug.cgi?id=108660
+
+        Reviewed by Sam Weinig.
+
+        Responding to review comments by Darin Adler.
+
+        * wtf/HashTraits.h: Added a using directive to simplify client code.
+
 2013-02-14  Dan Bernstein  <mitz@apple.com>
 

trunk/Source/WTF/wtf/HashTraits.h

@@ -244 +244 @@
 using WTF::PairHashTraits;
 using WTF::NullableHashTraits;
+using WTF::SimpleClassHashTraits;
 
 #endif // WTF_HashTraits_h