Changeset 143233 in webkit

Timestamp:

Feb 18, 2013 9:19:31 AM (11 years ago)

Author:

Christophe Dumez

Message:

[Soup] Superfluous HashMap check in SocketStreamHandleSoup::getHandleFromId()
​https://bugs.webkit.org/show_bug.cgi?id=110107

Reviewed by Martin Robinson.

Remove Superfluous HashMap::contains() call in SocketStreamHandleSoup::getHandleFromId()
as HashMap::get() will already return 0 in this case anyway.

No new tests, no behavior change.

• platform/network/soup/SocketStreamHandleSoup.cpp:

(WebCore):
(WebCore::getHandleFromId):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/SocketStreamHandleSoup.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
+
+        [Soup] Superfluous HashMap check in SocketStreamHandleSoup::getHandleFromId()
+        https://bugs.webkit.org/show_bug.cgi?id=110107
+
+        Reviewed by Martin Robinson.
+
+        Remove Superfluous HashMap::contains() call in SocketStreamHandleSoup::getHandleFromId()
+        as HashMap::get() will already return 0 in this case anyway.
+
+        No new tests, no behavior change.
+
+        * platform/network/soup/SocketStreamHandleSoup.cpp:
+        (WebCore):
+        (WebCore::getHandleFromId):
+
 2013-02-18  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp

@@ -61 +61 @@
 // situations this way.
 static HashMap<void*, SocketStreamHandle*> gActiveHandles;
+COMPILE_ASSERT(HashTraits<SocketStreamHandle*>::emptyValueIsZero, emptyMapValue_is_0);
+
 static SocketStreamHandle* getHandleFromId(void* id)
 {
-    if (!gActiveHandles.contains(id))
-        return 0;
     return gActiveHandles.get(id);
 }