Changeset 143267 in webkit
- Timestamp:
- Feb 18, 2013 3:07:00 PM (11 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 37 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r143266 r143267 1 2013-02-18 Stephen Chenney <schenney@chromium.org> 2 3 feFlood incorrectly applied color-interpolation-filters 4 https://bugs.webkit.org/show_bug.cgi?id=109985 5 6 Reviewed by Dirk Schulze. 7 8 New test for feFlood behavior when color-interpolation-filters is used. 9 10 Failing expectations for tests affected by this change. 11 12 * platform/chromium/TestExpectations: 13 * platform/mac/TestExpectations: 14 * platform/win/TestExpectations: 15 * svg/filters/feFlood-color-interpolation-expected.svg: Added. 16 * svg/filters/feFlood-color-interpolation.svg: Added. 17 1 18 2013-02-18 David Hyatt <hyatt@apple.com> 2 19 -
trunk/LayoutTests/platform/chromium/TestExpectations
r143266 r143267 4388 4388 webkit.org/b/9221 [ Mac ] fast/css/resize-corner-tracking-transformed.html [ Failure ] 4389 4389 4390 # Needs rebaseline after https://webkit.org/b/109985 4391 webkit.org/b/109985 svg/W3C-SVG-1.1/filters-offset-01-b.svg [ ImageOnlyFailure ] 4392 webkit.org/b/109985 svg/custom/visibility-override-filter.svg [ ImageOnlyFailure ] 4393 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html [ ImageOnlyFailure ] 4394 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html [ ImageOnlyFailure ] 4395 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html [ ImageOnlyFailure ] 4396 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html [ ImageOnlyFailure ] 4397 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html [ ImageOnlyFailure ] 4398 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html [ ImageOnlyFailure ] 4399 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html [ ImageOnlyFailure ] 4400 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html [ ImageOnlyFailure ] 4401 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html [ ImageOnlyFailure ] 4402 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html [ ImageOnlyFailure ] 4403 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html [ ImageOnlyFailure ] 4404 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html [ ImageOnlyFailure ] 4405 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html [ ImageOnlyFailure ] 4406 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html [ ImageOnlyFailure ] 4407 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr.html [ ImageOnlyFailure ] 4408 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr.html [ ImageOnlyFailure ] 4409 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html [ ImageOnlyFailure ] 4410 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop.html [ ImageOnlyFailure ] 4411 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop.html [ ImageOnlyFailure ] 4412 webkit.org/b/109985 svg/dynamic-updates/SVGFETileElement-dom-in-attr.html [ ImageOnlyFailure ] 4413 webkit.org/b/109985 svg/dynamic-updates/SVGFETileElement-svgdom-in-prop.html [ ImageOnlyFailure ] 4414 webkit.org/b/109985 svg/filters/big-sized-filter-2.svg [ ImageOnlyFailure ] 4415 webkit.org/b/109985 svg/filters/feImage-reference-svg-primitive.svg [ ImageOnlyFailure ] 4416 webkit.org/b/109985 svg/filters/filter-on-tspan.svg [ ImageOnlyFailure ] 4417 webkit.org/b/109985 svg/filters/filterRes1.svg [ ImageOnlyFailure ] 4418 webkit.org/b/109985 svg/filters/filterRes3.svg [ ImageOnlyFailure ] 4419 webkit.org/b/109985 svg/filters/parent-children-with-same-filter.svg [ ImageOnlyFailure ] 4420 webkit.org/b/109985 svg/filters/shadow-on-filter.svg [ ImageOnlyFailure ] 4421 webkit.org/b/109985 svg/filters/shadow-on-rect-with-filter.svg [ ImageOnlyFailure ] 4422 4390 4423 # The test is flaky on chromium-ews 4391 4424 webkit.org/b/107953 inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html [ Pass Failure ] -
trunk/LayoutTests/platform/mac/TestExpectations
r143256 r143267 1414 1414 webkit.org/b/108257 [ Debug ] compositing/overflow/automatically-opt-into-composited-scrolling.html [ Crash ] 1415 1415 1416 # Needs rebaseline after https://webkit.org/b/109985 1417 webkit.org/b/109985 svg/W3C-SVG-1.1/filters-offset-01-b.svg [ ImageOnlyFailure ] 1418 webkit.org/b/109985 svg/custom/visibility-override-filter.svg [ ImageOnlyFailure ] 1419 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html [ ImageOnlyFailure ] 1420 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html [ ImageOnlyFailure ] 1421 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html [ ImageOnlyFailure ] 1422 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html [ ImageOnlyFailure ] 1423 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html [ ImageOnlyFailure ] 1424 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html [ ImageOnlyFailure ] 1425 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html [ ImageOnlyFailure ] 1426 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html [ ImageOnlyFailure ] 1427 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html [ ImageOnlyFailure ] 1428 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html [ ImageOnlyFailure ] 1429 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html [ ImageOnlyFailure ] 1430 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html [ ImageOnlyFailure ] 1431 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html [ ImageOnlyFailure ] 1432 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html [ ImageOnlyFailure ] 1433 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr.html [ ImageOnlyFailure ] 1434 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr.html [ ImageOnlyFailure ] 1435 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html [ ImageOnlyFailure ] 1436 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop.html [ ImageOnlyFailure ] 1437 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop.html [ ImageOnlyFailure ] 1438 webkit.org/b/109985 svg/dynamic-updates/SVGFETileElement-dom-in-attr.html [ ImageOnlyFailure ] 1439 webkit.org/b/109985 svg/dynamic-updates/SVGFETileElement-svgdom-in-prop.html [ ImageOnlyFailure ] 1440 webkit.org/b/109985 svg/filters/big-sized-filter-2.svg [ ImageOnlyFailure ] 1441 webkit.org/b/109985 svg/filters/feImage-reference-svg-primitive.svg [ ImageOnlyFailure ] 1442 webkit.org/b/109985 svg/filters/filter-on-tspan.svg [ ImageOnlyFailure ] 1443 webkit.org/b/109985 svg/filters/filterRes1.svg [ ImageOnlyFailure ] 1444 webkit.org/b/109985 svg/filters/filterRes3.svg [ ImageOnlyFailure ] 1445 webkit.org/b/109985 svg/filters/parent-children-with-same-filter.svg [ ImageOnlyFailure ] 1446 webkit.org/b/109985 svg/filters/shadow-on-filter.svg [ ImageOnlyFailure ] 1447 webkit.org/b/109985 svg/filters/shadow-on-rect-with-filter.svg [ ImageOnlyFailure ] 1448 1416 1449 1417 1450 # Rebaseline required after https://webkit.org/b/95772 -
trunk/LayoutTests/platform/win/TestExpectations
r143000 r143267 2631 2631 webkit.org/b/108370 editing/spelling/spelling-with-whitespace-selection.html [ Skip ] 2632 2632 2633 # Needs rebaseline after https://webkit.org/b/109985 2634 webkit.org/b/109985 svg/W3C-SVG-1.1/filters-offset-01-b.svg [ ImageOnlyFailure ] 2635 webkit.org/b/109985 svg/custom/visibility-override-filter.svg [ ImageOnlyFailure ] 2636 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-in-attr.html [ ImageOnlyFailure ] 2637 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-in2-attr.html [ ImageOnlyFailure ] 2638 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-k1-attr.html [ ImageOnlyFailure ] 2639 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-k2-attr.html [ ImageOnlyFailure ] 2640 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-k3-attr.html [ ImageOnlyFailure ] 2641 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-k4-attr.html [ ImageOnlyFailure ] 2642 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-dom-operator-attr.html [ ImageOnlyFailure ] 2643 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-in-prop.html [ ImageOnlyFailure ] 2644 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-in2-prop.html [ ImageOnlyFailure ] 2645 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-k1-prop.html [ ImageOnlyFailure ] 2646 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-k2-prop.html [ ImageOnlyFailure ] 2647 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-k3-prop.html [ ImageOnlyFailure ] 2648 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-k4-prop.html [ ImageOnlyFailure ] 2649 webkit.org/b/109985 svg/dynamic-updates/SVGFECompositeElement-svgdom-operator-prop.html [ ImageOnlyFailure ] 2650 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-dom-flood-color-attr.html [ ImageOnlyFailure ] 2651 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-dom-flood-opacity-attr.html [ ImageOnlyFailure ] 2652 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-inherit-flood-color.html [ ImageOnlyFailure ] 2653 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-color-prop.html [ ImageOnlyFailure ] 2654 webkit.org/b/109985 svg/dynamic-updates/SVGFEFloodElement-svgdom-flood-opacity-prop.html [ ImageOnlyFailure ] 2655 webkit.org/b/109985 svg/dynamic-updates/SVGFETileElement-dom-in-attr.html [ ImageOnlyFailure ] 2656 webkit.org/b/109985 svg/dynamic-updates/SVGFETileElement-svgdom-in-prop.html [ ImageOnlyFailure ] 2657 webkit.org/b/109985 svg/filters/big-sized-filter-2.svg [ ImageOnlyFailure ] 2658 webkit.org/b/109985 svg/filters/feImage-reference-svg-primitive.svg [ ImageOnlyFailure ] 2659 webkit.org/b/109985 svg/filters/filter-on-tspan.svg [ ImageOnlyFailure ] 2660 webkit.org/b/109985 svg/filters/filterRes1.svg [ ImageOnlyFailure ] 2661 webkit.org/b/109985 svg/filters/filterRes3.svg [ ImageOnlyFailure ] 2662 webkit.org/b/109985 svg/filters/parent-children-with-same-filter.svg [ ImageOnlyFailure ] 2663 webkit.org/b/109985 svg/filters/shadow-on-filter.svg [ ImageOnlyFailure ] 2664 webkit.org/b/109985 svg/filters/shadow-on-rect-with-filter.svg [ ImageOnlyFailure ] 2665 2633 2666 # Need rebaseline after https://bugs.webkit.org/show_bug.cgi?id=109775 2634 2667 webkit.org/b/109775 media/audio-controls-rendering.html [ Failure ] -
trunk/Source/WebCore/ChangeLog
r143264 r143267 1 2013-02-18 Stephen Chenney <schenney@chromium.org> 2 3 feFlood incorrectly applied color-interpolation-filters 4 https://bugs.webkit.org/show_bug.cgi?id=109985 5 6 Reviewed by Dirk Schulze. 7 8 The SVG spec defines the color-interpolation-filters property for all 9 filter effect elements in order to control cases where a color is 10 based on some arithmetic computation on other colors. For example, 11 when computing gradients or blending colors. feFlood simply fills a 12 region with the given color, and that given color is always defined to 13 be in sRGB space, so the feFlood result should always be sRGB. 14 15 The new behavior matches both Opera and Firefox. 16 17 Tests: svg/filters/feFlood-color-interpolation-expected.svg 18 svg/filters/feFlood-color-interpolation.svg 19 20 * platform/graphics/filters/FEFlood.cpp: 21 (WebCore::FEFlood::platformApplySoftware): Force the color mode to be 22 sRGB before returning. 23 1 24 2013-02-18 Mark Lam <mark.lam@apple.com> 2 25 -
trunk/Source/WebCore/platform/graphics/filters/FEFlood.cpp
r97853 r143267 79 79 Color color = colorWithOverrideAlpha(floodColor().rgb(), floodOpacity()); 80 80 resultImage->context()->fillRect(FloatRect(FloatPoint(), absolutePaintRect().size()), color, ColorSpaceDeviceRGB); 81 // feFlood does not perform color interpolation of any kind, so the result is always in ColorSpaceDeviceRGB 82 // regardless of the value of color-interpolation-filters. 83 setResultColorSpace(ColorSpaceDeviceRGB); 81 84 } 82 85
Note: See TracChangeset
for help on using the changeset viewer.