Changeset 143317 in webkit

Timestamp:

Feb 19, 2013 4:21:12 AM (11 years ago)

Author:

loislo@chromium.org

Message:

Web Inspector: Native Memory Instrumentation: show user provided name property of the heap snapshot node.
​https://bugs.webkit.org/show_bug.cgi?id=110124

Reviewed by Yury Semikhatsky.

Publish userProvidedName into grid node.

• inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):

• inspector/front-end/HeapSnapshotProxy.js:

(WebInspector.HeapSnapshotWorker):

• inspector/front-end/NativeHeapSnapshot.js:

(WebInspector.NativeHeapSnapshotNode.prototype.serialize):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/HeapSnapshotGridNodes.js (modified) (3 diffs)
• inspector/front-end/NativeHeapSnapshot.js (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-18  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: Native Memory Instrumentation: show user provided name property of the heap snapshot node.
+        https://bugs.webkit.org/show_bug.cgi?id=110124
+
+        Reviewed by Yury Semikhatsky.
+
+        Publish userProvidedName into grid node.
+
+        * inspector/front-end/HeapSnapshotGridNodes.js:
+        (WebInspector.HeapSnapshotGenericObjectNode):
+        (WebInspector.HeapSnapshotGenericObjectNode.prototype._createObjectCell):
+        (WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
+        * inspector/front-end/HeapSnapshotProxy.js:
+        (WebInspector.HeapSnapshotWorker):
+        * inspector/front-end/NativeHeapSnapshot.js:
+        (WebInspector.NativeHeapSnapshotNode.prototype.serialize):
+
 2013-02-19  Arpita Bahuguna  <a.bah@samsung.com>
 

trunk/Source/WebCore/inspector/front-end/HeapSnapshotGridNodes.js

@@ -351 +351 @@
         return;
     this._name = node.name;
+    this._displayName = node.displayName;
     this._type = node.type;
     this._distance = node.distance;
@@ -384 +385 @@
         div.className = "source-code event-properties";
         div.style.overflow = "visible";
+
         var data = this.data["object"];
         if (this._prefixObjectCell)
             this._prefixObjectCell(div, data);
+
         var valueSpan = document.createElement("span");
         valueSpan.className = "value console-formatted-" + data.valueStyle;
         valueSpan.textContent = data.value;
         div.appendChild(valueSpan);
+
+        if (this.data.displayName) {
+            var nameSpan = document.createElement("span");
+            nameSpan.className = "name console-formatted-name";
+            nameSpan.textContent = " " + this.data.displayName;
+            div.appendChild(nameSpan);
+        }
+
         var idSpan = document.createElement("span");
         idSpan.className = "console-formatted-id";
         idSpan.textContent = " @" + data["nodeId"];
         div.appendChild(idSpan);
+
         if (this._postfixObjectCell)
             this._postfixObjectCell(div, data);
+
         cell.appendChild(div);
         cell.addStyleClass("disclosure");
@@ -445 +458 @@
         data["object"] = { valueStyle: valueStyle, value: value, nodeId: this.snapshotNodeId };
 
+        data["displayName"] = this._displayName;
         data["distance"] =  this._distance;
         data["shallowSize"] = Number.withThousandsSeparator(this._shallowSize);

trunk/Source/WebCore/inspector/front-end/NativeHeapSnapshot.js

@@ -110 +110 @@
             id: this.id(),
             name: this.className(),
+            displayName: this.name(),
             distance: this.distance(),
             nodeIndex: this.nodeIndex,