Changeset 143326 in webkit

Timestamp:

Feb 19, 2013 6:43:09 AM (11 years ago)

Author:

Simon Hausmann

Message:

[Qt] Skip the build with a warning if certain tools cannot be found in the PATH
​https://bugs.webkit.org/show_bug.cgi?id=110215

Reviewed by Tor Arne Vestbø.

Check that gperf, python, ruby, perl, bison and flex are in the PATH before
continuing the build. Otherwise skip with an error message explaining which
programs are missing from the build.

• qmake/mkspecs/features/configure.prf:
• qmake/mkspecs/features/functions.prf:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• qmake/mkspecs/features/configure.prf (modified) (2 diffs)
• qmake/mkspecs/features/functions.prf (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2013-02-19  Simon Hausmann  <simon.hausmann@digia.com>
+
+        [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
+        https://bugs.webkit.org/show_bug.cgi?id=110215
+
+        Reviewed by Tor Arne Vestbø.
+
+        Check that gperf, python, ruby, perl, bison and flex are in the PATH before
+        continuing the build. Otherwise skip with an error message explaining which
+        programs are missing from the build.
+
+        * qmake/mkspecs/features/configure.prf:
+        * qmake/mkspecs/features/functions.prf:
+
 2013-02-19  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Tools/qmake/mkspecs/features/configure.prf

@@ -112 +112 @@
     # Sanity checks that would prevent us from building the whole project altogether.
     !mac:!contains(QT_CONFIG,icu) {
-        skipBuildReason = "ICU is required. To build QtWebKit with Qt 5 you need to build Qt 5 with libICU support. Check for ICU support being mentioned in qtbase/config.summary.")
+        addReasonForSkippingBuild("ICU is required. To build QtWebKit with Qt 5 you need to build Qt 5 with libICU support. Check for ICU support being mentioned in qtbase/config.summary.")
     }
     production_build:blackberry {
-        skipBuildReason = "Build not supported on BB10 yet."
-    }
+        addReasonForSkippingBuild("Build not supported on BB10 yet.")
+    }
+    requiredPrograms = gperf python perl bison ruby flex
+    for(program, requiredPrograms): \
+        !programExistsInPath($$program): \
+            addReasonForSkippingBuild("Missing $$program from PATH")
 
     # Detect changes to the configuration. Changes need a clean build.
@@ -234 +238 @@
 
         !isEmpty(skipBuildReason) {
-            log("$${EOL}WebKit build disabled: " $$skipBuildReason "$${EOL}$${EOL}")
+            log("$${EOL}The WebKit build was disabled for the following reasons: $$skipBuildReason $${EOL}$${EOL}")
             SUBDIRS=
             export(SUBDIRS)

trunk/Tools/qmake/mkspecs/features/functions.prf

@@ -204 +204 @@
 }
 
+defineTest(programExistsInPath) {
+    win_cmd_shell: program = $${1}.exe
+    else: program = $$1
+
+    PATH = "$$(PATH)"
+    paths=$$split(PATH, $$QMAKE_DIRLIST_SEP)
+
+    GNUTOOLS_DIR=$$[QT_HOST_DATA]/../gnuwin32/bin
+    exists($$GNUTOOLS_DIR): paths += $$GNUTOOLS_DIR
+
+    for(p, paths): exists($$p/$$program):return(true)
+    return(false)
+}
+
+defineTest(addReasonForSkippingBuild) {
+    skipBuildReason = "$$skipBuildReason$${EOL}    * $$1"
+    export(skipBuildReason)
+}
+
 defineTest(prependEach) {
     unset(variable)