Changeset 143351 in webkit

Timestamp:

Feb 19, 2013 10:12:03 AM (11 years ago)

Author:

mhahnenberg@apple.com

Message:

WeakSet::removeAllocator leaks WeakBlocks
​https://bugs.webkit.org/show_bug.cgi?id=110228

Reviewed by Geoffrey Garen.

We need to return the WeakBlock to the BlockAllocator after the call to WeakBlock::destroy.

• heap/WeakSet.cpp:

(JSC::WeakSet::removeAllocator):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/WeakSet.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
+
+        WeakSet::removeAllocator leaks WeakBlocks
+        https://bugs.webkit.org/show_bug.cgi?id=110228
+
+        Reviewed by Geoffrey Garen.
+
+        We need to return the WeakBlock to the BlockAllocator after the call to WeakBlock::destroy.
+
+        * heap/WeakSet.cpp:
+        (JSC::WeakSet::removeAllocator):
+
 2013-02-18  Geoffrey Garen  <ggaren@apple.com>
 

trunk/Source/JavaScriptCore/heap/WeakSet.cpp

@@ -85 +85 @@
 {
     m_blocks.remove(block);
-    WeakBlock::destroy(block);
+    heap()->blockAllocator().deallocate(WeakBlock::destroy(block));
 }