Changeset 143354 in webkit

Timestamp:

Feb 19, 2013 10:40:03 AM (11 years ago)

Author:

mhahnenberg@apple.com

Message:

HeapBlock::destroy should issue warning if result is unused
​https://bugs.webkit.org/show_bug.cgi?id=110233

Reviewed by Oliver Hunt.

To enforce the fact that we need to return blocks to the BlockAllocator after calling destroy,
we should add WARN_UNUSED_RETURN to HeapBlock::destroy and any other destroy functions in its subclasses.

• heap/HeapBlock.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• heap/HeapBlock.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
+
+        HeapBlock::destroy should issue warning if result is unused
+        https://bugs.webkit.org/show_bug.cgi?id=110233
+
+        Reviewed by Oliver Hunt.
+
+        To enforce the fact that we need to return blocks to the BlockAllocator after calling destroy, 
+        we should add WARN_UNUSED_RETURN to HeapBlock::destroy and any other destroy functions in its subclasses.
+
+        * heap/HeapBlock.h:
+
 2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
 

trunk/Source/JavaScriptCore/heap/HeapBlock.h

@@ -46 +46 @@
     friend CLASS_IF_GCC DoublyLinkedListNode<T>;
 public:
-    static HeapBlock* destroy(HeapBlock* block)
+    static HeapBlock* destroy(HeapBlock* block) WARN_UNUSED_RETURN
     {
         static_cast<T*>(block)->~T();