Changeset 143422 in webkit
- Timestamp:
- Feb 19, 2013 6:27:30 PM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 12 edited
- 2 moved
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/CMakeLists.txt
r143136 r143422 1118 1118 1119 1119 dom/ActiveDOMObject.cpp 1120 dom/AncestorChainWalker.cpp1121 1120 dom/Attr.cpp 1122 1121 dom/BeforeTextInsertedEvent.cpp … … 1177 1176 dom/EventListenerMap.cpp 1178 1177 dom/EventNames.cpp 1178 dom/EventPathWalker.cpp 1179 1179 dom/EventRetargeter.cpp 1180 1180 dom/EventTarget.cpp -
trunk/Source/WebCore/ChangeLog
r143421 r143422 1 2013-02-19 Hayato Ito <hayato@chromium.org> 2 3 Rename AncestorChainWalker. 4 https://bugs.webkit.org/show_bug.cgi?id=110146 5 6 Reviewed by Dimitri Glazkov. 7 8 Rename AncestorChainWalker to EventPathWalker. 9 The term of EventPath is used in DOM Core spec. EventPath was 10 already introduced into a EventContext.h in r112055. We should 11 spread this term into the Walker class since they share the same 12 purpose. 13 14 No new tests, no behavior change. 15 16 * CMakeLists.txt: 17 * GNUmakefile.list.am: 18 * Target.pri: 19 * WebCore.gypi: 20 * WebCore.xcodeproj/project.pbxproj: 21 * dom/DOMAllInOne.cpp: 22 * dom/EventDispatcher.cpp: 23 * dom/EventPathWalker.cpp: Renamed from Source/WebCore/dom/AncestorChainWalker.cpp. 24 (WebCore): 25 (WebCore::EventPathWalker::EventPathWalker): 26 (WebCore::EventPathWalker::parent): parent() is now a static function to cover simple use cases. 27 (WebCore::EventPathWalker::moveToParent): Renamed from parent(). 28 * dom/EventPathWalker.h: Renamed from Source/WebCore/dom/AncestorChainWalker.h. 29 (WebCore): 30 (EventPathWalker): 31 (WebCore::EventPathWalker::node): 32 (WebCore::EventPathWalker::isVisitingInsertionPointInReprojection): Renamed from isCrossingInsertionPoint(). 33 * dom/EventRetargeter.cpp: 34 (WebCore::EventRetargeter::calculateEventPath): 35 (WebCore::EventRetargeter::buildRelatedNodeMap): 36 * dom/TreeScope.cpp: 37 (WebCore::TreeScope::focusedNode): 38 * html/HTMLLIElement.cpp: 39 (WebCore::HTMLLIElement::attach): 40 * page/EventHandler.cpp: 41 (WebCore::EventHandler::updateMouseEventTargetNode): 42 (WebCore::EventHandler::handleWheelEvent): 43 1 44 2013-02-19 Dean Jackson <dino@apple.com> 2 45 -
trunk/Source/WebCore/GNUmakefile.list.am
r143264 r143422 2744 2744 Source/WebCore/dom/ActiveDOMObject.cpp \ 2745 2745 Source/WebCore/dom/ActiveDOMObject.h \ 2746 Source/WebCore/dom/AncestorChainWalker.cpp \2747 Source/WebCore/dom/AncestorChainWalker.h \2748 2746 Source/WebCore/dom/Attr.cpp \ 2749 2747 Source/WebCore/dom/Attr.h \ … … 2877 2875 Source/WebCore/dom/EventNames.cpp \ 2878 2876 Source/WebCore/dom/EventNames.h \ 2877 Source/WebCore/dom/EventPathWalker.cpp \ 2878 Source/WebCore/dom/EventPathWalker.h \ 2879 2879 Source/WebCore/dom/EventRetargeter.cpp \ 2880 2880 Source/WebCore/dom/EventTarget.cpp \ -
trunk/Source/WebCore/Target.pri
r143264 r143422 353 353 css/WebKitCSSViewportRule.cpp \ 354 354 dom/ActiveDOMObject.cpp \ 355 dom/AncestorChainWalker.cpp \356 355 dom/Attr.cpp \ 357 356 dom/BeforeTextInsertedEvent.cpp \ … … 411 410 dom/EventListenerMap.cpp \ 412 411 dom/EventNames.cpp \ 412 dom/EventPathWalker.cpp \ 413 413 dom/EventRetargeter.cpp \ 414 414 dom/EventTarget.cpp \ -
trunk/Source/WebCore/WebCore.gypi
r143264 r143422 2737 2737 'webcore_dom_files': [ 2738 2738 'dom/ActiveDOMObject.cpp', 2739 'dom/AncestorChainWalker.cpp',2740 'dom/AncestorChainWalker.h',2741 2739 'dom/Attr.cpp', 2742 2740 'dom/AutocompleteErrorEvent.h', … … 2842 2840 'dom/EventListenerMap.cpp', 2843 2841 'dom/EventNames.cpp', 2842 'dom/EventPathWalker.cpp', 2843 'dom/EventPathWalker.h', 2844 2844 'dom/EventQueue.h', 2845 2845 'dom/EventSender.h', -
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
r143270 r143422 1461 1461 4A9CC82016BF9BB400EC645A /* InspectorCSSOMWrappers.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4A9CC81E16BF9BB400EC645A /* InspectorCSSOMWrappers.cpp */; }; 1462 1462 4A9CC82116BF9BB400EC645A /* InspectorCSSOMWrappers.h in Headers */ = {isa = PBXBuildFile; fileRef = 4A9CC81F16BF9BB400EC645A /* InspectorCSSOMWrappers.h */; }; 1463 4AAAB4C416D379B5001DA41B /* EventPathWalker.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4AAAB4C216D379B5001DA41B /* EventPathWalker.cpp */; }; 1464 4AAAB4C516D379B5001DA41B /* EventPathWalker.h in Headers */ = {isa = PBXBuildFile; fileRef = 4AAAB4C316D379B5001DA41B /* EventPathWalker.h */; }; 1463 1465 4ABDFF0B14DBE385004D117D /* HTMLShadowElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = 4ABDFF0714DBE312004D117D /* HTMLShadowElement.cpp */; }; 1464 1466 4ABDFF0C14DBE385004D117D /* HTMLShadowElement.h in Headers */ = {isa = PBXBuildFile; fileRef = 4ABDFF0814DBE312004D117D /* HTMLShadowElement.h */; }; … … 3959 3961 A781C6A713828B5D0012A62A /* DocumentMarker.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A781C6A613828B5D0012A62A /* DocumentMarker.cpp */; }; 3960 3962 A784941B0B5FE507001E237A /* Clipboard.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A784941A0B5FE507001E237A /* Clipboard.cpp */; }; 3961 A78CDD2E169E91A1009136F3 /* AncestorChainWalker.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A75CBE43169E913D0003A60F /* AncestorChainWalker.cpp */; };3962 A78CDD30169E91A4009136F3 /* AncestorChainWalker.h in Headers */ = {isa = PBXBuildFile; fileRef = A75CBE44169E913D0003A60F /* AncestorChainWalker.h */; };3963 3963 A78E526F1346BD1700AD9C31 /* MeterShadowElement.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A78E526D1346BD1700AD9C31 /* MeterShadowElement.cpp */; }; 3964 3964 A78E52701346BD1700AD9C31 /* MeterShadowElement.h in Headers */ = {isa = PBXBuildFile; fileRef = A78E526E1346BD1700AD9C31 /* MeterShadowElement.h */; }; … … 8895 8895 4A9CC81E16BF9BB400EC645A /* InspectorCSSOMWrappers.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = InspectorCSSOMWrappers.cpp; sourceTree = "<group>"; }; 8896 8896 4A9CC81F16BF9BB400EC645A /* InspectorCSSOMWrappers.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = InspectorCSSOMWrappers.h; sourceTree = "<group>"; }; 8897 4AAAB4C216D379B5001DA41B /* EventPathWalker.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = EventPathWalker.cpp; sourceTree = "<group>"; }; 8898 4AAAB4C316D379B5001DA41B /* EventPathWalker.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = EventPathWalker.h; sourceTree = "<group>"; }; 8897 8899 4ABDFF0714DBE312004D117D /* HTMLShadowElement.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = HTMLShadowElement.cpp; sourceTree = "<group>"; }; 8898 8900 4ABDFF0814DBE312004D117D /* HTMLShadowElement.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = HTMLShadowElement.h; sourceTree = "<group>"; }; … … 11435 11437 A73F95FD12C97BFE0031AAF9 /* RoundedRect.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RoundedRect.h; sourceTree = "<group>"; }; 11436 11438 A74BB76A13BDA86300FF7BF0 /* ExceptionCodePlaceholder.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = ExceptionCodePlaceholder.h; sourceTree = "<group>"; }; 11437 A75CBE43169E913D0003A60F /* AncestorChainWalker.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = AncestorChainWalker.cpp; sourceTree = "<group>"; };11438 A75CBE44169E913D0003A60F /* AncestorChainWalker.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = AncestorChainWalker.h; sourceTree = "<group>"; };11439 11439 A75E497410752ACB00C9B896 /* SerializedScriptValue.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = SerializedScriptValue.h; sourceTree = "<group>"; }; 11440 11440 A75E497510752ACB00C9B896 /* SerializedScriptValue.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = SerializedScriptValue.cpp; sourceTree = "<group>"; }; … … 22444 22444 E1C4DE6D0EA75C650023CCD6 /* ActiveDOMObject.cpp */, 22445 22445 E1C4DE680EA75C1E0023CCD6 /* ActiveDOMObject.h */, 22446 A75CBE43169E913D0003A60F /* AncestorChainWalker.cpp */,22447 A75CBE44169E913D0003A60F /* AncestorChainWalker.h */,22448 22446 A8C4A7FC09D563270003AC8D /* Attr.cpp */, 22449 22447 A8C4A7FB09D563270003AC8D /* Attr.h */, … … 22606 22604 939885C208B7E3D100E707C4 /* EventNames.h */, 22607 22605 BC9A6142146859D9006057FD /* EventNames.in */, 22606 4AAAB4C216D379B5001DA41B /* EventPathWalker.cpp */, 22607 4AAAB4C316D379B5001DA41B /* EventPathWalker.h */, 22608 22608 8F6756191288B17B0047ACA3 /* EventQueue.h */, 22609 22609 4A5CB1C316C3A5FD00AB2886 /* EventRetargeter.cpp */, … … 23227 23227 CE7B2DB31586ABAD0098B3FA /* AlternativeTextUIController.h in Headers */, 23228 23228 FD31603E12B0267600C1A359 /* AnalyserNode.h in Headers */, 23229 A78CDD30169E91A4009136F3 /* AncestorChainWalker.h in Headers */,23230 23229 490707E71219C04300D90E51 /* ANGLEWebKitBridge.h in Headers */, 23231 23230 49E912AB0EFAC906009D0CAF /* Animation.h in Headers */, … … 24334 24333 1CA19E160DC255CA0065A994 /* EventLoop.h in Headers */, 24335 24334 939885C408B7E3D100E707C4 /* EventNames.h in Headers */, 24335 4AAAB4C516D379B5001DA41B /* EventPathWalker.h in Headers */, 24336 24336 8F67561B1288B17B0047ACA3 /* EventQueue.h in Headers */, 24337 24337 E0FEF372B17C53EAC1C1FBEE /* EventSource.h in Headers */, … … 26962 26962 CE7B2DB41586ABAD0098B3FA /* AlternativeTextUIController.mm in Sources */, 26963 26963 FD31603D12B0267600C1A359 /* AnalyserNode.cpp in Sources */, 26964 A78CDD2E169E91A1009136F3 /* AncestorChainWalker.cpp in Sources */,26965 26964 490707E61219C04300D90E51 /* ANGLEWebKitBridge.cpp in Sources */, 26966 26965 49E912AA0EFAC906009D0CAF /* Animation.cpp in Sources */, … … 27682 27681 939885C308B7E3D100E707C4 /* EventNames.cpp in Sources */, 27683 27682 E0FEF372B27C53EAC1C1FBEE /* EventSource.cpp in Sources */, 27683 4AAAB4C416D379B5001DA41B /* EventPathWalker.cpp in Sources */, 27684 27684 4A5CB1C516C3A5FD00AB2886 /* EventRetargeter.cpp in Sources */, 27685 27685 E12EDBEA0B308E0B002704B6 /* EventTarget.cpp in Sources */, -
trunk/Source/WebCore/dom/DOMAllInOne.cpp
r142959 r143422 27 27 28 28 #include "ActiveDOMObject.cpp" 29 #include "AncestorChainWalker.cpp"30 29 #include "Attr.cpp" 31 30 #include "BeforeTextInsertedEvent.cpp" … … 81 80 #include "EventListenerMap.cpp" 82 81 #include "EventNames.cpp" 82 #include "EventPathWalker.cpp" 83 83 #include "EventRetargeter.cpp" 84 84 #include "EventTarget.cpp" -
trunk/Source/WebCore/dom/EventDispatcher.cpp
r143303 r143422 27 27 #include "EventDispatcher.h" 28 28 29 #include "AncestorChainWalker.h"30 29 #include "ContainerNode.h" 31 30 #include "ElementShadow.h" 32 31 #include "EventContext.h" 33 32 #include "EventDispatchMediator.h" 33 #include "EventPathWalker.h" 34 34 #include "EventRetargeter.h" 35 35 #include "FrameView.h" -
trunk/Source/WebCore/dom/EventPathWalker.cpp
r143421 r143422 26 26 27 27 #include "config.h" 28 #include " AncestorChainWalker.h"28 #include "EventPathWalker.h" 29 29 30 30 #include "ContentDistributor.h" … … 34 34 namespace WebCore { 35 35 36 AncestorChainWalker::AncestorChainWalker(const Node* node)36 EventPathWalker::EventPathWalker(const Node* node) 37 37 : m_node(node) 38 38 , m_distributedNode(node) 39 , m_is CrossingInsertionPoint(false)39 , m_isVisitingInsertionPointInReprojection(false) 40 40 { 41 41 ASSERT(node); 42 42 } 43 43 44 void AncestorChainWalker::parent() 44 Node* EventPathWalker::parent(const Node* node) 45 { 46 EventPathWalker walker(node); 47 walker.moveToParent(); 48 return walker.node(); 49 } 50 51 void EventPathWalker::moveToParent() 45 52 { 46 53 ASSERT(m_node); … … 49 56 if (InsertionPoint* insertionPoint = shadow->distributor().findInsertionPointFor(m_distributedNode)) { 50 57 m_node = insertionPoint; 51 m_is CrossingInsertionPoint= true;58 m_isVisitingInsertionPointInReprojection = true; 52 59 return; 53 60 } … … 57 64 if (!(m_node && m_node->isShadowRoot() && ScopeContentDistribution::assignedTo(toShadowRoot(m_node)))) 58 65 m_distributedNode = m_node; 59 m_is CrossingInsertionPoint= false;66 m_isVisitingInsertionPointInReprojection = false; 60 67 return; 61 68 } … … 64 71 if (InsertionPoint* insertionPoint = ScopeContentDistribution::assignedTo(shadowRoot)) { 65 72 m_node = insertionPoint; 66 m_is CrossingInsertionPoint= true;73 m_isVisitingInsertionPointInReprojection = true; 67 74 return; 68 75 } 69 76 m_node = shadowRoot->host(); 70 77 m_distributedNode = m_node; 71 m_is CrossingInsertionPoint= false;78 m_isVisitingInsertionPointInReprojection = false; 72 79 } 73 80 -
trunk/Source/WebCore/dom/EventPathWalker.h
r143421 r143422 25 25 */ 26 26 27 #ifndef AncestorChainWalker_h28 #define AncestorChainWalker_h27 #ifndef EventPathWalker_h 28 #define EventPathWalker_h 29 29 30 30 namespace WebCore { … … 32 32 class Node; 33 33 34 class AncestorChainWalker {34 class EventPathWalker { 35 35 public: 36 explicit AncestorChainWalker(const Node*); 37 void parent(); 38 Node* get() const { return const_cast<Node*>(m_node); } 39 bool crossingInsertionPoint() { return m_isCrossingInsertionPoint; } 36 explicit EventPathWalker(const Node*); 37 static Node* parent(const Node*); 38 void moveToParent(); 39 Node* node() const { return const_cast<Node*>(m_node); } 40 bool isVisitingInsertionPointInReprojection() { return m_isVisitingInsertionPointInReprojection; } 40 41 41 42 private: 42 43 const Node* m_node; 43 44 const Node* m_distributedNode; 44 bool m_is CrossingInsertionPoint;45 bool m_isVisitingInsertionPointInReprojection; 45 46 }; 46 47 -
trunk/Source/WebCore/dom/EventRetargeter.cpp
r142957 r143422 21 21 #include "EventRetargeter.h" 22 22 23 #include "AncestorChainWalker.h"24 23 #include "ContainerNode.h" 25 24 #include "EventContext.h" 25 #include "EventPathWalker.h" 26 26 #include "FocusEvent.h" 27 27 #include "MouseEvent.h" … … 79 79 bool isMouseOrFocusEvent = event->isMouseEvent() || event->isFocusEvent(); 80 80 Vector<EventTarget*, 32> targetStack; 81 for ( AncestorChainWalker walker(node); walker.get(); walker.parent()) {82 Node* node = walker. get();81 for (EventPathWalker walker(node); walker.node(); walker.moveToParent()) { 82 Node* node = walker.node(); 83 83 if (targetStack.isEmpty()) 84 84 targetStack.append(eventTargetRespectingTargetRules(node)); 85 else if (walker. crossingInsertionPoint())85 else if (walker.isVisitingInsertionPointInReprojection()) 86 86 targetStack.append(targetStack.last()); 87 87 if (isMouseOrFocusEvent) … … 169 169 Vector<Node*, 32> relatedNodeStack; 170 170 TreeScope* lastTreeScope = 0; 171 for ( AncestorChainWalker walker(relatedNode); walker.get(); walker.parent()) {172 Node* node = walker. get();171 for (EventPathWalker walker(relatedNode); walker.node(); walker.moveToParent()) { 172 Node* node = walker.node(); 173 173 if (relatedNodeStack.isEmpty()) 174 174 relatedNodeStack.append(node); 175 else if (walker. crossingInsertionPoint())175 else if (walker.isVisitingInsertionPointInReprojection()) 176 176 relatedNodeStack.append(relatedNodeStack.last()); 177 177 TreeScope* scope = node->treeScope(); -
trunk/Source/WebCore/dom/TreeScope.cpp
r141570 r143422 28 28 #include "TreeScope.h" 29 29 30 #include "AncestorChainWalker.h"31 30 #include "ContainerNode.h" 32 31 #include "DOMSelection.h" … … 34 33 #include "Document.h" 35 34 #include "Element.h" 35 #include "EventPathWalker.h" 36 36 #include "FocusController.h" 37 37 #include "Frame.h" … … 353 353 return 0; 354 354 Vector<Node*> targetStack; 355 for ( AncestorChainWalker walker(node); walker.get(); walker.parent()) {356 Node* node = walker. get();355 for (EventPathWalker walker(node); walker.node(); walker.moveToParent()) { 356 Node* node = walker.node(); 357 357 if (targetStack.isEmpty()) 358 358 targetStack.append(node); 359 else if (walker. crossingInsertionPoint())359 else if (walker.isVisitingInsertionPointInReprojection()) 360 360 targetStack.append(targetStack.last()); 361 361 if (node == rootNode()) -
trunk/Source/WebCore/html/HTMLLIElement.cpp
r139325 r143422 24 24 #include "HTMLLIElement.h" 25 25 26 #include "AncestorChainWalker.h"27 26 #include "Attribute.h" 28 27 #include "CSSPropertyNames.h" 29 28 #include "CSSValueKeywords.h" 29 #include "EventPathWalker.h" 30 30 #include "HTMLNames.h" 31 31 #include "RenderListItem.h" … … 97 97 // Find the enclosing list node. 98 98 Node* listNode = 0; 99 AncestorChainWalker walker(this);99 EventPathWalker walker(this); 100 100 while (!listNode) { 101 walker. parent();102 if (!walker. get())101 walker.moveToParent(); 102 if (!walker.node()) 103 103 break; 104 if (walker. get()->hasTagName(ulTag) || walker.get()->hasTagName(olTag))105 listNode = walker. get();104 if (walker.node()->hasTagName(ulTag) || walker.node()->hasTagName(olTag)) 105 listNode = walker.node(); 106 106 } 107 107 -
trunk/Source/WebCore/page/EventHandler.cpp
r143148 r143422 30 30 31 31 #include "AXObjectCache.h" 32 #include "AncestorChainWalker.h"33 32 #include "AutoscrollController.h" 34 33 #include "CachedImage.h" … … 44 43 #include "EditorClient.h" 45 44 #include "EventNames.h" 45 #include "EventPathWalker.h" 46 46 #include "ExceptionCodePlaceholder.h" 47 47 #include "FloatPoint.h" … … 2120 2120 else { 2121 2121 // If the target node is a text node, dispatch on the parent node - rdar://4196646 2122 if (result && result->isTextNode()) { 2123 AncestorChainWalker walker(result); 2124 walker.parent(); 2125 result = walker.get(); 2126 } 2122 if (result && result->isTextNode()) 2123 result = EventPathWalker::parent(result); 2127 2124 } 2128 2125 m_nodeUnderMouse = result; … … 2332 2329 Node* node = result.innerNode(); 2333 2330 // Wheel events should not dispatch to text nodes. 2334 if (node && node->isTextNode()) { 2335 AncestorChainWalker walker(node); 2336 walker.parent(); 2337 node = walker.get(); 2338 } 2331 if (node && node->isTextNode()) 2332 node = EventPathWalker::parent(node); 2339 2333 2340 2334 bool isOverWidget;
Note: See TracChangeset
for help on using the changeset viewer.