Changeset 143455 in webkit

Timestamp:

Feb 20, 2013 5:40:19 AM (11 years ago)

Author:

loislo@chromium.org

Message:

Web Inspector: fix for frontend closure compile errors.
​https://bugs.webkit.org/show_bug.cgi?id=110329

Reviewed by Vsevolod Vlasov.

It has no tests because it has no code changes.

• inspector/front-end/HeapSnapshot.js:

(HeapSnapshotMetainfo):

• inspector/front-end/NativeMemorySnapshotView.js:

(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
(WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/HeapSnapshot.js (modified) (1 diff)
• inspector/front-end/NativeMemorySnapshotView.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-20  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: fix for frontend closure compile errors.
+        https://bugs.webkit.org/show_bug.cgi?id=110329
+
+        Reviewed by Vsevolod Vlasov.
+
+        It has no tests because it has no code changes.
+
+        * inspector/front-end/HeapSnapshot.js:
+        (HeapSnapshotMetainfo):
+        * inspector/front-end/NativeMemorySnapshotView.js:
+        (WebInspector.NativeSnapshotProfileType.prototype.buttonClicked.didReceiveMemorySnapshot):
+        (WebInspector.NativeSnapshotProfileType.prototype.buttonClicked):
+
 2013-02-20  Florin Malita  <fmalita@chromium.org>
 

trunk/Source/WebCore/inspector/front-end/HeapSnapshot.js

@@ -509 +509 @@
     this.edge_fields = [];
     this.edge_types = [];
+    this.type_strings = {};
 
     // Old format.

trunk/Source/WebCore/inspector/front-end/NativeMemorySnapshotView.js

@@ -267 +267 @@
          * @param {?string} error
          * @param {?MemoryAgent.MemoryBlock} memoryBlock
+         * @param {Object=} graphMetaInformation
          */
         function didReceiveMemorySnapshot(error, memoryBlock, graphMetaInformation)
         {
+            var metaInformation = /** @type{HeapSnapshotMetainfo} */(graphMetaInformation);
             this.isTemporary = false;
             this.sidebarElement.subtitle = Number.bytesToString(/** @type{number} */(memoryBlock.size));
 
-            var edgeFieldCount = graphMetaInformation.edge_fields.length;
-            var nodeFieldCount = graphMetaInformation.node_fields.length;
-            var nodeIdFieldOffset = graphMetaInformation.node_fields.indexOf("id");
-            var toNodeIdFieldOffset = graphMetaInformation.edge_fields.indexOf("to_node");
+            var edgeFieldCount = metaInformation.edge_fields.length;
+            var nodeFieldCount = metaInformation.node_fields.length;
+            var nodeIdFieldOffset = metaInformation.node_fields.indexOf("id");
+            var toNodeIdFieldOffset = metaInformation.edge_fields.indexOf("to_node");
 
             var baseToRealNodeIdMap = {};
@@ -296 +298 @@
             var heapSnapshot = {
                 "snapshot": {
-                    "meta": graphMetaInformation,
+                    "meta": metaInformation,
                     node_count: this._nodes.length / nodeFieldCount,
                     edge_count: this._edges.length / edgeFieldCount,