Changeset 143464 in webkit


Ignore:
Timestamp:
Feb 20, 2013 7:38:57 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[v8] potentially disposed handle returned for npapi object
https://bugs.webkit.org/show_bug.cgi?id=110331

Patch by Dan Carney <dcarney@google.com> on 2013-02-20
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r143463 r143464  
     12013-02-20  Dan Carney  <dcarney@google.com>
     2
     3        [v8] potentially disposed handle returned for npapi object
     4        https://bugs.webkit.org/show_bug.cgi?id=110331
     5
     6        Reviewed by Kentaro Hara.
     7
     8        No new tests. No change in functionality.
     9
     10        * bindings/v8/V8NPUtils.cpp:
     11        (WebCore::convertNPVariantToV8Object):
     12
    1132013-02-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>  and  Martin Robinson  <mrobinson@igalia.com>
    214
  • trunk/Source/WebCore/bindings/v8/V8NPUtils.cpp

    r141946 r143464  
    9999        NPObject* obj = NPVARIANT_TO_OBJECT(*variant);
    100100        if (obj->_class == npScriptObjectClass)
    101             return reinterpret_cast<V8NPObject*>(obj)->v8Object;
     101            return v8::Local<v8::Value>::New(reinterpret_cast<V8NPObject*>(obj)->v8Object);
    102102        return createV8ObjectForNPObject(obj, npobject);
    103103    }
Note: See TracChangeset for help on using the changeset viewer.