Changeset 143518 in webkit


Ignore:
Timestamp:
Feb 20, 2013 3:31:31 PM (11 years ago)
Author:
nghanavatian@rim.com
Message:

[BlackBerry] Check offset for initialized value
https://bugs.webkit.org/show_bug.cgi?id=110390

Reviewed by Rob Buis.

Instead of checking isEmpty, which checks for either point being <= 0, we want to explicitly check
for the initialized value of (-1, -1). This would be set in redrawSpellCheckDialogIfRequired, and
triggers the restore from cache in requestSpellingCheckingOptions.

Internally reviewed by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

Location:
trunk/Source/WebKit/blackberry
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/blackberry/ChangeLog

    r143466 r143518  
     12013-02-20  Nima Ghanavatian  <nghanavatian@rim.com>
     2
     3        [BlackBerry] Check offset for initialized value
     4        https://bugs.webkit.org/show_bug.cgi?id=110390
     5
     6        Reviewed by Rob Buis.
     7
     8        Instead of checking isEmpty, which checks for either point being <= 0, we want to explicitly check
     9        for the initialized value of (-1, -1). This would be set in redrawSpellCheckDialogIfRequired, and
     10        triggers the restore from cache in requestSpellingCheckingOptions.
     11
     12        Internally reviewed by Gen Mak.
     13
     14        * WebKitSupport/InputHandler.cpp:
     15        (BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):
     16
    1172013-02-20  Jakob Petsovits  <jpetsovits@rim.com>
    218
  • trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp

    r143391 r143518  
    799799        return;
    800800
    801     if (screenOffset.isEmpty()) {
     801    if (screenOffset.width() == -1 && screenOffset.height() == -1) {
    802802        screenOffset.setWidth(m_screenOffset.width());
    803803        screenOffset.setHeight(m_screenOffset.height());
Note: See TracChangeset for help on using the changeset viewer.