Changeset 143540 in webkit


Ignore:
Timestamp:
Feb 20, 2013 5:09:37 PM (11 years ago)
Author:
jer.noble@apple.com
Message:

Crash in com.apple.WebKit2.WebProcessService at com.apple.avfoundation: 73-[AVAssetResourceLoader _attemptDelegateHandlingOfRequestWithDictionary:]_block_invoke + 51
https://bugs.webkit.org/show_bug.cgi?id=110385

Reviewed by Eric Carlson.

Ensure AVFoundation does not attempt to message a dead object by explicitly disassociating
the AVAssetResourceLoaderDelegate on MediaPlayerPrivateAVFoundationObjC destruction.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r143539 r143540  
     12013-02-20  Jer Noble  <jer.noble@apple.com>
     2
     3        Crash in com.apple.WebKit2.WebProcessService at com.apple.avfoundation: __73-[AVAssetResourceLoader _attemptDelegateHandlingOfRequestWithDictionary:]_block_invoke + 51
     4        https://bugs.webkit.org/show_bug.cgi?id=110385
     5
     6        Reviewed by Eric Carlson.
     7
     8        Ensure AVFoundation does not attempt to message a dead object by explicitly disassociating
     9        the AVAssetResourceLoaderDelegate on MediaPlayerPrivateAVFoundationObjC destruction.
     10
     11        * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
     12        (WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):
     13
    1142013-02-20  Ojan Vafai  <ojan@chromium.org>
    215
  • trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm

    r143259 r143540  
    234234    playerToPrivateMap().remove(player());
    235235#endif
     236#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
     237    [[m_avAsset.get() resourceLoader] setDelegate:nil queue:0];
     238#endif
    236239    cancelLoad();
    237240}
Note: See TracChangeset for help on using the changeset viewer.