Changeset 143560 in webkit

Timestamp:

Feb 20, 2013 8:21:32 PM (11 years ago)

Author:

mkwst@chromium.org

Message:

Mouseup event does not fire on Scroll Bar
​https://bugs.webkit.org/show_bug.cgi?id=25811

Reviewed by Tony Chang.

Source/WebCore:

Currently, clicking on a scrollbar fires a mousedown event, but not a
mouseup event. This causes problems for code like jQuery UI's
draggable[1], as the drag starts, but is never cancelled. Other use
cases are noted in the slightly old Chromium bug[2].

If a mouseup event is received after a mousedown event on a scrollbar,
this patch dispatches a mouseup event on the same node the mousedown
event dispatched on. This matches Gecko's behavior.

[1]: ​http://bugs.jqueryui.com/ticket/6925
[2]: ​http://crbug.com/14204

Tests: fast/scrolling/scrollbar-mousedown-mouseup.html

fast/scrolling/scrollbar-mousedown-move-mouseup.html

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):

If a mouseup event follow a mousedown event on a scrollbar,
dispatch an event on the same node from which the mousedown event
was triggered.

LayoutTests:

• fast/scrolling/scrollbar-mousedown-mouseup-expected.txt: Added.
• fast/scrolling/scrollbar-mousedown-mouseup.html: Added.
• fast/scrolling/scrollbar-mousedown-move-mouseup-expected.txt: Added.
• fast/scrolling/scrollbar-mousedown-move-mouseup.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/scrolling/scrollbar-mousedown-mouseup-expected.txt (added)
• LayoutTests/fast/scrolling/scrollbar-mousedown-mouseup.html (added)
• LayoutTests/fast/scrolling/scrollbar-mousedown-move-mouseup-expected.txt (added)
• LayoutTests/fast/scrolling/scrollbar-mousedown-move-mouseup.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/EventHandler.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-20  Mike West  <mkwst@chromium.org>
+
+        Mouseup event does not fire on Scroll Bar
+        https://bugs.webkit.org/show_bug.cgi?id=25811
+
+        Reviewed by Tony Chang.
+
+        * fast/scrolling/scrollbar-mousedown-mouseup-expected.txt: Added.
+        * fast/scrolling/scrollbar-mousedown-mouseup.html: Added.
+        * fast/scrolling/scrollbar-mousedown-move-mouseup-expected.txt: Added.
+        * fast/scrolling/scrollbar-mousedown-move-mouseup.html: Added.
+
 2013-02-20  Takashi Toyoshima  <toyoshim@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-20  Mike West  <mkwst@chromium.org>
+
+        Mouseup event does not fire on Scroll Bar
+        https://bugs.webkit.org/show_bug.cgi?id=25811
+
+        Reviewed by Tony Chang.
+
+        Currently, clicking on a scrollbar fires a mousedown event, but not a
+        mouseup event. This causes problems for code like jQuery UI's
+        draggable[1], as the drag starts, but is never cancelled. Other use
+        cases are noted in the slightly old Chromium bug[2].
+
+        If a mouseup event is received after a mousedown event on a scrollbar,
+        this patch dispatches a mouseup event on the same node the mousedown
+        event dispatched on. This matches Gecko's behavior.
+
+        [1]: http://bugs.jqueryui.com/ticket/6925
+        [2]: http://crbug.com/14204
+
+        Tests: fast/scrolling/scrollbar-mousedown-mouseup.html
+               fast/scrolling/scrollbar-mousedown-move-mouseup.html
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::handleMouseReleaseEvent):
+            If a mouseup event follow a mousedown event on a scrollbar,
+            dispatch an event on the same node from which the mousedown event
+            was triggered.
+
 2013-02-20  Takashi Sakamoto  <tasak@google.com>
 

trunk/Source/WebCore/page/EventHandler.cpp

@@ -1830 +1830 @@
     if (m_lastScrollbarUnderMouse) {
         invalidateClick();
-        return m_lastScrollbarUnderMouse->mouseUp(mouseEvent);
+        m_lastScrollbarUnderMouse->mouseUp(mouseEvent);
+        bool cancelable = true;
+        bool setUnder = false;
+        return !dispatchMouseEvent(eventNames().mouseupEvent, m_lastNodeUnderMouse.get(), cancelable, m_clickCount, mouseEvent, setUnder);
     }