Changeset 143649 in webkit

Timestamp:

Feb 21, 2013 1:46:26 PM (11 years ago)

Author:

tonyg@chromium.org

Message:

Tune BackgroundHTMLParser's pendingTokenLimit based on a benchmark
​https://bugs.webkit.org/show_bug.cgi?id=110408

Reviewed by Adam Barth.

This constant was tuned by running the top 25 sites in Telemetry on a Nexus 7 device.
The new value decreases the maximum time spent parsing by 40% without significantly impacting total parse time or DOMContentLoaded.

No new tests because no new functionality.

• html/parser/BackgroundHTMLParser.cpp:

(WebCore):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/BackgroundHTMLParser.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-21  Tony Gentilcore  <tonyg@chromium.org>
+
+        Tune BackgroundHTMLParser's pendingTokenLimit based on a benchmark
+        https://bugs.webkit.org/show_bug.cgi?id=110408
+
+        Reviewed by Adam Barth.
+
+        This constant was tuned by running the top 25 sites in Telemetry on a Nexus 7 device.
+        The new value decreases the maximum time spent parsing by 40% without significantly impacting total parse time or DOMContentLoaded.
+
+        No new tests because no new functionality.
+
+        * html/parser/BackgroundHTMLParser.cpp:
+        (WebCore):
+
 2013-02-21  Sheriff Bot  <webkit.review.bot@gmail.com>
 

trunk/Source/WebCore/html/parser/BackgroundHTMLParser.cpp

@@ -113 +113 @@
 }
 
-// FIXME: Tune this constant based on a benchmark. The current value was chosen arbitrarily.
-static const size_t pendingTokenLimit = 4000;
+static const size_t pendingTokenLimit = 1000;
 
 BackgroundHTMLParser::BackgroundHTMLParser(PassRefPtr<WeakReference<BackgroundHTMLParser> > reference, PassOwnPtr<Configuration> config)