Changeset 143882 in webkit

Timestamp:

Feb 24, 2013 6:02:13 PM (11 years ago)

Author:

kihong.kwon@samsung.com

Message:

Add an ASSERT to didChangeDeviceProximity
​https://bugs.webkit.org/show_bug.cgi?id=110317

Reviewed by Hajime Morrita.

Source/WebCore:

Add An ASSERT to didChangeDeviceProximity function to check range of value.

Change exist test cases.

• Modules/proximity/DeviceProximityController.cpp:

(WebCore::DeviceProximityController::didChangeDeviceProximity):

LayoutTests:

Fix wrong test cases which are found by ASSERT insertion.

• proximity/basic-operation-expected.txt:
• proximity/basic-operation.html:
• proximity/resources/event-after-navigation-new.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/proximity/basic-operation-expected.txt (modified) (1 diff)
• LayoutTests/proximity/basic-operation.html (modified) (1 diff)
• LayoutTests/proximity/resources/event-after-navigation-new.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/proximity/DeviceProximityController.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-24  Kihong Kwon  <kihong.kwon@samsung.com>
+
+        Add an ASSERT to didChangeDeviceProximity
+        https://bugs.webkit.org/show_bug.cgi?id=110317
+
+        Reviewed by Hajime Morrita.
+
+        Fix wrong test cases which are found by ASSERT insertion.
+
+        * proximity/basic-operation-expected.txt:
+        * proximity/basic-operation.html:
+        * proximity/resources/event-after-navigation-new.html:
+
 2013-02-24  Mike West  <mkwst@chromium.org>
 

trunk/LayoutTests/proximity/basic-operation-expected.txt

@@ -5 +5 @@
 
 PASS deviceProximityEvent.value is firedEvent.value
-PASS deviceProximityEvent.min is firedEvent.max
-PASS deviceProximityEvent.max is firedEvent.min
+PASS deviceProximityEvent.min is firedEvent.min
+PASS deviceProximityEvent.max is firedEvent.max
 PASS successfullyParsed is true
 

trunk/LayoutTests/proximity/basic-operation.html

@@ -13 +13 @@
     deviceProximityEvent = e;
     shouldBe('deviceProximityEvent.value', 'firedEvent.value');
-    shouldBe('deviceProximityEvent.min', 'firedEvent.max');
-    shouldBe('deviceProximityEvent.max', 'firedEvent.min');
+    shouldBe('deviceProximityEvent.min', 'firedEvent.min');
+    shouldBe('deviceProximityEvent.max', 'firedEvent.max');
     finishJSTest();
 });
 
-internals.setDeviceProximity(document, 'webkitdeviceproximity', firedEvent.value, firedEvent.max, firedEvent.min);
+internals.setDeviceProximity(document, 'webkitdeviceproximity', firedEvent.value, firedEvent.min, firedEvent.max);
 window.jsTestIsAsync = true;
 </script>

trunk/LayoutTests/proximity/resources/event-after-navigation-new.html

@@ -8 +8 @@
     <script>
         if (window.testRunner) {
-            internals.setDeviceProximity(document, 'webkitdeviceproximity', 1.1, 2.2, 3.3);
+            internals.setDeviceProximity(document, 'webkitdeviceproximity', 2.2, 1.1, 3.3);
             testRunner.notifyDone();
         }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-24  Kihong Kwon  <kihong.kwon@samsung.com>
+
+        Add an ASSERT to didChangeDeviceProximity
+        https://bugs.webkit.org/show_bug.cgi?id=110317
+
+        Reviewed by Hajime Morrita.
+
+        Add An ASSERT to didChangeDeviceProximity function to check range of value.
+
+        Change exist test cases.
+
+        * Modules/proximity/DeviceProximityController.cpp:
+        (WebCore::DeviceProximityController::didChangeDeviceProximity):
+
 2013-02-24  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebCore/Modules/proximity/DeviceProximityController.cpp

@@ -48 +48 @@
 void DeviceProximityController::didChangeDeviceProximity(const double value, const double min, const double max)
 {
+    ASSERT(value >= min && value <= max);
+
     dispatchDeviceEvent(DeviceProximityEvent::create(eventNames().webkitdeviceproximityEvent, value, min, max));
 }