Changeset 144027 in webkit

Timestamp:

Feb 26, 2013 1:57:33 AM (11 years ago)

Author:

eric@webkit.org

Message:

Threaded HTML parser fails fast/loader/stateobjects/state-attribute-history-getter.html
​https://bugs.webkit.org/show_bug.cgi?id=110801

Reviewed by Adam Barth.

This causes 6 more tests to pass for the threaded parser,
an solves all of our timeout issues.

These tests which were failing were racy, we just were never
hitting the race due to using file urls. This change fixes
the threaded parser to emulate one more of the EOF quirks from
the loader/main-thread-parser interaction.

• html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/parser/HTMLDocumentParser.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-26  Eric Seidel  <eric@webkit.org>
+
+        Threaded HTML parser fails fast/loader/stateobjects/state-attribute-history-getter.html
+        https://bugs.webkit.org/show_bug.cgi?id=110801
+
+        Reviewed by Adam Barth.
+
+        This causes 6 more tests to pass for the threaded parser,
+        an solves all of our timeout issues.
+
+        These tests which were failing were racy, we just were never
+        hitting the race due to using file urls.  This change fixes
+        the threaded parser to emulate one more of the EOF quirks from
+        the loader/main-thread-parser interaction.
+
+        * html/parser/HTMLDocumentParser.cpp:
+        (WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
+
 2013-02-26  Alexander Pavlov  <apavlov@chromium.org>
 

trunk/Source/WebCore/html/parser/HTMLDocumentParser.cpp

@@ -384 +384 @@
 
         if (!isParsingFragment()
-            && document()->frame() && document()->frame()->navigationScheduler()->locationChangePending())
+            && document()->frame() && document()->frame()->navigationScheduler()->locationChangePending()) {
+
+            // To match main-thread parser behavior (which never checks locationChangePending on the EOF path)
+            // we peek to see if this chunk has an EOF and process it anyway.
+            if (tokens->last().type() == HTMLToken::EndOfFile)
+                prepareToStopParsing();
             break;
+        }
 
         if (isWaitingForScripts()) {