Changeset 144136 in webkit


Ignore:
Timestamp:
Feb 26, 2013 7:00:08 PM (11 years ago)
Author:
abarth@webkit.org
Message:

[Chromium] Enable threaded HTML parser by default in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=110907

Reviewed by Eric Seidel.

Tools:

This patch changes --enable-threaded-html-parser into
--disable-threaded-html-parser and thereby enables the threaded HTML
parser by default for the Chromium port.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:
  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):

LayoutTests:

Update test results to show subtle differences in FrameLoaderClient callbacks.

  • platform/chromium-mac/security/block-test-no-port-expected.txt: Removed.
  • platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt:
  • platform/chromium-win/security/block-test-no-port-expected.txt: Removed.
  • platform/chromium/fast/images/support-broken-image-delegate-expected.txt:
  • platform/chromium/fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
  • platform/chromium/http/tests/loading/307-after-303-after-post-expected.txt: Added.
  • platform/chromium/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
  • platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
  • platform/chromium/http/tests/misc/window-dot-stop-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
  • platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
  • platform/chromium/inspector/debugger/pause-in-inline-script-expected.txt: Added.
  • platform/chromium/inspector/timeline/timeline-script-tag-1-expected.txt: Added.
  • platform/chromium/security/block-test-no-port-expected.txt:
Location:
trunk
Files:
16 added
2 deleted
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r144134 r144136  
     12013-02-26  Adam Barth  <abarth@webkit.org>
     2
     3        [Chromium] Enable threaded HTML parser by default in DumpRenderTree
     4        https://bugs.webkit.org/show_bug.cgi?id=110907
     5
     6        Reviewed by Eric Seidel.
     7
     8        Update test results to show subtle differences in FrameLoaderClient callbacks.
     9
     10        * platform/chromium-mac/security/block-test-no-port-expected.txt: Removed.
     11        * platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt:
     12        * platform/chromium-win/security/block-test-no-port-expected.txt: Removed.
     13        * platform/chromium/fast/images/support-broken-image-delegate-expected.txt:
     14        * platform/chromium/fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
     15        * platform/chromium/http/tests/loading/307-after-303-after-post-expected.txt: Added.
     16        * platform/chromium/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
     17        * platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
     18        * platform/chromium/http/tests/misc/window-dot-stop-expected.txt: Added.
     19        * platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt: Added.
     20        * platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Added.
     21        * platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Added.
     22        * platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
     23        * platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Added.
     24        * platform/chromium/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
     25        * platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
     26        * platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt: Added.
     27        * platform/chromium/inspector/debugger/pause-in-inline-script-expected.txt: Added.
     28        * platform/chromium/inspector/timeline/timeline-script-tag-1-expected.txt: Added.
     29        * platform/chromium/security/block-test-no-port-expected.txt:
     30
    1312013-02-26  Stephen Chenney  <schenney@chromium.org>
    232

  • trunk/LayoutTests/platform/chromium-win/fast/images/support-broken-image-delegate-expected.txt

    r135516 r144136  
    11CONSOLE MESSAGE: line 8: Uncaught TypeError: Object [object Object] has no method 'setShouldPaintBrokenImage'
    22resources/broken-image-with-invalid-format.png - willSendRequest <NSURLRequest URL resources/broken-image-with-invalid-format.png, main document URL support-broken-image-delegate.html, http method GET> redirectResponse (null)
    3 <unknown> - didFinishLoading
    43resources/broken-image-with-invalid-format.png - didReceiveResponse <NSURLResponse resources/broken-image-with-invalid-format.png, http status code 0>
    54resources/broken-image-with-invalid-format.png - didFinishLoading

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r144134 r144136  
    29972997webkit.org/b/72039 [ Android Linux Release ] fast/forms/form-attribute-elements-order.html [ Missing Pass ]
    29982998webkit.org/b/72039 [ Android Linux Release ] fast/forms/form-attribute-elements-order2.html [ Missing Pass ]
    2999 webkit.org/b/72039 [ Debug ] http/tests/multipart/policy-ignore-crash.php [ Missing Pass ]
    30002999webkit.org/b/72039 [ Release ] fast/forms/formaction-attribute.html [ Missing Pass ]
    30013000webkit.org/b/78620 [ Android Linux Debug ] fast/forms/formaction-attribute.html [ Failure Pass Slow ]
     3001
     3002webkit.org/b/110929 http/tests/multipart/policy-ignore-crash.php [ Missing Failure ]
    30023003
    30033004webkit.org/b/70988 [ Mac Win Debug ] fast/forms/submit-to-blank-multiple-times.html [ Failure Pass ]

  • trunk/LayoutTests/platform/chromium/fast/images/support-broken-image-delegate-expected.txt

    r131694 r144136  
    11resources/broken-image-with-invalid-format.png - willSendRequest <NSURLRequest URL resources/broken-image-with-invalid-format.png, main document URL support-broken-image-delegate.html, http method GET> redirectResponse (null)
    2 <unknown> - didFinishLoading
    32resources/broken-image-with-invalid-format.png - didReceiveResponse <NSURLResponse resources/broken-image-with-invalid-format.png, http status code 0>
    43resources/broken-image-with-invalid-format.png - shouldPaintBrokenImage: NO

  • trunk/LayoutTests/platform/chromium/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt

    r137607 r144136  
    11http://127.0.0.1:8000/misc/resources/redirect-to-http-url.php - willSendRequest <NSURLRequest URL http://127.0.0.1:8000/misc/resources/redirect-to-http-url.php, main document URL http://127.0.0.1:8000/misc/will-send-request-returns-null-on-redirect.html, http method GET> redirectResponse (null)
    2 <unknown> - didFinishLoading
    32http://127.0.0.1:8000/misc/resources/redirect-to-http-url.php - willSendRequest <NSURLRequest URL http://www.example.com/, main document URL http://127.0.0.1:8000/misc/will-send-request-returns-null-on-redirect.html, http method GET> redirectResponse <NSURLResponse http://127.0.0.1:8000/misc/resources/redirect-to-http-url.php, http status code 302>
    43Returning null for this redirect

  • trunk/LayoutTests/platform/chromium/security/block-test-no-port-expected.txt

    r74097 r144136  
    11http://255.255.255.255/test.jpg - willSendRequest <NSURLRequest URL http://255.255.255.255/test.jpg, main document URL block-test-no-port.html, http method GET> redirectResponse (null)
    2 <unknown> - didFinishLoading
    3 http://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -138, failing URL "http://255.255.255.255/test.jpg">
     2http://255.255.255.255/test.jpg - didFailLoadingWithError: <NSError domain NSURLErrorDomain, code -1004, failing URL "http://255.255.255.255/test.jpg">
    43This test attempts to change the src of an IMG tag to a blocked IP with no port to confirm that WebKit returns the correct error for it - blocked instead of cannot find. Due to the nature of this test, the results can only be processed automatically via DumpRenderTree. In addition, on some systems the results may depend on the behavior of the proxy.
    54

  • trunk/Tools/ChangeLog

    r144116 r144136  
     12013-02-26  Adam Barth  <abarth@webkit.org>
     2
     3        [Chromium] Enable threaded HTML parser by default in DumpRenderTree
     4        https://bugs.webkit.org/show_bug.cgi?id=110907
     5
     6        Reviewed by Eric Seidel.
     7
     8        This patch changes --enable-threaded-html-parser into
     9        --disable-threaded-html-parser and thereby enables the threaded HTML
     10        parser by default for the Chromium port.
     11
     12        * DumpRenderTree/chromium/DumpRenderTree.cpp:
     13        * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
     14        (WebTestRunner::WebPreferences::reset):
     15        * DumpRenderTree/chromium/TestShell.cpp:
     16        (TestShell::TestShell):
     17
    1182013-02-26  Dirk Pranke  <dpranke@chromium.org>
    219

  • trunk/Tools/DumpRenderTree/chromium/DumpRenderTree.cpp

    r143852 r144136  
    6868static const char optionEnablePerTilePainting[] = "--enable-per-tile-painting";
    6969static const char optionEnableDeferredImageDecoding[] = "--enable-deferred-image-decoding";
    70 static const char optionEnableThreadedHTMLParser[] = "--enable-threaded-html-parser";
     70static const char optionDisableThreadedHTMLParser[] = "--disable-threaded-html-parser";
    7171
    7272static const char optionStressOpt[] = "--stress-opt";
    … …  
    139139    bool threadedCompositingEnabled = false;
    140140    bool forceCompositingMode = false;
    141     bool threadedHTMLParser = false;
     141    bool threadedHTMLParser = true;
    142142    bool accelerated2DCanvasEnabled = false;
    143143    bool deferred2DCanvasEnabled = false;
    … …  
    184184        else if (argument == optionForceCompositingMode)
    185185            forceCompositingMode = true;
    186         else if (argument == optionEnableThreadedHTMLParser)
    187             threadedHTMLParser = true;
     186        else if (argument == optionDisableThreadedHTMLParser)
     187            threadedHTMLParser = false;
    188188        else if (argument == optionEnableAccelerated2DCanvas)
    189189            accelerated2DCanvasEnabled = true;

  • trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp

    r142509 r144136  
    123123    acceleratedPaintingEnabled = false;
    124124    forceCompositingMode = false;
    125     threadedHTMLParser = false;
     125    threadedHTMLParser = true;
    126126    perTilePaintingEnabled = false;
    127127    acceleratedAnimationEnabled = false;

  • trunk/Tools/DumpRenderTree/chromium/TestShell.cpp

    r143898 r144136  
    114114    , m_threadedCompositingEnabled(false)
    115115    , m_forceCompositingMode(false)
    116     , m_threadedHTMLParser(false)
     116    , m_threadedHTMLParser(true)
    117117    , m_accelerated2dCanvasEnabled(false)
    118118    , m_deferred2dCanvasEnabled(false)
Note: See TracChangeset for help on using the changeset viewer.