Changeset 144338 in webkit

Timestamp:

Feb 28, 2013 11:40:02 AM (11 years ago)

Author:

Nate Chapin

Message:

Source/WebCore: Crash in CachedRawResource::responseReceived().
​https://bugs.webkit.org/show_bug.cgi?id=110482

Reviewed by Adam Barth.

Test: http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html

• loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::responseReceived):

LayoutTests: Test for ​https://bugs.webkit.org/show_bug.cgi?id=110482

Reviewed by Adam Barth.

• http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt: Added.
• http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html: Added.
• platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt (added)
• LayoutTests/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html (added)
• LayoutTests/platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/loader/cache/CachedRawResource.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-02-28  Nate Chapin  <japhet@chromium.org>
+
+        Test for https://bugs.webkit.org/show_bug.cgi?id=110482
+
+        Reviewed by Adam Barth.
+
+        * http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt: Added.
+        * http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html: Added.
+        * platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt: Added.
+
 2013-02-28  Chris Fleizach  <cfleizach@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-02-28  Nate Chapin  <japhet@chromium.org>
+
+        Crash in CachedRawResource::responseReceived().
+        https://bugs.webkit.org/show_bug.cgi?id=110482
+
+        Reviewed by Adam Barth.
+
+        Test: http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
+
+        * loader/cache/CachedRawResource.cpp:
+        (WebCore::CachedRawResource::responseReceived):
+
 2013-02-28  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebCore/loader/cache/CachedRawResource.cpp

@@ -129 +129 @@
 void CachedRawResource::responseReceived(const ResourceResponse& response)
 {
+    CachedResourceHandle<CachedRawResource> protect(this);
     if (!m_identifier)
         m_identifier = m_loader->identifier();