Changeset 144725 in webkit


Ignore:
Timestamp:
Mar 4, 2013 10:35:55 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

[Chromium] Add runtime flag for font load events
​https://bugs.webkit.org/show_bug.cgi?id=111296

Patch by Kunihiko Sakamoto <​ksakamoto@chromium.org> on 2013-03-04
Reviewed by Kent Tamura.

Add a runtime feature flag for FontLoader interface (disabled by default),
and enable ENABLE_FONT_LOAD_EVENTS build flag for chromium.

Source/WebCore:

  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setFontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled):

Source/WebKit/chromium:

  • features.gypi:
  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableFontLoadEvents):
(WebKit):
(WebKit::WebRuntimeFeatures::isFontLoadEventsEnabled):

Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r144723 r144725  
     12013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
     2
     3        [Chromium] Add runtime flag for font load events
     4        https://bugs.webkit.org/show_bug.cgi?id=111296
     5
     6        Reviewed by Kent Tamura.
     7
     8        Add a runtime feature flag for FontLoader interface (disabled by default),
     9        and enable ENABLE_FONT_LOAD_EVENTS build flag for chromium.
     10
     11        * bindings/generic/RuntimeEnabledFeatures.cpp:
     12        (WebCore):
     13        * bindings/generic/RuntimeEnabledFeatures.h:
     14        (RuntimeEnabledFeatures):
     15        (WebCore::RuntimeEnabledFeatures::setFontLoadEventsEnabled):
     16        (WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled):
     17
    1182013-03-04  Brandon Jones  <bajones@google.com>
    219

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp

    r143865 r144725  
    243243#endif
    244244
     245#if ENABLE(FONT_LOAD_EVENTS)
     246bool RuntimeEnabledFeatures::isFontLoadEventsEnabled = false;
     247#endif
     248
    245249} // namespace WebCore

  • trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h

    r143865 r144725  
    8888#endif
    8989
     90#if ENABLE(FONT_LOAD_EVENTS)
     91    static void setFontLoadEventsEnabled(bool isEnabled) { isFontLoadEventsEnabled = isEnabled; }
     92    static bool fontLoadEventsEnabled() { return isFontLoadEventsEnabled; }
     93#else
     94    static void setFontLoadEventsEnabled(bool) { }
     95    static bool fontLoadEventsEnabled() { return false; }
     96#endif
     97
    9098#if ENABLE(FULLSCREEN_API)
    9199    // Mozilla version
    … …  
    397405#endif
    398406
     407#if ENABLE(FONT_LOAD_EVENTS)
     408    static bool isFontLoadEventsEnabled;
     409#endif
     410
    399411};
    400412

  • trunk/Source/WebKit/chromium/ChangeLog

    r144712 r144725  
     12013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
     2
     3        [Chromium] Add runtime flag for font load events
     4        https://bugs.webkit.org/show_bug.cgi?id=111296
     5
     6        Reviewed by Kent Tamura.
     7
     8        Add a runtime feature flag for FontLoader interface (disabled by default),
     9        and enable ENABLE_FONT_LOAD_EVENTS build flag for chromium.
     10
     11        * features.gypi:
     12        * public/WebRuntimeFeatures.h:
     13        (WebRuntimeFeatures):
     14        * src/WebRuntimeFeatures.cpp:
     15        (WebKit::WebRuntimeFeatures::enableFontLoadEvents):
     16        (WebKit):
     17        (WebKit::WebRuntimeFeatures::isFontLoadEventsEnabled):
     18
    1192013-03-04  Sheriff Bot  <webkit.review.bot@gmail.com>
    220

  • trunk/Source/WebKit/chromium/features.gypi

    r144646 r144725  
    7070      'ENABLE_FILE_SYSTEM=1',
    7171      'ENABLE_FILTERS=1',
    72       'ENABLE_FONT_LOAD_EVENTS=0',
     72      'ENABLE_FONT_LOAD_EVENTS=1',
    7373      'ENABLE_FULLSCREEN_API=1',
    7474      'ENABLE_GAMEPAD=1',

  • trunk/Source/WebKit/chromium/public/WebRuntimeFeatures.h

    r143865 r144725  
    165165    WEBKIT_EXPORT static bool isCSSRegionsEnabled();
    166166
     167    WEBKIT_EXPORT static void enableFontLoadEvents(bool);
     168    WEBKIT_EXPORT static bool isFontLoadEventsEnabled();
     169
    167170    WEBKIT_EXPORT static void enableExperimentalContentSecurityPolicyFeatures(bool);
    168171    WEBKIT_EXPORT static bool isExperimentalContentSecurityPolicyFeaturesEnabled();

  • trunk/Source/WebKit/chromium/src/WebRuntimeFeatures.cpp

    r143865 r144725  
    711711}
    712712
     713void WebRuntimeFeatures::enableFontLoadEvents(bool enable)
     714{
     715    RuntimeEnabledFeatures::setFontLoadEventsEnabled(enable);
     716}
     717
     718bool WebRuntimeFeatures::isFontLoadEventsEnabled()
     719{
     720    return RuntimeEnabledFeatures::fontLoadEventsEnabled();
     721}
     722
    713723void WebRuntimeFeatures::enableRequestAutocomplete(bool enable)
    714724{
Note: See TracChangeset for help on using the changeset viewer.