Changeset 144837 in webkit

Timestamp:

Mar 5, 2013 3:59:52 PM (11 years ago)

Author:

eae@chromium.org

Message:

ASSERTION FAILED: i < size(), UNKNOWN in WebCore::RenderTableSection::layout
​https://bugs.webkit.org/show_bug.cgi?id=108838

Source/WebCore:

Reviewed by Levi Weintraub.

Ensure that RenderTable::recalcSections is called when moving a
TableSection by calling setNeedsSectionRecalc in addChild for
TableSections.

Test: fullscreen/full-screen-table-section.html

• rendering/RenderTable.cpp:

(WebCore::RenderTable::addChild):

LayoutTests:

Reviewed by Levi Weintraub.

Add test for calling requestFullscreen on an element with a
table-section display type.

• fullscreen/full-screen-table-section-expected.txt: Added.
• fullscreen/full-screen-table-section.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fullscreen/full-screen-table-section-expected.txt (added)
• LayoutTests/fullscreen/full-screen-table-section.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderTable.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-05  Emil A Eklund  <eae@chromium.org>
+
+        ASSERTION FAILED: i < size(), UNKNOWN in WebCore::RenderTableSection::layout
+        https://bugs.webkit.org/show_bug.cgi?id=108838
+
+        Reviewed by Levi Weintraub.
+        
+        Add test for calling requestFullscreen on an element with a
+        table-section display type.
+
+        * fullscreen/full-screen-table-section-expected.txt: Added.
+        * fullscreen/full-screen-table-section.html: Added.
+
 2013-03-05  Roger Fong  <roger_fong@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-05  Emil A Eklund  <eae@chromium.org>
+
+        ASSERTION FAILED: i < size(), UNKNOWN in WebCore::RenderTableSection::layout
+        https://bugs.webkit.org/show_bug.cgi?id=108838
+
+        Reviewed by Levi Weintraub.
+        
+        Ensure that RenderTable::recalcSections is called when moving a
+        TableSection by calling setNeedsSectionRecalc in addChild for
+        TableSections.
+
+        Test: fullscreen/full-screen-table-section.html
+
+        * rendering/RenderTable.cpp:
+        (WebCore::RenderTable::addChild):
+
 2013-03-05  Kenneth Russell  <kbr@google.com>
 

trunk/Source/WebCore/rendering/RenderTable.cpp

@@ -154 +154 @@
     else
         wrapInAnonymousSection = true;
+
+    if (child->isTableSection())
+        setNeedsSectionRecalc();
 
     if (!wrapInAnonymousSection) {