Changeset 145070 in webkit

Timestamp:

Mar 7, 2013 6:22:48 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK] Expose "ShouldRespectImageOrientation" setting into WebKitWebSettings
​https://bugs.webkit.org/show_bug.cgi?id=111414

Patch by Tomas Popela <​tpopela@redhat.com> on 2013-03-07
Reviewed by Carlos Garcia Campos.

We should expose ShouldRespectImageOrientation setting into
WebKitWebSettings. When it is enabled, the images are shown with right
orientation regarding to images EXIF data.

• webkit/webkitwebsettings.cpp:

(webkit_web_settings_class_init):
(webkit_web_settings_set_property):
(webkit_web_settings_get_property):

• webkit/webkitwebsettingsprivate.h:
• webkit/webkitwebview.cpp:

(webkit_web_view_update_settings):
(webkit_web_view_settings_notify):

Location:

trunk/Source/WebKit/gtk

Files:

• ChangeLog (modified) (1 diff)
• webkit/webkitwebsettings.cpp (modified) (4 diffs)
• webkit/webkitwebsettingsprivate.h (modified) (1 diff)
• webkit/webkitwebview.cpp (modified) (2 diffs)

trunk/Source/WebKit/gtk/ChangeLog

@@ +1 @@
+2013-03-07  Tomas Popela  <tpopela@redhat.com>
+
+        [GTK] Expose "ShouldRespectImageOrientation" setting into WebKitWebSettings
+        https://bugs.webkit.org/show_bug.cgi?id=111414
+
+        Reviewed by Carlos Garcia Campos.
+
+        We should expose ShouldRespectImageOrientation setting into
+        WebKitWebSettings. When it is enabled, the images are shown with right
+        orientation regarding to images EXIF data.
+
+        * webkit/webkitwebsettings.cpp:
+        (webkit_web_settings_class_init):
+        (webkit_web_settings_set_property):
+        (webkit_web_settings_get_property):
+        * webkit/webkitwebsettingsprivate.h:
+        * webkit/webkitwebview.cpp:
+        (webkit_web_view_update_settings):
+        (webkit_web_view_settings_notify):
+
 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
 

trunk/Source/WebKit/gtk/webkit/webkitwebsettings.cpp

@@ -80 +80 @@
     PROP_AUTO_LOAD_IMAGES,
     PROP_AUTO_SHRINK_IMAGES,
+    PROP_RESPECT_IMAGE_ORIENTATION,
     PROP_PRINT_BACKGROUNDS,
     PROP_ENABLE_SCRIPTS,
@@ -281 +282 @@
 
     g_object_class_install_property(gobject_class,
+                                    PROP_RESPECT_IMAGE_ORIENTATION,
+                                    g_param_spec_boolean(
+                                    "respect-image-orientation",
+                                    _("Respect Image Orientation"),
+                                    _("Whether WebKit should respect image orientation."),
+                                    FALSE,
+                                    flags));
+
+    g_object_class_install_property(gobject_class,
                                     PROP_PRINT_BACKGROUNDS,
                                     g_param_spec_boolean(
@@ -1076 +1086 @@
         priv->autoShrinkImages = g_value_get_boolean(value);
         break;
+    case PROP_RESPECT_IMAGE_ORIENTATION:
+        priv->respectImageOrientation = g_value_get_boolean(value);
+        break;
     case PROP_PRINT_BACKGROUNDS:
         priv->printBackgrounds = g_value_get_boolean(value);
@@ -1264 +1277 @@
     case PROP_AUTO_SHRINK_IMAGES:
         g_value_set_boolean(value, priv->autoShrinkImages);
+        break;
+    case PROP_RESPECT_IMAGE_ORIENTATION:
+        g_value_set_boolean(value, priv->respectImageOrientation);
         break;
     case PROP_PRINT_BACKGROUNDS:

trunk/Source/WebKit/gtk/webkit/webkitwebsettingsprivate.h

@@ -44 +44 @@
     gboolean autoLoadImages;
     gboolean autoShrinkImages;
+    gboolean respectImageOrientation;
     gboolean printBackgrounds;
     gboolean enableScripts;

trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp

@@ -3386 +3386 @@
     coreSettings->setLoadsImagesAutomatically(settingsPrivate->autoLoadImages);
     coreSettings->setShrinksStandaloneImagesToFit(settingsPrivate->autoShrinkImages);
+    coreSettings->setShouldRespectImageOrientation(settingsPrivate->respectImageOrientation);
     coreSettings->setShouldPrintBackgrounds(settingsPrivate->printBackgrounds);
     coreSettings->setScriptEnabled(settingsPrivate->enableScripts);
@@ -3505 +3506 @@
     else if (name == g_intern_string("auto-shrink-images"))
         settings->setShrinksStandaloneImagesToFit(g_value_get_boolean(&value));
+    else if (name == g_intern_string("respect-image-orientation"))
+        settings->setShouldRespectImageOrientation(g_value_get_boolean(&value));
     else if (name == g_intern_string("print-backgrounds"))
         settings->setShouldPrintBackgrounds(g_value_get_boolean(&value));