Changeset 145276 in webkit

Timestamp:

Mar 8, 2013 3:27:11 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[chromium] Keydown event for 'shift+alt' returns win keycode instead of 'alt'
​https://bugs.webkit.org/show_bug.cgi?id=111112

Patch by Chandra Shekar Vallala <​brk376@motorola.com> on 2013-03-08
Reviewed by Tony Chang.

.:

Return windows keycode of Alt incase of GDK_META_L, GDK_META_R.

Try press Shift then alt key. The test passes if the shiftKey, altKey values
of JSKeyEvent are true and keycode/which is 18.

• ManualTests/shift-alt-key-event.html: Added.

Source/WebCore:

Return windows keycode of Alt incase of GDK_META_L, GDK_META_R. This matches
the firefox behaviour in linux platform.

Added Manual Test : ManualTests/shift-alt-key-event.html
Try press Shift then alt key. The test passes if the shiftKey, altKey values
of JSKeyEvent are true and keycode/which is 18.

• platform/chromium/KeyCodeConversionGtk.cpp:

(WebCore::windowsKeyCodeForKeyEvent):

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• ManualTests/shift-alt-key-event.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/platform/chromium/KeyCodeConversionGtk.cpp (modified) (2 diffs)

trunk/ChangeLog

@@ +1 @@
+2013-03-08  Chandra Shekar Vallala  <brk376@motorola.com>
+
+        [chromium] Keydown event for 'shift+alt' returns win keycode instead of 'alt'
+        https://bugs.webkit.org/show_bug.cgi?id=111112
+
+        Reviewed by Tony Chang.
+
+        Return windows keycode of Alt incase of GDK_META_L, GDK_META_R.
+
+        Try press Shift then alt key. The test passes if the shiftKey, altKey values
+        of JSKeyEvent are true and keycode/which is 18.
+
+        * ManualTests/shift-alt-key-event.html: Added.
+
 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-08  Chandra Shekar Vallala  <brk376@motorola.com>
+
+        [chromium] Keydown event for 'shift+alt' returns win keycode instead of 'alt'
+        https://bugs.webkit.org/show_bug.cgi?id=111112
+
+        Reviewed by Tony Chang.
+
+        Return windows keycode of Alt incase of GDK_META_L, GDK_META_R. This matches
+        the firefox behaviour in linux platform.
+
+        Added Manual Test : ManualTests/shift-alt-key-event.html
+        Try press Shift then alt key. The test passes if the shiftKey, altKey values
+        of JSKeyEvent are true and keycode/which is 18.
+
+        * platform/chromium/KeyCodeConversionGtk.cpp:
+        (WebCore::windowsKeyCodeForKeyEvent):
+
 2013-03-08  Mike West  <mkwst@chromium.org>
 

trunk/Source/WebCore/platform/chromium/KeyCodeConversionGtk.cpp

@@ -119 +119 @@
         return VKEY_APPS;  // (5D) Applications key (Natural keyboard)
     case GDK_Alt_L:
+    case GDK_Meta_L:
         return VKEY_LMENU; // (A4) Left ALT key
     case GDK_Alt_R:
+    case GDK_Meta_R:
     case GDK_ISO_Level3_Shift:
         return VKEY_RMENU; // (A5) Right ALT key
@@ -286 +288 @@
     case GDK_Z:
         return VKEY_Z; //  (5A) Z key case 'z': case 'Z': return 0x5A;
-    case GDK_Meta_L:
     case GDK_Super_L:
         return VKEY_LWIN; // (5B) Left Windows key (Microsoft Natural keyboard)
-    case GDK_Meta_R:
     case GDK_Super_R:
         return VKEY_RWIN; // (5C) Right Windows key (Natural keyboard)