Changeset 145334 in webkit
- Timestamp:
- Mar 10, 2013 3:37:37 PM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r145333 r145334 1 2013-03-10 Jason Anderssen <janderssen@gmail.com> 2 3 Conformance Test 1.0.3 (Beta) function: bufferData undefined value failed. 4 https://bugs.webkit.org/show_bug.cgi?id=111641 5 6 Reviewed by Dean Jackson. 7 8 The WebGL specification requires that a size of 0 is not valid. In javascript, passing in undefined 9 as a parameter to a long long is the same as passing in 0, so we must check for this incorrect 10 value and fail. 11 The test suite in Kronos 1.0.3 failed, test to verify conformance is as follows: 12 https://www.khronos.org/registry/webgl/sdk/tests/conformance/more/functions/bufferDataBadArgs.html. 13 14 * html/canvas/WebGLRenderingContext.cpp: 15 (WebCore::WebGLRenderingContext::bufferData): 16 Synthesize error and returned if size is 0. 17 1 18 2013-03-10 Andreas Kling <akling@apple.com> 2 19 -
trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp
r145159 r145334 1110 1110 if (size < 0) { 1111 1111 synthesizeGLError(GraphicsContext3D::INVALID_VALUE, "bufferData", "size < 0"); 1112 return; 1113 } 1114 if (!size) { 1115 synthesizeGLError(GraphicsContext3D::INVALID_VALUE, "bufferData", "size == 0"); 1112 1116 return; 1113 1117 }
Note: See TracChangeset
for help on using the changeset viewer.