Changeset 145334 in webkit


Ignore:
Timestamp:
Mar 10, 2013 3:37:37 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Conformance Test 1.0.3 (Beta) function: bufferData undefined value failed.
https://bugs.webkit.org/show_bug.cgi?id=111641

Patch by Jason Anderssen <janderssen@gmail.com> on 2013-03-10
Reviewed by Dean Jackson.

The WebGL specification requires that a size of 0 is not valid. In javascript, passing in undefined
as a parameter to a long long is the same as passing in 0, so we must check for this incorrect
value and fail.
The test suite in Kronos 1.0.3 failed, test to verify conformance is as follows:
https://www.khronos.org/registry/webgl/sdk/tests/conformance/more/functions/bufferDataBadArgs.html.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::bufferData):
Synthesize error and returned if size is 0.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r145333 r145334  
     12013-03-10  Jason Anderssen  <janderssen@gmail.com>
     2
     3        Conformance Test 1.0.3 (Beta) function: bufferData undefined value failed.
     4        https://bugs.webkit.org/show_bug.cgi?id=111641
     5
     6        Reviewed by Dean Jackson.
     7
     8        The WebGL specification requires that a size of 0 is not valid. In javascript, passing in undefined
     9        as a parameter to a long long is the same as passing in 0, so we must check for this incorrect
     10        value and fail.
     11        The test suite in Kronos 1.0.3 failed, test to verify conformance is as follows:
     12        https://www.khronos.org/registry/webgl/sdk/tests/conformance/more/functions/bufferDataBadArgs.html.
     13
     14        * html/canvas/WebGLRenderingContext.cpp:
     15        (WebCore::WebGLRenderingContext::bufferData):
     16        Synthesize error and returned if size is 0.
     17
    1182013-03-10  Andreas Kling  <akling@apple.com>
    219
  • trunk/Source/WebCore/html/canvas/WebGLRenderingContext.cpp

    r145159 r145334  
    11101110    if (size < 0) {
    11111111        synthesizeGLError(GraphicsContext3D::INVALID_VALUE, "bufferData", "size < 0");
     1112        return;
     1113    }
     1114    if (!size) {
     1115        synthesizeGLError(GraphicsContext3D::INVALID_VALUE, "bufferData", "size == 0");
    11121116        return;
    11131117    }
Note: See TracChangeset for help on using the changeset viewer.