Changeset 145345 in webkit


Ignore:
Timestamp:
Mar 11, 2013 1:32:10 AM (11 years ago)
Author:
jochen@chromium.org
Message:

[chromium] remove obsolete user gesture methods from WebFrame
https://bugs.webkit.org/show_bug.cgi?id=111696

Reviewed by Adam Barth.

Source/WebKit/chromium:

  • public/WebFrame.h:

(WebFrame):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):

  • src/WebFrameImpl.cpp:
  • src/WebFrameImpl.h:

(WebFrameImpl):

Tools:

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:

(WebTestRunner::TestPlugin::handleInputEvent):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/chromium/ChangeLog

    r145321 r145345  
     12013-03-11  Jochen Eisinger  <jochen@chromium.org>
     2
     3        [chromium] remove obsolete user gesture methods from WebFrame
     4        https://bugs.webkit.org/show_bug.cgi?id=111696
     5
     6        Reviewed by Adam Barth.
     7
     8        * public/WebFrame.h:
     9        (WebFrame):
     10        * src/FrameLoaderClientImpl.cpp:
     11        (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage):
     12        * src/WebFrameImpl.cpp:
     13        * src/WebFrameImpl.h:
     14        (WebFrameImpl):
     15
    1162013-03-09  Sadrul Habib Chowdhury  <sadrul@chromium.org>
    217
  • trunk/Source/WebKit/chromium/public/WebFrame.h

    r145125 r145345  
    403403    virtual unsigned unloadListenerCount() const = 0;
    404404
    405     // Returns true if a user gesture is currently being processed. Deprecated.
    406     virtual bool isProcessingUserGesture() const = 0;
    407 
    408     // Returns true if a consumable gesture exists and has been successfully consumed. Deprecated.
    409     virtual bool consumeUserGesture() const = 0;
    410 
    411405    // Returns true if this frame is in the process of opening a new frame
    412406    // with a suppressed opener.
  • trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp

    r144805 r145345  
    6262#include "Settings.h"
    6363#include "SocketStreamHandleInternal.h"
     64#include "UserGestureIndicator.h"
    6465#if ENABLE(REQUEST_AUTOCOMPLETE)
    6566#include "WebAutofillClient.h"
     
    690691            // block may no longer be required.
    691692            //
    692             // FIXME: Why do we call isProcessingUserGesture here but none of
     693            // FIXME: Why do we call processingUserGesture here but none of
    693694            // the other ports do?
    694695            bool wasClientRedirect =
    695696                (url == m_expectedClientRedirectDest && chainEnd == m_expectedClientRedirectSrc)
    696                 || !m_webFrame->isProcessingUserGesture();
     697                || !UserGestureIndicator::processingUserGesture();
    697698
    698699            if (wasClientRedirect) {
  • trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp

    r144951 r145345  
    174174#include "WebSecurityOrigin.h"
    175175#include "WebSerializedScriptValue.h"
    176 #include "WebUserGestureIndicator.h"
    177176#include "WebViewImpl.h"
    178177#include "XPathResult.h"
     
    11091108}
    11101109
    1111 bool WebFrameImpl::isProcessingUserGesture() const
    1112 {
    1113     return WebUserGestureIndicator::isProcessingUserGesture();
    1114 }
    1115 
    1116 bool WebFrameImpl::consumeUserGesture() const
    1117 {
    1118     return WebUserGestureIndicator::consumeUserGesture();
    1119 }
    1120 
    11211110bool WebFrameImpl::willSuppressOpenerInNewFrame() const
    11221111{
  • trunk/Source/WebKit/chromium/src/WebFrameImpl.h

    r144696 r145345  
    164164    virtual void commitDocumentData(const char* data, size_t length);
    165165    virtual unsigned unloadListenerCount() const;
    166     virtual bool isProcessingUserGesture() const;
    167     virtual bool consumeUserGesture() const;
    168166    virtual bool willSuppressOpenerInNewFrame() const;
    169167    virtual void replaceSelection(const WebString&);
  • trunk/Tools/ChangeLog

    r145339 r145345  
     12013-03-11  Jochen Eisinger  <jochen@chromium.org>
     2
     3        [chromium] remove obsolete user gesture methods from WebFrame
     4        https://bugs.webkit.org/show_bug.cgi?id=111696
     5
     6        Reviewed by Adam Barth.
     7
     8        * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
     9        (WebTestRunner::TestPlugin::handleInputEvent):
     10        * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
     11
    1122013-03-10  Silvia Pfeiffer  <silviapf@chromium.org>
    213
  • trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp

    r143105 r145345  
    3434#include "WebTestDelegate.h"
    3535#include "WebTouchPoint.h"
     36#include "WebUserGestureIndicator.h"
    3637#include <public/Platform.h>
    3738#include <public/WebCompositorSupport.h>
     
    516517        printEventDetails(m_delegate, event);
    517518    if (m_printUserGestureStatus)
    518         m_delegate->printMessage(std::string("* ") + (m_frame->isProcessingUserGesture() ? "" : "not ") + "handling user gesture\n");
     519        m_delegate->printMessage(std::string("* ") + (WebUserGestureIndicator::isProcessingUserGesture() ? "" : "not ") + "handling user gesture\n");
    519520    return false;
    520521}
  • trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp

    r144635 r145345  
    6060#include "WebTestInterfaces.h"
    6161#include "WebTestRunner.h"
     62#include "WebUserGestureIndicator.h"
    6263#include "WebUserMediaClientMock.h"
    6364#include "WebView.h"
     
    157158void printFrameUserGestureStatus(WebTestDelegate* delegate, WebFrame* frame, const char* msg)
    158159{
    159     bool isUserGesture = frame->isProcessingUserGesture();
     160    bool isUserGesture = WebUserGestureIndicator::isProcessingUserGesture();
    160161    delegate->printMessage(string("Frame with user gesture \"") + (isUserGesture ? "true" : "false") + "\"" + msg);
    161162}
Note: See TracChangeset for help on using the changeset viewer.