Changeset 145345 in webkit
- Timestamp:
- Mar 11, 2013 1:32:10 AM (11 years ago)
- Location:
- trunk
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/chromium/ChangeLog
r145321 r145345 1 2013-03-11 Jochen Eisinger <jochen@chromium.org> 2 3 [chromium] remove obsolete user gesture methods from WebFrame 4 https://bugs.webkit.org/show_bug.cgi?id=111696 5 6 Reviewed by Adam Barth. 7 8 * public/WebFrame.h: 9 (WebFrame): 10 * src/FrameLoaderClientImpl.cpp: 11 (WebKit::FrameLoaderClientImpl::dispatchDidNavigateWithinPage): 12 * src/WebFrameImpl.cpp: 13 * src/WebFrameImpl.h: 14 (WebFrameImpl): 15 1 16 2013-03-09 Sadrul Habib Chowdhury <sadrul@chromium.org> 2 17 -
trunk/Source/WebKit/chromium/public/WebFrame.h
r145125 r145345 403 403 virtual unsigned unloadListenerCount() const = 0; 404 404 405 // Returns true if a user gesture is currently being processed. Deprecated.406 virtual bool isProcessingUserGesture() const = 0;407 408 // Returns true if a consumable gesture exists and has been successfully consumed. Deprecated.409 virtual bool consumeUserGesture() const = 0;410 411 405 // Returns true if this frame is in the process of opening a new frame 412 406 // with a suppressed opener. -
trunk/Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp
r144805 r145345 62 62 #include "Settings.h" 63 63 #include "SocketStreamHandleInternal.h" 64 #include "UserGestureIndicator.h" 64 65 #if ENABLE(REQUEST_AUTOCOMPLETE) 65 66 #include "WebAutofillClient.h" … … 690 691 // block may no longer be required. 691 692 // 692 // FIXME: Why do we call isProcessingUserGesture here but none of693 // FIXME: Why do we call processingUserGesture here but none of 693 694 // the other ports do? 694 695 bool wasClientRedirect = 695 696 (url == m_expectedClientRedirectDest && chainEnd == m_expectedClientRedirectSrc) 696 || ! m_webFrame->isProcessingUserGesture();697 || !UserGestureIndicator::processingUserGesture(); 697 698 698 699 if (wasClientRedirect) { -
trunk/Source/WebKit/chromium/src/WebFrameImpl.cpp
r144951 r145345 174 174 #include "WebSecurityOrigin.h" 175 175 #include "WebSerializedScriptValue.h" 176 #include "WebUserGestureIndicator.h"177 176 #include "WebViewImpl.h" 178 177 #include "XPathResult.h" … … 1109 1108 } 1110 1109 1111 bool WebFrameImpl::isProcessingUserGesture() const1112 {1113 return WebUserGestureIndicator::isProcessingUserGesture();1114 }1115 1116 bool WebFrameImpl::consumeUserGesture() const1117 {1118 return WebUserGestureIndicator::consumeUserGesture();1119 }1120 1121 1110 bool WebFrameImpl::willSuppressOpenerInNewFrame() const 1122 1111 { -
trunk/Source/WebKit/chromium/src/WebFrameImpl.h
r144696 r145345 164 164 virtual void commitDocumentData(const char* data, size_t length); 165 165 virtual unsigned unloadListenerCount() const; 166 virtual bool isProcessingUserGesture() const;167 virtual bool consumeUserGesture() const;168 166 virtual bool willSuppressOpenerInNewFrame() const; 169 167 virtual void replaceSelection(const WebString&); -
trunk/Tools/ChangeLog
r145339 r145345 1 2013-03-11 Jochen Eisinger <jochen@chromium.org> 2 3 [chromium] remove obsolete user gesture methods from WebFrame 4 https://bugs.webkit.org/show_bug.cgi?id=111696 5 6 Reviewed by Adam Barth. 7 8 * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: 9 (WebTestRunner::TestPlugin::handleInputEvent): 10 * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: 11 1 12 2013-03-10 Silvia Pfeiffer <silviapf@chromium.org> 2 13 -
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp
r143105 r145345 34 34 #include "WebTestDelegate.h" 35 35 #include "WebTouchPoint.h" 36 #include "WebUserGestureIndicator.h" 36 37 #include <public/Platform.h> 37 38 #include <public/WebCompositorSupport.h> … … 516 517 printEventDetails(m_delegate, event); 517 518 if (m_printUserGestureStatus) 518 m_delegate->printMessage(std::string("* ") + ( m_frame->isProcessingUserGesture() ? "" : "not ") + "handling user gesture\n");519 m_delegate->printMessage(std::string("* ") + (WebUserGestureIndicator::isProcessingUserGesture() ? "" : "not ") + "handling user gesture\n"); 519 520 return false; 520 521 } -
trunk/Tools/DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp
r144635 r145345 60 60 #include "WebTestInterfaces.h" 61 61 #include "WebTestRunner.h" 62 #include "WebUserGestureIndicator.h" 62 63 #include "WebUserMediaClientMock.h" 63 64 #include "WebView.h" … … 157 158 void printFrameUserGestureStatus(WebTestDelegate* delegate, WebFrame* frame, const char* msg) 158 159 { 159 bool isUserGesture = frame->isProcessingUserGesture();160 bool isUserGesture = WebUserGestureIndicator::isProcessingUserGesture(); 160 161 delegate->printMessage(string("Frame with user gesture \"") + (isUserGesture ? "true" : "false") + "\"" + msg); 161 162 }
Note: See TracChangeset
for help on using the changeset viewer.