Changeset 145408 in webkit


Ignore:
Timestamp:
Mar 11, 2013 2:48:19 PM (11 years ago)
Author:
benjamin@webkit.org
Message:

Modernize the test visited-link-background-color.html
​https://bugs.webkit.org/show_bug.cgi?id=111931

Reviewed by Sam Weinig.

Make the test a ref-test instead of a pixel test.

Use Internals' computedStyleIncludingVisitedInfo to make the test reliable
on platforms where the visited link list is updated asynchronously.

  • fast/history/visited-link-background-color-expected.html: Copied from LayoutTests/fast/history/visited-link-background-color.html.
  • fast/history/visited-link-background-color.html:
  • platform/chromium-linux/fast/history/visited-link-background-color-expected.png: Removed.
  • platform/chromium-win/fast/history/visited-link-background-color-expected.png: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/history/visited-link-background-color-expected.png: Removed.
  • platform/chromium/fast/history/visited-link-background-color-expected.txt: Removed.
  • platform/efl-wk1/fast/history/visited-link-background-color-expected.png: Removed.
  • platform/efl/fast/history/visited-link-background-color-expected.png: Removed.
  • platform/efl/fast/history/visited-link-background-color-expected.txt: Removed.
  • platform/gtk/fast/history/visited-link-background-color-expected.png: Removed.
  • platform/gtk/fast/history/visited-link-background-color-expected.txt: Removed.
  • platform/mac-wk2/fast/history/visited-link-background-color-expected.png: Removed.
  • platform/mac-wk2/fast/history/visited-link-background-color-expected.txt: Removed.
  • platform/mac/fast/history/visited-link-background-color-expected.png: Removed.
  • platform/mac/fast/history/visited-link-background-color-expected.txt: Removed.
  • platform/qt/fast/history/visited-link-background-color-expected.png: Removed.
  • platform/qt/fast/history/visited-link-background-color-expected.txt: Removed.
Location:
trunk/LayoutTests
Files:
1 added
12 deleted
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r145402 r145408  
     12013-03-11  Benjamin Poulain  <benjamin@webkit.org>
     2
     3        Modernize the test visited-link-background-color.html
     4        https://bugs.webkit.org/show_bug.cgi?id=111931
     5
     6        Reviewed by Sam Weinig.
     7
     8        Make the test a ref-test instead of a pixel test.
     9
     10        Use Internals' computedStyleIncludingVisitedInfo to make the test reliable
     11        on platforms where the visited link list is updated asynchronously.
     12
     13        * fast/history/visited-link-background-color-expected.html: Copied from LayoutTests/fast/history/visited-link-background-color.html.
     14        * fast/history/visited-link-background-color.html:
     15        * platform/chromium-linux/fast/history/visited-link-background-color-expected.png: Removed.
     16        * platform/chromium-win/fast/history/visited-link-background-color-expected.png: Removed.
     17        * platform/chromium/TestExpectations:
     18        * platform/chromium/fast/history/visited-link-background-color-expected.png: Removed.
     19        * platform/chromium/fast/history/visited-link-background-color-expected.txt: Removed.
     20        * platform/efl-wk1/fast/history/visited-link-background-color-expected.png: Removed.
     21        * platform/efl/fast/history/visited-link-background-color-expected.png: Removed.
     22        * platform/efl/fast/history/visited-link-background-color-expected.txt: Removed.
     23        * platform/gtk/fast/history/visited-link-background-color-expected.png: Removed.
     24        * platform/gtk/fast/history/visited-link-background-color-expected.txt: Removed.
     25        * platform/mac-wk2/fast/history/visited-link-background-color-expected.png: Removed.
     26        * platform/mac-wk2/fast/history/visited-link-background-color-expected.txt: Removed.
     27        * platform/mac/fast/history/visited-link-background-color-expected.png: Removed.
     28        * platform/mac/fast/history/visited-link-background-color-expected.txt: Removed.
     29        * platform/qt/fast/history/visited-link-background-color-expected.png: Removed.
     30        * platform/qt/fast/history/visited-link-background-color-expected.txt: Removed.
     31
    1322013-03-11  Sheriff Bot  <webkit.review.bot@gmail.com>
    233

  • trunk/LayoutTests/fast/history/visited-link-background-color.html

    r121012 r145408  
    1010</style>
    1111<script>
    12 if (window.testRunner)
    13     window.testRunner.keepWebHistory();
     12if (window.testRunner) {
     13    testRunner.waitUntilDone();
     14    testRunner.keepWebHistory();
     15}
     16function waitForStyleChange(failureTime)
     17{
     18    var aElement = document.getElementsByTagName('a')[0];
     19    if (internals.computedStyleIncludingVisitedInfo(aElement).color === 'rgb(255, 255, 255)')
     20        testRunner.notifyDone();
     21    else if (Date.now() > failureTime)
     22        testRunner.notifyDone();
     23    else
     24        setTimeout(waitForStyleChange, 5, failureTime);
     25}
     26function doTest()
     27{
     28    if (window.testRunner)
     29        waitForStyleChange(Date.now() + 500);
     30}
    1431</script>
    15 <body>
     32<body onload="doTest()">
    1633<iframe src="resources/dummy.html" style="display:none"></iframe>
    1734<a href="resources/dummy.html">This text should be white on an olive background.</a>
     35</body>

  • trunk/LayoutTests/platform/chromium/TestExpectations

    r145402 r145408  
    21952195webkit.org/b/111031 fast/history/sibling-visited-test.html [ Failure ]
    21962196webkit.org/b/111031 fast/loader/stateobjects/state-url-sets-links-visited.html [ Failure ]
    2197 webkit.org/b/111031 [ Mac Android ] fast/history/visited-link-background-color.html [ Failure ]
     2197webkit.org/b/111031 fast/history/visited-link-background-color.html [ ImageOnlyFailure ]
    21982198
    21992199# Tests that work with KURL, but fail with GURL
Note: See TracChangeset for help on using the changeset viewer.