Changeset 145548 in webkit
- Timestamp:
- Mar 12, 2013 8:19:37 AM (11 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 6 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r145547 r145548 1 2013-03-12 Eugene Klyuchnikov <eustas@chromium.org> 2 3 Web Inspector: [REGRESSION] StepInto (F11) and StepOut (Shift-F11) shortcuts toggle Inspector window full-screen state 4 https://bugs.webkit.org/show_bug.cgi?id=112113 5 6 Reviewed by Alexander Pavlov. 7 8 Updated handlers missed in first patch. Added JSDocs to all handlers. 9 10 * inspector/front-end/Panel.js: Fixed JSDocs. 11 * inspector/front-end/CallStackSidebarPane.js: 12 Added return values. Added JSDocs. 13 * inspector/front-end/ScriptsPanel.js: Ditto. 14 * inspector/front-end/GoToLineDialog.js: Added JSDocs. 15 * inspector/front-end/TimelinePanel.js: Ditto. 16 1 17 2013-03-12 Alberto Garcia <agarcia@igalia.com> 2 18 -
trunk/Source/WebCore/inspector/front-end/CallStackSidebarPane.js
r142127 r145548 69 69 }, 70 70 71 _selectNextCallFrameOnStack: function() 71 /** 72 * @param {Event=} event 73 * @return {boolean} 74 */ 75 _selectNextCallFrameOnStack: function(event) 72 76 { 73 77 var index = this._selectedCallFrameIndex(); 74 78 if (index == -1) 75 return ;79 return true; 76 80 this._selectedPlacardByIndex(index + 1); 77 }, 78 79 _selectPreviousCallFrameOnStack: function() 81 return true; 82 }, 83 84 /** 85 * @param {Event=} event 86 * @return {boolean} 87 */ 88 _selectPreviousCallFrameOnStack: function(event) 80 89 { 81 90 var index = this._selectedCallFrameIndex(); 82 91 if (index == -1) 83 return ;92 return true; 84 93 this._selectedPlacardByIndex(index - 1); 85 }, 86 94 return true; 95 }, 96 97 /** 98 * @param {number} index 99 */ 87 100 _selectedPlacardByIndex: function(index) 88 101 { … … 92 105 }, 93 106 107 /** 108 * @return {number} 109 */ 94 110 _selectedCallFrameIndex: function() 95 111 { … … 118 134 119 135 /** 120 * @param {function(!Array.<!WebInspector.KeyboardShortcut.Descriptor>, function( KeyboardEvent))} registerShortcutDelegate136 * @param {function(!Array.<!WebInspector.KeyboardShortcut.Descriptor>, function(Event=):boolean)} registerShortcutDelegate 121 137 */ 122 138 registerShortcuts: function(registerShortcutDelegate) -
trunk/Source/WebCore/inspector/front-end/GoToLineDialog.js
r145045 r145548 65 65 /** 66 66 * @param {function():?WebInspector.View} viewGetter 67 * @param {Event=} event 67 68 * @return {boolean} 68 69 */ 69 WebInspector.GoToLineDialog._show = function(viewGetter )70 WebInspector.GoToLineDialog._show = function(viewGetter, event) 70 71 { 71 72 var sourceView = viewGetter(); -
trunk/Source/WebCore/inspector/front-end/Panel.js
r145045 r145548 40 40 this._panelName = name; 41 41 42 this._shortcuts = {};42 this._shortcuts = /** !Object.<number, function(Event=):boolean> */ ({}); 43 43 44 44 WebInspector.settings[this._sidebarWidthSettingName()] = WebInspector.settings.createSetting(this._sidebarWidthSettingName(), undefined); … … 258 258 /** 259 259 * @param {!Array.<!WebInspector.KeyboardShortcut.Descriptor>} keys 260 * @param {function( KeyboardEvent):boolean} handler260 * @param {function(Event=):boolean} handler 261 261 */ 262 262 registerShortcuts: function(keys, handler) -
trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js
r145536 r145548 675 675 }, 676 676 677 _togglePause: function() 677 /** 678 * @param {Event=} event 679 * @return {boolean} 680 */ 681 _togglePause: function(event) 678 682 { 679 683 if (this._paused) { … … 688 692 689 693 this._clearInterface(); 690 }, 691 692 _stepOverClicked: function() 694 return true; 695 }, 696 697 /** 698 * @param {Event=} event 699 * @return {boolean} 700 */ 701 _stepOverClicked: function(event) 693 702 { 694 703 if (!this._paused) 695 return ;704 return true; 696 705 697 706 this._paused = false; … … 701 710 702 711 DebuggerAgent.stepOver(); 703 }, 704 705 _stepIntoClicked: function() 712 return true; 713 }, 714 715 /** 716 * @param {Event=} event 717 * @return {boolean} 718 */ 719 _stepIntoClicked: function(event) 706 720 { 707 721 if (!this._paused) 708 return ;722 return true; 709 723 710 724 this._paused = false; … … 714 728 715 729 DebuggerAgent.stepInto(); 716 }, 717 718 _stepOutClicked: function() 730 return true; 731 }, 732 733 /** 734 * @param {Event=} event 735 * @return {boolean} 736 */ 737 _stepOutClicked: function(event) 719 738 { 720 739 if (!this._paused) 721 return ;740 return true; 722 741 723 742 this._paused = false; … … 727 746 728 747 DebuggerAgent.stepOut(); 748 return true; 729 749 }, 730 750 … … 749 769 }, 750 770 751 _evaluateSelectionInConsole: function() 771 /** 772 * @param {Event=} event 773 * @return {boolean} 774 */ 775 _evaluateSelectionInConsole: function(event) 752 776 { 753 777 var selection = window.getSelection(); … … 815 839 * @param {string} buttonId 816 840 * @param {string} buttonTitle 817 * @param {function(Event )} handler841 * @param {function(Event=):boolean} handler 818 842 * @param {!Array.<!WebInspector.KeyboardShortcut.Descriptor>} shortcuts 819 843 */ … … 956 980 }, 957 981 982 /** 983 * @return {boolean} 984 */ 958 985 _toggleBreakpoint: function() 959 986 { … … 970 997 }, 971 998 972 _showOutlineDialog: function() 999 /** 1000 * @param {Event=} event 1001 * @return {boolean} 1002 */ 1003 _showOutlineDialog: function(event) 973 1004 { 974 1005 var uiSourceCode = this._editorContainer.currentFile(); -
trunk/Source/WebCore/inspector/front-end/TimelinePanel.js
r145537 r145548 345 345 if (InspectorFrontendHost.canSave()) 346 346 this.registerShortcuts(WebInspector.TimelinePanelDescriptor.ShortcutKeys.SaveToFile, this._saveToFile.bind(this)); 347 this.registerShortcuts(WebInspector.TimelinePanelDescriptor.ShortcutKeys.LoadFromFile, this._ fileSelectorElement.click.bind(this._fileSelectorElement));347 this.registerShortcuts(WebInspector.TimelinePanelDescriptor.ShortcutKeys.LoadFromFile, this._selectFileToLoad.bind(this)); 348 348 }, 349 349 … … 362 362 if (InspectorFrontendHost.canSave()) 363 363 contextMenu.appendItem(WebInspector.UIString("Save Timeline data\u2026"), this._saveToFile.bind(this), this._operationInProgress); 364 contextMenu.appendItem(WebInspector.UIString("Load Timeline data\u2026"), this._ fileSelectorElement.click.bind(this._fileSelectorElement), this._operationInProgress);364 contextMenu.appendItem(WebInspector.UIString("Load Timeline data\u2026"), this._selectFileToLoad.bind(this), this._operationInProgress); 365 365 contextMenu.show(); 366 366 }, 367 367 368 _saveToFile: function() 368 /** 369 * @param {Event=} event 370 * @return {boolean} 371 */ 372 _saveToFile: function(event) 369 373 { 370 374 if (this._operationInProgress) 371 return false;375 return true; 372 376 this._model.saveToFile(); 377 return true; 378 }, 379 380 /** 381 * @param {Event=} event 382 * @return {boolean} 383 */ 384 _selectFileToLoad: function(event) { 385 this._fileSelectorElement.click(); 373 386 return true; 374 387 }, … … 561 574 }, 562 575 576 /** 577 * @return {boolean} 578 */ 563 579 _toggleTimelineButtonClicked: function() 564 580 { 565 581 if (this._operationInProgress) 566 return false;582 return true; 567 583 if (this.toggleTimelineButton.toggled) { 568 584 this._model.stopRecord();
Note: See TracChangeset
for help on using the changeset viewer.