Changeset 145754 in webkit

Timestamp:

Mar 13, 2013 2:38:19 PM (11 years ago)

Author:

inferno@chromium.org

Message:

Crash in CompositeEditCommand::insertNodeAt.
​https://bugs.webkit.org/show_bug.cgi?id=112280

Reviewed by Ryosuke Niwa.

• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::insertNodeAt): Fix incorrect cast use of toElement.
Subsitute with toContainerNode.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/CompositeEditCommand.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-13  Abhishek Arya  <inferno@chromium.org>
+
+        Crash in CompositeEditCommand::insertNodeAt.
+        https://bugs.webkit.org/show_bug.cgi?id=112280
+
+        Reviewed by Ryosuke Niwa.
+
+        * editing/CompositeEditCommand.cpp:
+        (WebCore::CompositeEditCommand::insertNodeAt): Fix incorrect cast use of toElement.
+        Subsitute with toContainerNode.
+
 2013-03-13  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/editing/CompositeEditCommand.cpp

@@ -365 +365 @@
             insertNodeBefore(insertChild, child);
         else
-            appendNode(insertChild, toElement(refChild));
+            appendNode(insertChild, toContainerNode(refChild));
     } else if (caretMinOffset(refChild) >= offset)
         insertNodeBefore(insertChild, refChild);