Changeset 145788 in webkit

Timestamp:

Mar 13, 2013 11:52:33 PM (11 years ago)

Author:

rniwa@webkit.org

Message:

Cannot select a canvas element at the beginning or the end of a document
​https://bugs.webkit.org/show_bug.cgi?id=112319

Reviewed by Eric Seidel.

Source/WebCore:

The bug was caused by the editing code treating canvas element as if an empty inline element.
Treat it as an "atomic" element for the purpose of determining whether selection can have
an end point in it or not.

Test: editing/pasteboard/copy-paste-content-starting-and-ending-canvas.html

• html/HTMLCanvasElement.h:

(WebCore::HTMLCanvasElement::canContainRangeEndPoint): Added.

LayoutTests:

Add a regression test to copy and paste a content with canvas elements.

• editing/pasteboard/copy-paste-content-starting-and-ending-canvas-expected.txt: Added.
• editing/pasteboard/copy-paste-content-starting-and-ending-canvas.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/pasteboard/copy-paste-content-starting-and-ending-canvas-expected.txt (added)
• LayoutTests/editing/pasteboard/copy-paste-content-starting-and-ending-canvas.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLCanvasElement.h (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Cannot select a canvas element at the beginning or the end of a document
+        https://bugs.webkit.org/show_bug.cgi?id=112319
+
+        Reviewed by Eric Seidel.
+
+        Add a regression test to copy and paste a content with canvas elements.
+
+        * editing/pasteboard/copy-paste-content-starting-and-ending-canvas-expected.txt: Added.
+        * editing/pasteboard/copy-paste-content-starting-and-ending-canvas.html: Added.
+
 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2013-03-13  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Cannot select a canvas element at the beginning or the end of a document
+        https://bugs.webkit.org/show_bug.cgi?id=112319
+
+        Reviewed by Eric Seidel.
+
+        The bug was caused by the editing code treating canvas element as if an empty inline element.
+        Treat it as an "atomic" element for the purpose of determining whether selection can have
+        an end point in it or not.
+
+        Test: editing/pasteboard/copy-paste-content-starting-and-ending-canvas.html
+
+        * html/HTMLCanvasElement.h:
+        (WebCore::HTMLCanvasElement::canContainRangeEndPoint): Added.
+
 2013-03-13  Kunihiko Sakamoto  <ksakamoto@chromium.org>
 

trunk/Source/WebCore/html/HTMLCanvasElement.h

@@ -140 +140 @@
     float deviceScaleFactor() const { return m_deviceScaleFactor; }
 
+    virtual bool canContainRangeEndPoint() const { return false; }
+
     virtual void reportMemoryUsage(MemoryObjectInfo*) const OVERRIDE;