Changeset 14602 in webkit

Timestamp:

May 25, 2006 5:15:13 PM (18 years ago)

Author:

aliceli1

Message:

Reviewed by Adele.

• bindings/js/kjs_html.cpp: added bindings (KJS::HTMLElementFunction::callAsFunction): added case to handle namedItem for select elements
• bindings/js/kjs_html.h: added enum value for bindings (KJS::JSHTMLElement::):
• html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::namedItem): implemented namedItem method
• html/HTMLSelectElement.h: added prototype for namedItem method

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bindings/js/kjs_html.cpp (modified) (2 diffs)
• bindings/js/kjs_html.h (modified) (1 diff)
• html/HTMLSelectElement.cpp (modified) (1 diff)
• html/HTMLSelectElement.h (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2006-05-25  Alice Liu  <alice.liu@apple.com>
+
+        Reviewed by Adele.
+
+        * bindings/js/kjs_html.cpp:
+        added bindings
+        (KJS::HTMLElementFunction::callAsFunction):
+        added case to handle namedItem for select elements
+        * bindings/js/kjs_html.h:
+        added enum value for bindings
+        (KJS::JSHTMLElement::):
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::namedItem):
+        implemented namedItem method
+        * html/HTMLSelectElement.h:
+        added prototype for namedItem method
+
 2006-05-25  Dave Hyatt <hyatt@apple.com>
 

trunk/WebCore/bindings/js/kjs_html.cpp

@@ -556 +556 @@
   form          KJS::JSHTMLElement::SelectForm    DontDelete|ReadOnly
   options       KJS::JSHTMLElement::SelectOptions DontDelete|ReadOnly
+  namedItem     KJS::JSHTMLElement::SelectNamedItem       DontDelete|Function 1
   disabled      KJS::JSHTMLElement::SelectDisabled        DontDelete
   multiple      KJS::JSHTMLElement::SelectMultiple        DontDelete
@@ -1203 +1204 @@
             return jsUndefined();
         }
+        else if (id == JSHTMLElement::SelectNamedItem) {
+            return toJS(exec, select.namedItem(Identifier(args[0]->toString(exec))));
+        }
     }
     else if (element.hasLocalName(tableTag)) {

trunk/WebCore/bindings/js/kjs_html.h

@@ -125 +125 @@
            SelectTabIndex, SelectValue, SelectSelectedIndex, SelectLength,
            SelectRemove, SelectForm, SelectBlur, SelectType, SelectOptions,
-           SelectDisabled, SelectMultiple, SelectName, SelectSize, SelectFocus,
+           SelectDisabled, SelectMultiple, SelectName, SelectNamedItem, SelectSize, SelectFocus,
            ObjectHspace, ObjectHeight, ObjectAlign,
            ObjectBorder, ObjectCode, ObjectType, ObjectVspace, ObjectArchive,

trunk/WebCore/html/HTMLSelectElement.cpp

@@ -457 +457 @@
     setAttribute(sizeAttr, String::number(size));
 }
-    
+
+Node* HTMLSelectElement::namedItem(const String &name, bool caseSensitive)
+{
+    return (options()->namedItem(name, caseSensitive));
+}
+
 } // namespace

trunk/WebCore/html/HTMLSelectElement.h

@@ -109 +109 @@
     void setSize(int);
 
+    virtual Node* namedItem(const String &name, bool caseSensitive = true);
+
 private:
     void recalcListItems();